From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: Anshuman Khandual <anshuman.khandual@arm.com>,
Will Deacon <will@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
Catalin Marinas <catalin.marinas@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 2/4] arm_pmu: acpi: Add a representative platform device for TRBE
Date: Wed, 2 Aug 2023 11:11:11 +0100 [thread overview]
Message-ID: <2c1894c4-c0e3-ea90-d5f6-24c3ed8c0e4f@arm.com> (raw)
In-Reply-To: <505c6b25-d9e8-d7b3-1a0d-2b51e45fb66a@arm.com>
On 02/08/2023 02:07, Anshuman Khandual wrote:
>
>
> On 8/1/23 20:21, Will Deacon wrote:
>> On Tue, Aug 01, 2023 at 03:10:50PM +0530, Anshuman Khandual wrote:
>>> diff --git a/include/linux/perf/arm_pmu.h b/include/linux/perf/arm_pmu.h
>>> index a0801f68762b..7ec26d21303d 100644
>>> --- a/include/linux/perf/arm_pmu.h
>>> +++ b/include/linux/perf/arm_pmu.h
>>> @@ -187,5 +187,6 @@ void armpmu_free_irq(int irq, int cpu);
>>> #endif /* CONFIG_ARM_PMU */
>>>
>>> #define ARMV8_SPE_PDEV_NAME "arm,spe-v1"
>>> +#define ARMV8_TRBE_PDEV_NAME "arm-trbe-acpi"
>>
>> Why is the TRBE name formatted differently to the SPE one?
>
> Nothing specific, although "arm,spe-v1" seemed more like a DT naming
> scheme. But could change the name as "arm,trbe-v1" to be in sync with
> SPE here.
Do we really need v1 ? I would leave it as arm,trbe
Suzuki
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-08-02 10:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 9:40 [PATCH V2 0/4] coresight: trbe: Enable ACPI based devices Anshuman Khandual
2023-08-01 9:40 ` [PATCH V2 1/4] arm_pmu: acpi: Refactor arm_spe_acpi_register_device() Anshuman Khandual
2023-08-01 14:49 ` Will Deacon
2023-08-02 2:44 ` Anshuman Khandual
2023-08-01 9:40 ` [PATCH V2 2/4] arm_pmu: acpi: Add a representative platform device for TRBE Anshuman Khandual
2023-08-01 14:51 ` Will Deacon
2023-08-02 1:07 ` Anshuman Khandual
2023-08-02 10:11 ` Suzuki K Poulose [this message]
2023-08-03 4:06 ` Anshuman Khandual
2023-08-01 9:40 ` [PATCH V2 3/4] coresight: trbe: Add a representative coresight_platform_data " Anshuman Khandual
2023-08-01 9:40 ` [PATCH V2 4/4] coresight: trbe: Enable ACPI based TRBE devices Anshuman Khandual
2023-08-01 14:52 ` [PATCH V2 0/4] coresight: trbe: Enable ACPI based devices Will Deacon
2023-08-02 0:51 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c1894c4-c0e3-ea90-d5f6-24c3ed8c0e4f@arm.com \
--to=suzuki.poulose@arm.com \
--cc=anshuman.khandual@arm.com \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox