From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6EDF6C77B7F for ; Tue, 24 Jun 2025 20:54:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=RcLpQIGOHnObqeC9JE4WrzqVitzt8nhGtyf8y+j3oKs=; b=jCSGWclwU2s4Bjjlp3TNPIbkDz aQNqRH4KEFp+vG1FoBjB3chAV1QBfW0e5djStH1bsQnWFsMt+sh/1y98ZSUPZBXq47Z+C42cKYcsI EmgfEshVE/9wlBTwvTNjZ3BDoZpoUsyBCj5b2PkG5m6f4BVR4eF9266GCskK3OmL0NYLja9Zr6iTV mlShwbBMJo1iNfrF2qvoK2Z4w+UcKNigDN4Di9N2LKsViwRXYw1Cx0zOycdivnbbGZzOGqW29ec+S b8GbSDSWYbUg3qzpD5VIHHz7fMX3gm7NOGfCDR3+WaXkCyRjZHF8VvF6EvFVwPZLXFtbFFxbuWVNB M3tEeaHg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uUAf1-00000006ot9-2qdK; Tue, 24 Jun 2025 20:54:32 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uU5fK-000000068Ps-1Vok for linux-arm-kernel@lists.infradead.org; Tue, 24 Jun 2025 15:34:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750779269; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=RcLpQIGOHnObqeC9JE4WrzqVitzt8nhGtyf8y+j3oKs=; b=DNcvdTTyYtKBaXtPKB46O7p9VBqSWkf5x9eWGBSq4zD/lq39jGdcjWq/UXPZ0fQHVipV8T gJ4bzvnWO0Ah3TnQqQ3GICX+r37/eRCBvNdWFuvsJFcMItJOIZFif5kFuf455WlJQ3GE0B 18WbXcnQxuYhv87n29lDmlpxphrKT+4= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-397-AFXsBjacNUedGF3hi1BbwA-1; Tue, 24 Jun 2025 11:34:26 -0400 X-MC-Unique: AFXsBjacNUedGF3hi1BbwA-1 X-Mimecast-MFC-AGG-ID: AFXsBjacNUedGF3hi1BbwA_1750779265 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3a4f7f1b932so3700044f8f.2 for ; Tue, 24 Jun 2025 08:34:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750779265; x=1751384065; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=RcLpQIGOHnObqeC9JE4WrzqVitzt8nhGtyf8y+j3oKs=; b=O1BCbYuMY4E+mwxe6cojVBCq6WLnh4dZWQM4ISI6ycmWnEpBnrtcf/nkltCbG4LkGK B8poeGef3tael77DXzTTIoMkinDlvANo3Uq1n2u+0H9mRrHSiNfmjLaOT+CXT6X0m7Pz 4uQ91LLr9C+sUrjCy+xG3USzyol5+raV5RFYc70z768n+I+u3DYJmxxP+RXcL5AYvOaV Xq2FtMBWHswjpvryU/hsLFviKhweq5/SqM4zcwv5ktjkptEzH3OzkTBVy2Z8SD8OIzCD U7sjOcFxbW0COoCR9Wgil6+6KJnNco/U9c8AI2Dv0u/vz4Z2ETlv0XnQP8JlAQ6PLNV8 +gRg== X-Forwarded-Encrypted: i=1; AJvYcCWboru/SV5rojxQAXmdTAv335g35/Yt8U2fSmhhtc1B6g473P6KPgahjUPb/qdso97mSqGwxrxNeFvXs7eEuWFb@lists.infradead.org X-Gm-Message-State: AOJu0Yx84I7sd2q6A5CftIu1ttsnKCbWXyjVOrJk1cBAZ+yekdfQj4Je lwC64OlkLMSY81eCvrp6NEkpKUap6DQcOFEeYhW8M27pGDkEPn7wjKFElkTAQJej9XRBPOY9YoI ttpjhxBVcjY0vllIEivfhZK+uCCQ4odPXJOk3eKcbUXw1eVXQzpasbLvWVfvImuyB/x174qRzcr FK X-Gm-Gg: ASbGncufPJVpxdUEloEHgU+/Jer0cuqc5FnrO5CJiFDD8+V7HekDgHWNzpuyFUd80LD RNC/PkiHsyeYkgEjHumsodkQ0UG87NJmvlR1lfNdpv0dT+c+MjLkVe59pvhZHUh2f6+7CzKeOFx DxObuVVifQv06goEev6HTtf/tPitN6cQCPqpXS04S/xIIE4okiOM0mc5nT3lSCNmFIxVIGf0Qhl UsyJqJN55/4ewULwxg+RIFUi/RaTV2bDsWC4et77A6aNGY5SnS0KYGxYanpPUwX0j6kZ9mtc2B8 THldUA64Z6XH4Htd4h8O6W4iWRrkvspDm7tF/sDkNn2Qg52WvP0Vskg= X-Received: by 2002:a05:6000:644:b0:3a1:fa6c:4735 with SMTP id ffacd0b85a97d-3a6d12de9f5mr15286832f8f.35.1750779265340; Tue, 24 Jun 2025 08:34:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH6Ygv2yKeSOnyksLf8xOR4yHKXMKNiKsSWotC4sSpeb23NQbCgX43VhwnxwPvnUhGhaM9S2Q== X-Received: by 2002:a05:6000:644:b0:3a1:fa6c:4735 with SMTP id ffacd0b85a97d-3a6d12de9f5mr15286806f8f.35.1750779264907; Tue, 24 Jun 2025 08:34:24 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-453755e7d1dsm62924635e9.10.2025.06.24.08.34.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Jun 2025 08:34:24 -0700 (PDT) Message-ID: <2c19a6cf-0b42-477b-a672-ed8c1edd4267@redhat.com> Date: Tue, 24 Jun 2025 17:34:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/4] mm: Support batched unmap for lazyfree large folios during reclamation To: Lance Yang Cc: 21cnbao@gmail.com, akpm@linux-foundation.org, baolin.wang@linux.alibaba.com, chrisl@kernel.org, kasong@tencent.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, lorenzo.stoakes@oracle.com, ryan.roberts@arm.com, v-songbaohua@oppo.com, x86@kernel.org, ying.huang@intel.com, zhengtangquan@oppo.com References: <20250624152654.38145-1-ioworker0@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250624152654.38145-1-ioworker0@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: T5AmtZ7Foid0kYthUaJWmLvenhUYtclieAYARBBVLsI_1750779265 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250624_083430_467847_7CA856A6 X-CRM114-Status: GOOD ( 24.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 24.06.25 17:26, Lance Yang wrote: > On 2025/6/24 20:55, David Hildenbrand wrote: >> On 14.02.25 10:30, Barry Song wrote: >>> From: Barry Song > [...] >>> diff --git a/mm/rmap.c b/mm/rmap.c >>> index 89e51a7a9509..8786704bd466 100644 >>> --- a/mm/rmap.c >>> +++ b/mm/rmap.c >>> @@ -1781,6 +1781,25 @@ void folio_remove_rmap_pud(struct folio *folio, >>> struct page *page, >>> #endif >>> } >>> +/* We support batch unmapping of PTEs for lazyfree large folios */ >>> +static inline bool can_batch_unmap_folio_ptes(unsigned long addr, >>> + struct folio *folio, pte_t *ptep) >>> +{ >>> + const fpb_t fpb_flags = FPB_IGNORE_DIRTY | FPB_IGNORE_SOFT_DIRTY; >>> + int max_nr = folio_nr_pages(folio); >> >> Let's assume we have the first page of a folio mapped at the last page >> table entry in our page table. > > Good point. I'm curious if it is something we've seen in practice ;) I challenge you to write a reproducer :P I assume it might be doable through simple mremap(). > >> >> What prevents folio_pte_batch() from reading outside the page table? > > Assuming such a scenario is possible, to prevent any chance of an > out-of-bounds read, how about this change: > > diff --git a/mm/rmap.c b/mm/rmap.c > index fb63d9256f09..9aeae811a38b 100644 > --- a/mm/rmap.c > +++ b/mm/rmap.c > @@ -1852,6 +1852,25 @@ static inline bool can_batch_unmap_folio_ptes(unsigned long addr, > const fpb_t fpb_flags = FPB_IGNORE_DIRTY | FPB_IGNORE_SOFT_DIRTY; > int max_nr = folio_nr_pages(folio); > pte_t pte = ptep_get(ptep); > + unsigned long end_addr; > + > + /* > + * To batch unmap, the entire folio's PTEs must be contiguous > + * and mapped within the same PTE page table, which corresponds to > + * a single PMD entry. Before calling folio_pte_batch(), which does > + * not perform boundary checks itself, we must verify that the > + * address range covered by the folio does not cross a PMD boundary. > + */ > + end_addr = addr + (max_nr * PAGE_SIZE) - 1; > + > + /* > + * A fast way to check for a PMD boundary cross is to align both > + * the start and end addresses to the PMD boundary and see if they > + * are different. If they are, the range spans across at least two > + * different PMD-managed regions. > + */ > + if ((addr & PMD_MASK) != (end_addr & PMD_MASK)) > + return false; You should not be messing with max_nr = folio_nr_pages(folio) here at all. folio_pte_batch() takes care of that. Also, way too many comments ;) You may only batch within a single VMA and within a single page table. So simply align the addr up to the next PMD, and make sure it does not exceed the vma end. ALIGN and friends can help avoiding excessive comments. -- Cheers, David / dhildenb