From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 62DA0C31D97 for ; Thu, 4 Jul 2024 11:44:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zveAwN34PYsp6aPMx1IsdJe3pfWxmcuJq8MSSftt/mQ=; b=G53gEI5e4fuIBUuwgNLxe/pmjt dqG2EHHjHOwiWwa2qQ041XmUcjH1qxCgAjN+BlUVIpd+coYwdsilgl36hg5MHQ+Ct5aBPt662X+gJ 088Txjqkk12HgxtalQ1kMiwFjQees/P2b9QGwHn7KtkOXXbD2JSuLGJjgYpzW70oqM9px/th5+FGJ qhqGfqJRLsHxtdU719TTgmUxbZ6+ldP9b4/Rb3I2nXCzgLNAVj4Sro6D1X7G536bv/EknijwyYy7U EZ06AIxN8e9XQzexTaNri+wWSs3dzaYiinkP0OQjH+8jNXnhy0Jqgqw7d3Q6zXoXvbqfeiYnVNkRL LBjzRtug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sPKse-0000000D3Xo-2GII; Thu, 04 Jul 2024 11:44:04 +0000 Received: from mail-ed1-x530.google.com ([2a00:1450:4864:20::530]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sPKsQ-0000000D3Uv-1zUe; Thu, 04 Jul 2024 11:43:51 +0000 Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-58bac81f3f9so746045a12.2; Thu, 04 Jul 2024 04:43:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720093429; x=1720698229; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zveAwN34PYsp6aPMx1IsdJe3pfWxmcuJq8MSSftt/mQ=; b=IzmXNRZA3NiULCA66hnN3Jbp1Bh3QBUF/7hEzBN9Zj1jaKr3rWlXAt1gMNiVyyGo/b M66UTWVO+OFiIo/g9kJcq+sqd5q6xZCjkbmK85D5G6kBaKQz1c1sq8Db8FdIt6XaJhWU Ip//RGW3fBc5tqkZsWHOEfkRxfwqLayDKhxOyU3SUzZYLyLky/dLLJsJ0wEyOlWju03y ETUry4uIMnB8mFntVvGv38V23vZcy6zwc3OI6GM7NwcE6IscjxWy8YHJZ2ck42LjvS7v 3VXO9JWMh52aw5N9ydlRvmBtD0poiRFixBK+U5/afW+unr9fXRGdjPX031tjurpyHmJz E81g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720093429; x=1720698229; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zveAwN34PYsp6aPMx1IsdJe3pfWxmcuJq8MSSftt/mQ=; b=ovTpSjWARNwOAaVA2DTC88mSoqj0CftBlrHM5WIgkZv3eAAbDh21QWESa+TANnHXHw Bw4YB1w9ROQcSa7TpcZYuSIJMa4bcfd0PS9I6UGCJcAH81r2FA1eEqFN+nlN6Rfi4/sd NWI+FXLsSa+gUoQE6jol+7ezzvdzF6KuwYYCIcSj69EgdEM74svr2tMvFefRYjYegJEb VcuTsooxO64uxdYDztQpAbCW1LTq4ASqhH/mUTnB3irtB1PNhfBlrWFVMsbB8cCZNisY 3HNX2cIRVyuJaPNSPWtbUVJ/vnqPEQ6dMzeQs/hKNcJx6v7sjXfXU2Ak1JevDJtj5XBM LdQw== X-Forwarded-Encrypted: i=1; AJvYcCWysxGlp05nUSEwK32dZt4wF4zqL9Wf0FiKpP5camDCuwZk18YTvOZhr9GfqFa3k+h6pghdqVOH3tm1zc2swu4An+HFGMWSiJmE3ylVN3u2ppmgv3IC21COp9KrYBA/+vhL9Ac6lBhQZAUWfcv/ZYsJWJsM6ZfcetA= X-Gm-Message-State: AOJu0YzOgrIl1V90HV6LT0V/qEhJR/QHvoSfsMAH9JGq0AMS+3PyKz+D YVS8/kSKfj0KMeqvTs8B8hLjvcyShnVTl02hkZ7O7tbeaILtCXsAMU9c X-Google-Smtp-Source: AGHT+IFCdpf6OuObS+dVAXvcZeJOQuT115EAXlgiAT6ExmVmJY8OSQLXrRwDiCoprKTsl/0fXCoYaQ== X-Received: by 2002:a17:906:f287:b0:a72:415f:cb0e with SMTP id a640c23a62f3a-a77ba72725cmr89878366b.69.1720093428276; Thu, 04 Jul 2024 04:43:48 -0700 (PDT) Received: from ?IPV6:2a02:810b:f40:4600:5f4b:4104:ca7b:6efb? ([2a02:810b:f40:4600:5f4b:4104:ca7b:6efb]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a72ab0652eesm593037466b.131.2024.07.04.04.43.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Jul 2024 04:43:47 -0700 (PDT) Message-ID: <2c46dfb7-5ef3-494f-8cf1-413033e73412@gmail.com> Date: Thu, 4 Jul 2024 13:43:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] arm64: dts: rockchip: add rock5 itx board To: =?UTF-8?Q?Heiko_St=C3=BCbner?= , linux-rockchip@lists.infradead.org, Diederik de Haas Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20240703210524.776455-1-heiko@sntech.de> <20240703210524.776455-3-heiko@sntech.de> <2278169.QnsP76Vvrg@bagend> <4552794.8F6SAcFxjW@diego> Content-Language: en-US From: Alex Bee In-Reply-To: <4552794.8F6SAcFxjW@diego> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240704_044350_536052_E199CD45 X-CRM114-Status: GOOD ( 16.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am 04.07.24 um 12:05 schrieb Heiko Stübner: > Hi Diederik, > > Am Donnerstag, 4. Juli 2024, 11:38:51 CEST schrieb Diederik de Haas: >> Thanks for submitting this. A quick scan indicates it should work with a >> (recent) Debian kernel OOTB :-) >> >> On Wednesday, 3 July 2024 23:05:24 CEST Heiko Stuebner wrote: >>> +&sdhci { >>> + bus-width = <8>; >>> + no-sdio; >>> + no-sd; >>> + non-removable; >>> + max-frequency = <200000000>; >>> + mmc-hs400-1_8v; >>> + mmc-hs400-enhanced-strobe; >>> + mmc-hs200-1_8v; >>> + status = "okay"; >>> +}; >>> + >>> +&sdmmc { >>> + max-frequency = <200000000>; >>> + no-sdio; >>> + no-mmc; >>> + bus-width = <4>; >>> + cap-mmc-highspeed; >>> + cap-sd-highspeed; >>> + disable-wp; >>> + sd-uhs-sdr104; >>> + vmmc-supply = <&vcc_3v3_s3>; >>> + vqmmc-supply = <&vccio_sd_s0>; >>> + pinctrl-names = "default"; >>> + pinctrl-0 = <&sdmmc_bus4 &sdmmc_clk &sdmmc_cmd &sdmmc_det>; >>> + status = "okay"; >>> +}; >>> + >>> +/* M.2 E-KEY */ >>> +&sdio { >>> + broken-cd; >>> + bus-width = <4>; >>> + cap-sdio-irq; >>> + disable-wp; >>> + keep-power-in-suspend; >>> + max-frequency = <150000000>; >>> + mmc-pwrseq = <&sdio_pwrseq>; >>> + no-sd; >>> + no-mmc; >>> + non-removable; >>> + pinctrl-names = "default"; >>> + pinctrl-0 = <&sdiom0_pins>; >>> + sd-uhs-sdr104; >>> + vmmc-supply = <&vcc3v3_ekey>; >>> + status = "okay"; >>> +}; >>> + >>> +&sfc { >>> + pinctrl-names = "default"; >>> + pinctrl-0 = <&fspim2_pins>; >>> + status = "okay"; >> >> Shouldn't those properties be sorted alphabetically? Or at least consistently? >> Note that the same issue is present on other places too, but I believe the >> above quoted part shows the issue enough. > > The main sorting is > - compatible > - reg > [... alphabetically ...] > - status > Yeah ... that's always the question when adding new board files. Do it like "it's always been done" or re-sort the properties alphanumeric _everywhere_ which looks quite strange at times. If I'm getting the newly added dt coding style correctly common (subsystem?) properties should also be placed before vendor (driver?) specific ones. Yet I didn't see a board file which places 'regulator-max-microvolt' before 'regulator-min-microvolt'. So I guess it's fine if it's done consistently within the same file? Alex > But now that I look at it, you're right there are some non-alphabetical > shenanigans going on there in the sdmmc and sdhci nodes ;-) > > Heiko > > > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip