From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66260C56202 for ; Fri, 20 Nov 2020 11:27:10 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EB16322244 for ; Fri, 20 Nov 2020 11:27:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="vPPA7JE/"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="P4zweIOj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EB16322244 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZaWYxfIHdTqX3ePpukkzxNpzmYIjbwdrZJKslNWeQgU=; b=vPPA7JE/dsVB2D/lHBfUzSzHW bLUNrSCdIKPcfiRTZcfvg92hqu8ng+FQjnDWEbRFDSJQK9ZWpQIG3A5Kh7LpmoxikJqwm6LsmqkEJ Gwy+qmdumIa1EqxJakymwK60pHO5mUXE0xHw4pY590c/g33Q21fpevrVDsS6VNSzLZuK9bk75109w g+2ia+8ddKw/UHb83jYrsBQchhLbm/G4w/b3Dv6nwOk2gCG8P2H6KQ1FNR0FS0dRBH3q4ifOBefMs +DpPEyRmTSCQWtfHHNxQcE1ba25l5ChcnSb628Ku9MY2yjKD8oD3kB8mamG6jL8ExsRlmiOb8B3Ut VS9kafzcg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kg4Yu-0000e7-Qr; Fri, 20 Nov 2020 11:26:44 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kg4Yr-0000d1-5z for linux-arm-kernel@lists.infradead.org; Fri, 20 Nov 2020 11:26:41 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D34CC22244; Fri, 20 Nov 2020 11:26:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605871600; bh=e4dU3Fcu0n1ACqjkCBWzLMlbjaNYmEYYOuJTREFTOyk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=P4zweIOjwAsjb1amYtoKtfj/jkRrAFLkoeeYYASL4K06PAfVrCz8EBmM4MaS8UVpG 6ofZjZ+zn163yCRFv6Cz2OShDj1yHal6yxrPgs6uM7NQao6/7mrJWVqWjqVRxnM3yI RzOntXJkFte54eXhHOWu4S2gBp3iTbL9cvXGVUuI= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1kg4Yn-00CEtr-Sh; Fri, 20 Nov 2020 11:26:37 +0000 MIME-Version: 1.0 Date: Fri, 20 Nov 2020 11:26:37 +0000 From: Marc Zyngier To: David Brazdil Subject: Re: [PATCH v2 3/5] KVM: arm64: Patch kimage_voffset instead of loading the EL1 value In-Reply-To: <20201119111454.vrbogriragp7zukk@google.com> References: <20201109175923.445945-1-maz@kernel.org> <20201109175923.445945-4-maz@kernel.org> <20201119111454.vrbogriragp7zukk@google.com> User-Agent: Roundcube Webmail/1.4.9 Message-ID: <2c47608f4326c8251ebd940f8ecb99a9@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: dbrazdil@google.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, alexandru.elisei@arm.com, ascull@google.com, will@kernel.org, qperret@google.com, ndesaulniers@google.com, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201120_062641_337615_0ACC3F20 X-CRM114-Status: GOOD ( 12.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-team@android.com, kvm@vger.kernel.org, Suzuki K Poulose , Will Deacon , Quentin Perret , ndesaulniers@google.com, James Morse , linux-arm-kernel@lists.infradead.org, Alexandru Elisei , kvmarm@lists.cs.columbia.edu, Julien Thierry , Andrew Scull Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020-11-19 11:14, David Brazdil wrote: > Hey Marc, > > Just noticed in kvmarm/queue that the whitespacing in this patch is > off. > >> +.macro kimg_pa reg, tmp >> +alternative_cb kvm_get_kimage_voffset >> + movz \tmp, #0 >> + movk \tmp, #0, lsl #16 >> + movk \tmp, #0, lsl #32 >> + movk \tmp, #0, lsl #48 >> +alternative_cb_end >> + >> + /* reg = __pa(reg) */ >> + sub \reg, \reg, \tmp >> +.endm > This uses spaces instead of tabs. > >> + >> #else > This added empty line actually has a tab in it. Well spotted. Now fixed. Thanks, M. -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel