From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9242C43381 for ; Tue, 2 Apr 2019 03:06:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9FE4C2087C for ; Tue, 2 Apr 2019 03:06:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZP2D/hyl"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="FPrOQi+0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9FE4C2087C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TjiCFfdeIJlrZuDO4do/ej0pnsCm4IsatglnkF7y+Jw=; b=ZP2D/hyl3dcOsqIwJgRcxpekt n546+d5W9cUUEeVDY2ISDgJBHiCSXWL3Bt8FNzvfnJ8LyCPOqKLWn3QZP2pfPe8CY4vVvJvUVcudB 064ueBeh6TpJARc7VyKR80d4/YC0EaaO27LG+M0BkhLG/BUMBIoS3YsBiBaZhEeel4F182IkA7sEW tZzVQnekN6U6WJ6Yvq+VskUHHay2aOGayfwU+0O3oeM95bQqX2nTTLLCrNohWYUlkk1oI/pkqSJnX OlZPHfJTRjMnK+HQjtKcOtG85ZbDxapmeconSVEIsV1DjYZf9BUUbpF1jA/PnhsDA028J2ljnwvXU csw0HwsJg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hB9l5-00045x-R8; Tue, 02 Apr 2019 03:06:43 +0000 Received: from hqemgate16.nvidia.com ([216.228.121.65]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hB9l2-00045Z-B5 for linux-arm-kernel@lists.infradead.org; Tue, 02 Apr 2019 03:06:41 +0000 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Mon, 01 Apr 2019 20:06:38 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Mon, 01 Apr 2019 20:06:40 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Mon, 01 Apr 2019 20:06:40 -0700 Received: from [10.19.108.132] (172.20.13.39) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 2 Apr 2019 03:06:38 +0000 Subject: Re: [PATCH 1/2] arm64: tegra: Add pinmux for PWM-based DFLL support on Shield platform To: Thierry Reding References: <20190322071111.32432-1-josephl@nvidia.com> <20190322095244.GF28640@ulmo> From: Joseph Lo Message-ID: <2c7c9268-0b95-fa49-294b-155a9499741e@nvidia.com> Date: Tue, 2 Apr 2019 11:06:36 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190322095244.GF28640@ulmo> X-Originating-IP: [172.20.13.39] X-ClientProxiedBy: HQMAIL106.nvidia.com (172.18.146.12) To HQMAIL101.nvidia.com (172.20.187.10) Content-Language: en-US DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1554174398; bh=AqeExMbCq/Y8BrbIpq9YPIPVXWGol61VxgZCDluRRd8=; h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=FPrOQi+0dCogZI3rzO8JQqdnbautXWNc/u1RO8PXbMmQEvpSPl0onAiTKgHBurkX4 7VXGE7e6E+E13aG+PqBHcLL2n2QHeM5x0GsJXgMgJvh26ddxSphCACjd1ceCBsN3IM nPu04D6Lgu7tgc+0uxTwWrbWOmLNSuNsQ+a0qYFzzaO6IUvb8RneALMseJH6Mchecc MYYFpW/aucPXujbZpJWOC/VIM6WNDP45GLQOGMwoDM2+C+QKKKCStYQeOC8jzeCINL rLrPxhZJhUI/qnMurnh6UP8PI97JEr8Ar7rik5Z+6fvJE0T3b5pSHZcJcFLEHAJJ4w uZxRHRAx5P2NQ== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190401_200640_390467_8BC21542 X-CRM114-Status: GOOD ( 16.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-tegra@vger.kernel.org, Stephen Warren , linux-arm-kernel@lists.infradead.org, Jonathan Hunter Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/22/19 5:52 PM, Thierry Reding wrote: > On Fri, Mar 22, 2019 at 03:11:10PM +0800, Joseph Lo wrote: >> Add pinmux for PWM-based DFLL support on Shield platform. >> >> Signed-off-by: Joseph Lo >> --- >> arch/arm64/boot/dts/nvidia/tegra210-p2894.dtsi | 14 ++++++++++++++ >> 1 file changed, 14 insertions(+) > > There's been some discussion recently about moving away from programming > pinmux in the kernel because it isn't always safe to do that. The idea > is that early boot firmware (typically cboot) will already have set up > the pinmux, so there's no need to do it again in the kernel. > > These look like you're going to change this pin to/from tristate at > runtime, so perhaps that's the kind of thing that we're okay with? > > Adding Stephen for visibility. Gentle ping. Thanks, Joseph > > Thierry > >> diff --git a/arch/arm64/boot/dts/nvidia/tegra210-p2894.dtsi b/arch/arm64/boot/dts/nvidia/tegra210-p2894.dtsi >> index 88a4b9333d84..c668f16c8574 100644 >> --- a/arch/arm64/boot/dts/nvidia/tegra210-p2894.dtsi >> +++ b/arch/arm64/boot/dts/nvidia/tegra210-p2894.dtsi >> @@ -1318,6 +1318,20 @@ >> nvidia,open-drain = ; >> }; >> }; >> + >> + dvfs_pwm_active_state: dvfs_pwm_active { >> + dvfs_pwm_pbb1 { >> + nvidia,pins = "dvfs_pwm_pbb1"; >> + nvidia,tristate = ; >> + }; >> + }; >> + >> + dvfs_pwm_inactive_state: dvfs_pwm_inactive { >> + dvfs_pwm_pbb1 { >> + nvidia,pins = "dvfs_pwm_pbb1"; >> + nvidia,tristate = ; >> + }; >> + }; >> }; >> >> serial@70006000 { >> -- >> 2.21.0 >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel