From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBE83C4361B for ; Mon, 7 Dec 2020 14:06:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5AD6D23447 for ; Mon, 7 Dec 2020 14:06:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5AD6D23447 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:Date:Message-ID:From:References:To:Subject:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=w2iptCORBqZxdm9i/Egi9mUOVNkYDpR7Yrj/NgoWaDA=; b=nbT6D1mpnLC38fWXr5ZWKdEql JAr3Ue+JajKPm4+FcTga+3+SSKt7EErVFNHZDrSBuane4PB1iXqbZM5ZrJzM8De0/HTQBKJkn6XGo xcBZk7qwXp1wUSgjWT9YdQZPHwlVBIQQb179v9XCY2lLfUDFW/DDOfOcq4VapDZYTxpYQYo4aQaDq 0LtVc2Ws3pfcujTv4vaP8HSCq44+RiB8MesP3llqoh5WGvB4mSrQIUBuu7/a0+oWT0UIQTDnTV5Sp EJnQlwcgoaRd6zkNh6sWbhFZjRad4nPfqLvmmzeG2BdNaZ8/pJCTQOcVakxFjYQuvSn262F73lKAg qxdev1JPA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmH8r-0001Iz-V3; Mon, 07 Dec 2020 14:05:30 +0000 Received: from mx2.suse.de ([195.135.220.15]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmH8o-0001GW-Db; Mon, 07 Dec 2020 14:05:28 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 599BFAC2E; Mon, 7 Dec 2020 14:05:20 +0000 (UTC) Subject: Re: [PATCH v4 3/8] drm/vc4: hdmi: Don't access the connector state in reset if kmalloc fails To: Maxime Ripard , Maarten Lankhorst , Daniel Vetter , David Airlie , Eric Anholt References: <20201207133948.2109194-1-maxime@cerno.tech> <20201207133948.2109194-4-maxime@cerno.tech> From: Thomas Zimmermann Message-ID: <2c7cdcfc-7bc0-e941-034f-10b298ca9c14@suse.de> Date: Mon, 7 Dec 2020 15:05:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20201207133948.2109194-4-maxime@cerno.tech> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201207_090526_695214_D6936B5C X-CRM114-Status: GOOD ( 23.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, Dave Stevenson Content-Type: multipart/mixed; boundary="===============8015053218767224045==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============8015053218767224045== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="FjQhJwyrpKOXIxGu0t1c4cSr2Xhly1RCd" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --FjQhJwyrpKOXIxGu0t1c4cSr2Xhly1RCd Content-Type: multipart/mixed; boundary="fIf0OgOcZ01huTWoQQ9Z2HsWV86X6S2fY"; protected-headers="v1" From: Thomas Zimmermann To: Maxime Ripard , Maarten Lankhorst , Daniel Vetter , David Airlie , Eric Anholt Cc: bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, Dave Stevenson Message-ID: <2c7cdcfc-7bc0-e941-034f-10b298ca9c14@suse.de> Subject: Re: [PATCH v4 3/8] drm/vc4: hdmi: Don't access the connector state in reset if kmalloc fails References: <20201207133948.2109194-1-maxime@cerno.tech> <20201207133948.2109194-4-maxime@cerno.tech> In-Reply-To: <20201207133948.2109194-4-maxime@cerno.tech> --fIf0OgOcZ01huTWoQQ9Z2HsWV86X6S2fY Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Am 07.12.20 um 14:39 schrieb Maxime Ripard: > drm_atomic_helper_connector_reset uses kmalloc which, from an API > standpoint, can fail, and thus setting connector->state to NULL. > However, our reset hook then calls drm_atomic_helper_connector_tv_reset= > that will access connector->state without checking if it's a valid > pointer or not. >=20 > Make sure we don't end up accessing a NULL pointer. >=20 > Suggested-by: Dave Stevenson > Signed-off-by: Maxime Ripard Acked-by: Thomas Zimmermann > --- > drivers/gpu/drm/vc4/vc4_hdmi.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_h= dmi.c > index 5a608ed1d75e..112c09873eb4 100644 > --- a/drivers/gpu/drm/vc4/vc4_hdmi.c > +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c > @@ -171,7 +171,9 @@ static int vc4_hdmi_connector_get_modes(struct drm_= connector *connector) > static void vc4_hdmi_connector_reset(struct drm_connector *connector)= > { > drm_atomic_helper_connector_reset(connector); > - drm_atomic_helper_connector_tv_reset(connector); > + > + if (connector->state) > + drm_atomic_helper_connector_tv_reset(connector); > } > =20 > static const struct drm_connector_funcs vc4_hdmi_connector_funcs =3D = { >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany (HRB 36809, AG N=C3=BCrnberg) Gesch=C3=A4ftsf=C3=BChrer: Felix Imend=C3=B6rffer --fIf0OgOcZ01huTWoQQ9Z2HsWV86X6S2fY-- --FjQhJwyrpKOXIxGu0t1c4cSr2Xhly1RCd Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsF5BAABCAAjFiEExndm/fpuMUdwYFFolh/E3EQov+AFAl/ONp4FAwAAAAAACgkQlh/E3EQov+Cc BQ/6A9EpfbOs6SugtiBkYhem9kVa9mx1/Xarlrv7ARyfv1VKYKT63SDRDjKOuspoFhGEqaw3QeVQ t9tgGn/4bLKEeNyri1CKcIv0Zf6q3WBZtvQltAqIobGFqAkkrChJUWseK9ufyFsEOpIZYJo595t6 cHKfoM8reOCpj1lwwOdHnVsUwQ0IpLs2ySax7yA1yO/0JEANtkSVFsxBmGVuoLgrzJPK7jd2kr3t jSJiVXCCTcf9A4esc6VPYyCXWF/tlhd0uoVgZYWTvUeRyPfwpECF63zFBxE4tUQZMf0IIJ8qzg0E znJgi/bU9zUslmuAoDDe3E4ABPLiYElfqtwYnGwUjdtZV1LFX52Pv7Z0hakBstgrkUaDt3PqVchx H4pqH7Dcbc98AvXP+y26L3BmLg5ABUY/ZOhOWFdp8Ta/PYOJRp+ZNpw8tcg/2ZzYPSGOx2+C0Tn7 WV+izF0Agiiah33oyDjtDVRuwvICyYgle9CHppBXRNVa3J3ThuJT6Swb00wTu5A2u9JdmKEzIC1U Pw3mfQR4bVIo3Xw/2OOcLz+smB2JNEQahleU9qB7/vmc7EarIecT+iVB1F9N/0YNYRxnwZXplHHW CCM6YvIk/K1/by1r98ORHMLaKm40d6ObrxhBlxc3y78dJNCvxHXZiFZqShKOf58s5ZE55xwMjzfb R50= =Z0RS -----END PGP SIGNATURE----- --FjQhJwyrpKOXIxGu0t1c4cSr2Xhly1RCd-- --===============8015053218767224045== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============8015053218767224045==--