From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Aakarsh Jain <aakarsh.jain@samsung.com>,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Cc: m.szyprowski@samsung.com, andrzej.hajda@intel.com,
mchehab@kernel.org, hverkuil-cisco@xs4all.nl,
ezequiel@vanguardiasur.com.ar, jernej.skrabec@gmail.com,
benjamin.gaignard@collabora.com,
krzysztof.kozlowski+dt@linaro.org, stanimir.varbanov@linaro.org,
dillon.minfei@gmail.com, david.plowman@raspberrypi.com,
mark.rutland@arm.com, robh+dt@kernel.org, krzk+dt@kernel.org,
andi@etezian.org, alim.akhtar@samsung.com,
aswani.reddy@samsung.com, pankaj.dubey@samsung.com
Subject: Re: [Patch v5] dt-bindings: media: s5p-mfc: convert bindings to json-schema
Date: Tue, 28 Feb 2023 11:23:35 +0100 [thread overview]
Message-ID: <2c8c3e57-16b4-43cc-941a-61f251bfe1f9@linaro.org> (raw)
In-Reply-To: <021c01d94aa0$03714d00$0a53e700$@samsung.com>
On 27/02/2023 12:38, Aakarsh Jain wrote:
>>> + - samsung,mfc-v5 # Exynos4
>>> + - samsung,mfc-v6 # Exynos5
>>> + - items:
>>> + - enum:
>>> + - samsung,exynos3250-mfc # Exynos3250
>>> + - const: samsung,mfc-v7 # Fall back for Exynos3250
>>> + - enum:
>>> + - samsung,mfc-v7 # Exynos5420
>>> + - samsung,mfc-v8 # Exynos5800
>>> + - samsung,exynos5433-mfc # Exynos5433
>>> + - samsung,mfc-v10 # Exynos7880
>>
>> Why this and first enum are separate? I didn't notice it before...
>> Usually we have only one enum for one-compatible variants. Also, sort them
>> by compatible.
>>
> okay.
> I will keep it in this way
> properties:
> compatible:
> oneOf:
> - const: samsung,mfc-v5 # Exynos4
> - const: samsung,mfc-v6 # Exynos5
> - const: samsung,mfc-v7 # Exynos5420
> - const: samsung,mfc-v8 # Exynos5800
> - const: samsung,exynos5433-mfc # Exynos5433
> - const: samsung,mfc-v10 # Exynos7880
These should still be an enum (and sorted by compatible).
> - items:
> - const: samsung,exynos3250-mfc # Exynos3250
> - const: samsung,mfc-v7 # Fall back for Exynos3250
>
> Will this be fine?
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-02-28 10:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230227084748epcas5p2602a39017d3366bdfb5af95088ed89dc@epcas5p2.samsung.com>
2023-02-27 8:47 ` [Patch v5] dt-bindings: media: s5p-mfc: convert bindings to json-schema Aakarsh Jain
2023-02-27 9:51 ` Krzysztof Kozlowski
2023-02-27 11:38 ` Aakarsh Jain
2023-02-28 10:23 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c8c3e57-16b4-43cc-941a-61f251bfe1f9@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=aakarsh.jain@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=andi@etezian.org \
--cc=andrzej.hajda@intel.com \
--cc=aswani.reddy@samsung.com \
--cc=benjamin.gaignard@collabora.com \
--cc=david.plowman@raspberrypi.com \
--cc=devicetree@vger.kernel.org \
--cc=dillon.minfei@gmail.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jernej.skrabec@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=pankaj.dubey@samsung.com \
--cc=robh+dt@kernel.org \
--cc=stanimir.varbanov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).