From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 56950C433EF for ; Sun, 12 Dec 2021 15:44:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UqOacW1ZdPJMRJKRFH1IjX6i+6G/qVFtGddTJDvml48=; b=zmrIWyIibnGXyD w1x/5INNfrJ2pXe25jIWiwKJ71LcdVmhOUXI4Ncz+jyQtlCq5R6ZJaXIJvtzxX7XlteEPSjh78bzg S++7XiUrw5XFDzz5JMn5CvqnMqDQz6LKbAb9kqj5K0kR+gNdmrh1ZJ2aJKy3i3cNkM+clq2kJTqe6 P72eytXctBpkRI9MKGkwUHVoG6cQNU7G+qkY7nx9e4fUt2WuJg6iwES9I5kKs8Yo0dNMPKJMe6KOl i8XN24Mp20OBueazuSpNnDq/HQFW5vPva02iT3y/v8KxRgs2SX5ulO/XF1Da5NSeR8W1ODgOgAmCc 0wq9EofE6UfqpMI9WkZQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mwR0U-006lAh-KL; Sun, 12 Dec 2021 15:43:22 +0000 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mwR0Q-006lAB-Vh for linux-arm-kernel@lists.infradead.org; Sun, 12 Dec 2021 15:43:20 +0000 Received: by mail-wr1-x434.google.com with SMTP id u17so23148739wrt.3 for ; Sun, 12 Dec 2021 07:43:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=0841pN07OCCfFVYZZp2FufJ38IE8tqmE6kyIxF84N5o=; b=eeP3k3YR03C/HwJ8Rstj2pEjV5P6lNqKZi25QFXL3RugnUob1xsCRo0EBGotr73zNX TwncsGkmU9N6hUDfH3lcZ3urYRCUmDnPlLm2UVabQlpyH98VIKMnN2l0omIilLYWfycP OxWVFETqYMhaumL3pFR2GDrW3rVWWqxeitYjALecLYRrJBvR8WWyojsUNcnPGJwQhgH7 UC08XNdF8qieOHhCjGU2k/t7Hwt1vwflVqsWnY6dhJzxr9je58JsUpgGjnj+qkWoz2zX /nneHhlO8iVjHEuA/ruHF2ochOs1wcoyhO75S90o6gvqDQTRCdU6cPY0UDrT/HXDyeLq hmBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=0841pN07OCCfFVYZZp2FufJ38IE8tqmE6kyIxF84N5o=; b=FiQoq6JgKkowIpA93Wa81YoB7dhET4Xrrv0lGLxdNv+AeB76ebFPET6ak7YpOj5htp X2xg0F9XOp18TIsy07xTkNg6rD4BiwsRIA2NMUrFNdrrGwhaPNhZEGCdvpuiIWJDC3N8 b8/296nbHSN4h+FOkesVrWhZfezg2cXLEmcZqEMkf9DjVmZ+0e0FLF4tMQKjcZab5SGY mi/W59oKqiRB99pZBqIj3hiAI4e6Ta1cKkHP+z/unkpL/LdgC9A35l0JIDC7sWvPz8ej KwytEqdAqcbM7Zi71d0a4eVJmVdds4kF8ZbSO34RSuhEbvpEyfYJqq2WGJJcv79t4N05 P1JQ== X-Gm-Message-State: AOAM5327X40U3mKn9DA8LnK5fm+W86o2jZmuUgBlTEdz8Rllt+Otjl8a 5TaSiCRTTmw1cMcnJW2UUhkGoA== X-Google-Smtp-Source: ABdhPJw2aM7YcfieUTyC7DHO4kPlGaxhvnnzDG53nDuIgfBWjKwHfQto6D9pDqpCD9LCGdyOGdgd1A== X-Received: by 2002:a5d:6481:: with SMTP id o1mr11766456wri.632.1639323797130; Sun, 12 Dec 2021 07:43:17 -0800 (PST) Received: from [192.168.0.162] (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id e24sm8187073wra.78.2021.12.12.07.43.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Dec 2021 07:43:16 -0800 (PST) Message-ID: <2ca3a953-61a5-68d0-c6ea-c4a1c41fc05b@linaro.org> Date: Sun, 12 Dec 2021 15:45:22 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.1 Subject: Re: [PATCH] arm64: dts: qcom: ipq6018: Fix gpio-ranges property Content-Language: en-US To: Baruch Siach , Andy Gross , Bjorn Andersson Cc: linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Florian Fainelli , Sricharan R References: <8a744cfd96aff5754bfdcf7298d208ddca5b319a.1638862030.git.baruch@tkos.co.il> From: Bryan O'Donoghue In-Reply-To: <8a744cfd96aff5754bfdcf7298d208ddca5b319a.1638862030.git.baruch@tkos.co.il> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211212_074319_098874_507D4792 X-CRM114-Status: GOOD ( 18.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 07/12/2021 07:27, Baruch Siach wrote: > There must be three parameters in gpio-ranges property. Fixes this not > very helpful error message: > > OF: /soc/pinctrl@1000000: (null) = 3 found 3 > > Fixes: 1e8277854b49 ("arm64: dts: Add ipq6018 SoC and CP01 board support") > Cc: Sricharan R > Signed-off-by: Baruch Siach > --- > > The error message was improved in commit af3be70a321 ("of: Improve > of_phandle_iterator_next() error message"), but there is evidently some > more room for improvement. As I don't really understand the code, I > added the commit author and the DT list to Cc. > --- > arch/arm64/boot/dts/qcom/ipq6018.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi > index 6a22bb5f42f4..a717fc17523d 100644 > --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi > +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi > @@ -220,7 +220,7 @@ tlmm: pinctrl@1000000 { > interrupts = ; > gpio-controller; > #gpio-cells = <2>; > - gpio-ranges = <&tlmm 0 80>; > + gpio-ranges = <&tlmm 0 0 80>; > interrupt-controller; > #interrupt-cells = <2>; > > Works for me Tested-by: Bryan O'Donoghue _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel