From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FE58C43467 for ; Thu, 8 Oct 2020 10:00:27 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F0CCB2083B for ; Thu, 8 Oct 2020 10:00:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Oc6YR2Fl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F0CCB2083B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BCWslrSaVkiLKOPMSM7CeunQQTvRzeNdgvMy/Y+KxWw=; b=Oc6YR2FlRNwCYRzgZ0llW39Uv EdgC7AESV0pK2WUAWjTFIxqMwofbOECxttD0b4fSBBabzXu8qAjUQCsjg2UB3VEtGxfQDX6Q5DTR3 V8CjO4RoOu+HvLGhGkavVXvJ+dKucwV70WXKwNm9JDkGC0Y933iK5mc7Ny4VIBjsKxT3AP7GRnHce T8QAkaPiZkfi2e7sCzv+IVNfLL50idRCpSm8qqYZVkbfzxvgvUU6/OVu2ghcCwuLvI1CgTIlDTq0W 4foavIMk8jOTpldLiKyyH95uJlA+0optZzGmsJx7y5tmwnvty8NEYG98WJZhZn4XgCEd2rArZc5mv SxCR0iJgg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQShO-0005Y6-EH; Thu, 08 Oct 2020 09:58:58 +0000 Received: from mx2.suse.de ([195.135.220.15]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQShM-0005XI-6G; Thu, 08 Oct 2020 09:58:57 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C5E1DAC82; Thu, 8 Oct 2020 09:58:52 +0000 (UTC) Message-ID: <2caab0c666fe3ccf5e3247a1f1a78fd8f55a36b8.camel@suse.de> Subject: Re: [PATCH v1] PCI: brcmstb: fix error return paths in probe() From: Nicolas Saenz Julienne To: Jim Quinlan , Dan Carpenter , Lorenzo Pieralisi , bcm-kernel-feedback-list@broadcom.com Date: Thu, 08 Oct 2020 11:58:51 +0200 In-Reply-To: <20201001151821.27575-1-james.quinlan@broadcom.com> References: <20201001151821.27575-1-james.quinlan@broadcom.com> User-Agent: Evolution 3.36.5 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201008_055856_333488_E7F0BC68 X-CRM114-Status: GOOD ( 13.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Florian Fainelli , "open list:PCI NATIVE HOST BRIDGE AND ENDPOINT DRIVERS" , open list , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , Bjorn Helgaas , Jim Quinlan , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 2020-10-01 at 11:18 -0400, Jim Quinlan wrote: > Fixes two cases where we were returning without calling > clk_disable_unprepare(). Although there is a common place to go on probe() > errors (the 'fail' label), one can only jump there after executing > brcm_pcie_setup(), so we have to add clk_disable_unprepare() calls to the > two error paths. > > Fixes: b98f52bc6495 ("PCI: brcmstb: Add control of rescal reset") > Reported-by: kernel test robot > Reported-by: Dan Carpenter > Signed-off-by: Jim Quinlan > --- Reviewed-by: Nicolas Saenz Julienne Thanks! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel