From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C2F4EB8FAD for ; Wed, 6 Sep 2023 09:35:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=s42dCfBOJBcrQvAFr3w4pzMb8t7SPEpq79n5pvSmwMA=; b=XgWeLXAcaBuGvm q7l6WHlUYDR7ZRp/0X0B/uHi10bau8uWM2bYBcFfIt+2JISAkVgqYu5/PCIYhVYrC1G6Cf61mF8DL gKU1lIPB2czw7Hd8DzAAtNOS2Tp+BfbCsLM0j49vS59DbEa+BzgZzZi5jssVmY9v5gfsx6VsPuBGg +ezJVis3PJ+ADN1Q0p+xmwTjl1DiRAAcBz4h8epfmlJ2eJplQ7xdFTA6xU2pdVauOGZtwfH4VeBnU dnJLAav4lpQ6XkA1rTDmjUVI2dYMOD18OV+PV9pqx9s82BOENblwkFEUhs8pBmlqaleuh6QHNPWCT Kj90X4LOMWIf4GRRqCOw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qdovf-007wXN-1V; Wed, 06 Sep 2023 09:34:31 +0000 Received: from mail-ed1-x530.google.com ([2a00:1450:4864:20::530]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qdovb-007wV7-2w for linux-arm-kernel@lists.infradead.org; Wed, 06 Sep 2023 09:34:29 +0000 Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-52c88a03f99so4593153a12.2 for ; Wed, 06 Sep 2023 02:34:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693992864; x=1694597664; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FFD2tKig988p+nyLWDkmgUfiyTgw/5tkGCahsn8FoGo=; b=BtY68YbYKlVtN5KG7Ml9yzfyvGvq2QQ50YziZ49xhuOgDpPjBDWovj4EsUcVUQF+5k qM1r/hzUiAAabmCgb0i+rjxtYmZ/7wcgS0WAulW3jjLOZgNwhkJZ0xn5n4h4O9uiND/g hET9+XOcoJQKtGsfNTFu7monxV6A9DgDz6P+R4UKJ4XT1CpA6N9xqa4e8Zy9bmBurnp+ ck/8t5XghSrIuahEGBIlG6VkYaEOmgyMXaM5WDoekEIyeSlkXJj9FgQxnmdgrfYTlQnM BqxY2PO3pO+5Ip4DVNF4NA9k1c5inpkDCzNeXOsu5vQEzn51fuN3bPkZL5roS0PHEKzY nXTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693992864; x=1694597664; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FFD2tKig988p+nyLWDkmgUfiyTgw/5tkGCahsn8FoGo=; b=ZbFfTAzUEJ7MPTtkxygeAEyfMbU83+uvsSw4cAmjI83d5mvl6pazfMUVHW269rocOz IBLxjDxFkZzfXOftTqCKKuJy5AL/d3tRB/4rcRczHi9ZDVGHDpwyg3NRpBd0FCpE41PP dT4fe8utNl+oHRa9OYF+HdgqLwLz9hxgOrbqm0Y3uGo0AFEnCBtXvvf/cUwnXyADwdux u7COtMP7v2ZEF2o696L5D82WJuWPP2BF2UvcWH0eUY1JDDbs56h1LIe33GGTQbyTaSaN 8yTR/LHfLRhi4qVYax2bYMTVsFCvQFINcITTocLpvQXw/RfhvgirZ45VSt4JggD6jCaL bQIw== X-Gm-Message-State: AOJu0Yy3kWAmWmO4a5fJC/+yKzFk9JFvYBsBslFAgAI83ooJ5Rr1gHjP 8p60XYTC7dU4gcNsv24Bq3ruHg== X-Google-Smtp-Source: AGHT+IH6q0YbahWp/ZkV/kLa2NyEia2qzHpTs1IMS+0oSP9G5r5jyvzt5JtP17ezqw/WAp681nsONw== X-Received: by 2002:a17:906:3017:b0:9a1:e1cf:6c6c with SMTP id 23-20020a170906301700b009a1e1cf6c6cmr1874832ejz.30.1693992864037; Wed, 06 Sep 2023 02:34:24 -0700 (PDT) Received: from [192.168.0.22] (77-252-46-238.static.ip.netia.com.pl. [77.252.46.238]) by smtp.gmail.com with ESMTPSA id a6-20020a170906244600b0099cce6f7d50sm8872914ejb.64.2023.09.06.02.34.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Sep 2023 02:34:23 -0700 (PDT) Message-ID: <2cb8069a-976b-0af4-a427-1e63ba4e7870@linaro.org> Date: Wed, 6 Sep 2023 11:34:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH v2 2/2] arm64: dts: mediatek: add device-tree for Genio 1200 EVK board Content-Language: en-US To: Macpaul Lin , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Frank Wunderlich , =?UTF-8?Q?Bernhard_Rosenkr=c3=a4nzer?= , Sean Wang , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Cc: Bear Wang , Pablo Sun , Macpaul Lin , Ben Lok References: <20230904092043.5157-1-macpaul.lin@mediatek.com> <20230906092527.18281-1-macpaul.lin@mediatek.com> <20230906092527.18281-2-macpaul.lin@mediatek.com> From: Krzysztof Kozlowski In-Reply-To: <20230906092527.18281-2-macpaul.lin@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230906_023427_949163_2C509A2B X-CRM114-Status: GOOD ( 11.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 06/09/2023 11:25, Macpaul Lin wrote: > + edp_panel_fixed_12v: regulator-1 { > + compatible = "regulator-fixed"; > + regulator-name = "edp_backlight_12v"; > + regulator-min-microvolt = <12000000>; > + regulator-max-microvolt = <12000000>; > + enable-active-high; > + gpio = <&pio 96 GPIO_ACTIVE_HIGH>; > + pinctrl-names = "default"; > + pinctrl-0 = <&edp_panel_12v_en_pins>; > + }; > + > + backlight_lcd0: backlight-lcd0 { > + compatible = "pwm-backlight"; > + pwms = <&disp_pwm0 0 500000>; > + enable-gpios = <&pio 47 GPIO_ACTIVE_HIGH>; > + brightness-levels = <0 1023>; > + num-interpolated-steps = <1023>; > + default-brightness-level = <576>; > + }; > + > + backlight_lcd1: backlight-lcd1 { > + compatible = "pwm-backlight"; > + pwms = <&disp_pwm1 0 500000>; > + enable-gpios = <&pio 46 GPIO_ACTIVE_HIGH>; > + brightness-levels = <0 1023>; > + num-interpolated-steps = <1023>; > + default-brightness-level = <576>; > + }; > + > + keys: gpio-keys { > + compatible = "gpio-keys"; > + > + button-volume-up { > + wakeup-source; > + debounce-interval = <100>; > + gpios = <&pio 106 GPIO_ACTIVE_LOW>; > + label = "volume_up"; > + linux,code = ; > + }; > + }; > + > + can_clk: can-clk { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <20000000>; > + clock-output-names = "can-clk"; > + }; > + > + wifi_3v3: wifi-3v3-regulator { This is a friendly reminder during the review process. It seems my previous comments were not fully addressed. Maybe my feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them. Thank you. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel