From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9A637C47077 for ; Tue, 16 Jan 2024 13:30:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iQwjEYfE4iTEO2UT1kgjLPdGG4nsWzT1k6/eP7/Hjmo=; b=ASOZJQo17FM5Yc PXVGIxraUcQfeMhKTyIAclvNOtzbKkP59dvvgao7q7V5592zX3BjtqDT+LNZtJEC6LNj/LRdZzIPB G5SEgfoKBmR0rlA2ZbuicueUYqnpgUM/kMfNxa/hLpjjins2tsiFSmK4kEo/+RFSeRbc/ZREwQzXk FbYIL3vBebyxZlll9JtD7fOqezo/cXi9KOxtb27vv2Q/VLBTtrMPwF8SkhPcgAWEjRjB688dCJTIe 2kIFeMVKLvlIVQ6FBwDIaTi6+g8d/mulNLliVfkr+NrtKV92ppHZhcOh2SzwLttj2JsSZ9od10yOy YtLL/DIEeiKMDjcLOumA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rPjVt-00CBAR-05; Tue, 16 Jan 2024 13:29:57 +0000 Received: from mail-ve1eur01on0600.outbound.protection.outlook.com ([2a01:111:f400:fe1f::600] helo=EUR01-VE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rPjVq-00CB9d-1E for linux-arm-kernel@lists.infradead.org; Tue, 16 Jan 2024 13:29:55 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V4eAf8Xed8knpB2Pbwn6hwxOHY3U+51TdP9dLZkQuZsn8kPmwZ7MyqU3u7Uz907DoWLuDrcVAtCOLPvTzI9Sz58V5Mesk/s3zeQtF9HrM6PrEqkiXB8SDoe25oAiYFgF6VWwHwnKkM2qpi7fwW22pQIQoFGFDi3/UWPT2znDTUDeb6JBjAOMQ4qAKxLCBcQzSott78lbmshf4PAWxOliyVAlVadpXBPjBFlSwQKP5E1OZ7kUlaaZnCwErR1VJ/glqp5qCILGmMpY+b99rP9uF3gRnDXCyKXIHUWWg4IYXttm2IcmEdN1jYDZ0eZ0Pffn+cyBpUy0haP8IItYRmipuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jkg5eFLHLfAjFNzUumo2SMlsohxBdmtdvqANKe8Z8G8=; b=b06jfDuL3+WECvVHjTVk34NzsK1RpHBPD7YSRpTDdhD4/xra85ZccF4ywtvY2w30eMYf3XwB9fThg5Da3xmYL6M8qnHMa3TTx0Qbm6SrwJwV5jTNXqfV0NQJEX8CoACh5AbuB7uY0fAxtlHQPdGaYqWX0MF5qVyzI+rYenBV44ZQZ4Al0Xnl7cErXTlB26OdANSQQK0AD9CRrnNCv4B0dH9hOTrqiK18lI512snM9TJzeiLZG71DBuHWprEZA3EVYWiF3zxak9urMjywCtukGwtS1nLp+bNm0s0n5W2ATy5JKSTzQDsMtq+9eD9SjJCyx+wxTOvqF9QPWEcTyNKu/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=solid-run.com; dmarc=pass action=none header.from=solid-run.com; dkim=pass header.d=solid-run.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=solidrn.onmicrosoft.com; s=selector1-solidrn-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jkg5eFLHLfAjFNzUumo2SMlsohxBdmtdvqANKe8Z8G8=; b=PDWeMjNM2b3WxJodOqOtBlYQJ5zPLM8Yms1XXW3eWQxUZJ/gOozbws8S9pOt5nzBJ5QpdOnmzwDZT2Kn7KMb0weuuXilYBKkVCfaIDpVYprju3BtscQHCBlIQadIHM91oisOs/2mgfJOpUYU7sr+H5h0JPmJgf4qBhx28qZxxwg= Received: from AS8PR04MB8963.eurprd04.prod.outlook.com (2603:10a6:20b:42e::18) by AM9PR04MB8241.eurprd04.prod.outlook.com (2603:10a6:20b:3e4::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7181.28; Tue, 16 Jan 2024 13:29:45 +0000 Received: from AS8PR04MB8963.eurprd04.prod.outlook.com ([fe80::daf2:8c54:d469:793d]) by AS8PR04MB8963.eurprd04.prod.outlook.com ([fe80::daf2:8c54:d469:793d%7]) with mapi id 15.20.7181.027; Tue, 16 Jan 2024 13:29:45 +0000 From: Josua Mayer To: Krzysztof Kozlowski , Nishanth Menon , Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alessandro Zummo , Alexandre Belloni CC: Yazan Shhady , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-rtc@vger.kernel.org" Subject: Re: [PATCH v2 4/5] arm64: dts: add description for solidrun am642 som and evaluation board Thread-Topic: [PATCH v2 4/5] arm64: dts: add description for solidrun am642 som and evaluation board Thread-Index: AQHaRXqNRxBDBTIBFEOB99P14tzvurDWbMUAgALwy4CAASCFAIAAK9IAgAAEN4CAAANTgIABw72A Date: Tue, 16 Jan 2024 13:29:45 +0000 Message-ID: <2cd24d3d-40a2-435e-bf60-bf6af24128b8@solid-run.com> References: <20240112-add-am64-som-v2-0-1385246c428c@solid-run.com> <20240112-add-am64-som-v2-4-1385246c428c@solid-run.com> <60d78882-0ec5-4cd1-b68d-f75b73cb6cdb@linaro.org> <1656bf68-c3b4-476d-984e-f231541058f6@solid-run.com> <0b03af70-7dc4-4a4f-b9dc-218ef365c237@linaro.org> <2879689e-5a4e-4242-a23b-d2aa9f004b1d@solid-run.com> <5e0e6a28-58bb-4f28-aee7-28b05efe14b3@solid-run.com> In-Reply-To: <5e0e6a28-58bb-4f28-aee7-28b05efe14b3@solid-run.com> Accept-Language: de-DE, en-US Content-Language: de-DE X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=solid-run.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AS8PR04MB8963:EE_|AM9PR04MB8241:EE_ x-ms-office365-filtering-correlation-id: cf651152-b361-4ca3-c73f-08dc16973451 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9Qf43rCVWygFfV88Yp21hSc1yBJpA0WkqmEeLB2QDLzHzpMz6lmrf/G8NJg7jyOSMx1+Q+7MfrGx804cOMrXUcfpbM/IK8cpM6ZbRMI8DQFCBFsbiibcLkbDmtnv8ViF9+XbcygbuD6F55ZzobuaNyJFnT89Wk0A8ilr804FkxireYsx3nuYj+CmZgxWuuJpl90DE00vuGyXTGRvCDMNQwzeL4//TdOD1jRV74W3poluo6CXId5rMwK5l6//QPiG7+rFzSP7SSxN8nI/t3ueikDAOPz2QY0N8uuOvZHTx2VMaGd/3kBBvJwq20EieErHvRbXiSY8jkhqm5dN+tWD5PIfcAAg+M24cp64RkPzytz74j4iRvSBLZxYrBYBpGAc4abLszKd9Mf1E0PdhKONXLJxaw1BrLPADp2qhg66GHs7vQHKxmTqdz5Z0WHcM2Dk+3YNL2D39mjBnjqXymqx0CO0197wvEJA65KYjkYvxz1rjaGONcf/81TwTTyj3y7Ys76KJX7QLIzefIuQEHcqhiLlCXcwCFY/vkI0fVv17YilJ8C8UFmQrX2JRRNUDk7nZYCB77D8ZJMIXzw6vPxZK2P0rFJ4Yo4bkutV7Xly8Ei4l2Z4iLc089J0WYS1CdDK01WQ8czok/1G+GMSDBRLuQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8963.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(396003)(346002)(366004)(136003)(376002)(39840400004)(230922051799003)(186009)(1800799012)(64100799003)(451199024)(38100700002)(122000001)(38070700009)(86362001)(31696002)(6486002)(91956017)(36756003)(316002)(66946007)(76116006)(66556008)(66476007)(66446008)(64756008)(54906003)(110136005)(478600001)(6512007)(53546011)(71200400001)(6506007)(2906002)(5660300002)(7416002)(8936002)(8676002)(31686004)(4326008)(41300700001)(2616005)(26005)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ZmZEakk2alBYSjlxcDVscXJLQzZaZ2htK1p2STNiOE1wWk5yVTlwdnluVWdR?= =?utf-8?B?TGpleVRyQ1ZxdkRVdC9vSlNkWnIvVWhEV00zd1R0RjI3bWxiK0R3cFV2ajdt?= =?utf-8?B?ZWp6WEtYOUZacEtRTEFoc2k2SDBWaEMyZ095bkFYM25vVHlHeFNQWW9XdjJF?= =?utf-8?B?T1FTQW5zV2R2OVlCckRsdjNadGo0azFSM3ZUc1JoakpnaEwrakdJeHlEbkE4?= =?utf-8?B?V09FcVhPNWRXdGpOcnEraXNoQ0lKLzYvV2N4Vit5Z3hmdnBMT1pMMmtiZ3c5?= =?utf-8?B?a01MNGllaWZpMU40ZU5qMkRtOVBSN1l0WEJEb0RYaXdTeTlGK1dMQ0xJdGFG?= =?utf-8?B?UTZES1BZTVdJd0dNZjE1QzZwYlVOUUF0QjJlRSt6SFFhckFoWk44ckZPZVRS?= =?utf-8?B?RU40NUw3NUU0ZVY5RFgvdFVJUXNXVk45TU4vNHI4ZnlDTG40VnhIZCtjczdq?= =?utf-8?B?VGFSZll6blJOdkdJUXlmblVVTXJyaUpnREJTdUxUbnZoNXRISzVDV1NxMVNi?= =?utf-8?B?M0VHcDVZRHo0T01Uc2NqVEkydXkwWitqOEFwS2U0ODV3KzhReFAwZVhXRmpm?= =?utf-8?B?R1FqdWxTTEdzc1krTUtvOE9TT3lKcDZkTVpSSWNqQTNtdnFJNmFtYVhySTF6?= =?utf-8?B?SlBSRWljMjRxUExNbUl3U25BNnA3QnBtTWZhRWFFZmFlRUhxTEdIMzJWKzY4?= =?utf-8?B?NzF0dEVnT0puYkdaS0RlUkxnRWNDcmRyalZGa2xkMHFsU1VvMWZnd3VSRmV5?= =?utf-8?B?L1BZZjZ0eDBDSzRjVzVEbDJLMTFvbkhsQ0w3WU9MS3UrTnNRSmJldXVWT0hn?= =?utf-8?B?cDFqcTRzcjQ2d2NsWmJERU1XMzI4RlNmTGxNdUdrMXY3VWdoSkI0R3hXN0Jy?= =?utf-8?B?VzQ5dnBJNG5BVTZJNWV3R1FyTUF1ZkRvVjE5ME1VQTNBUlIzWmtYajJQb3VT?= =?utf-8?B?UUFCUUIyRENsU3NCempka0ZRWlZobzIrbXR1T29PTlNvcDhWamg1YVgvS2pP?= =?utf-8?B?VytkempLR3hydGZIZWZkcmg0c1oyc213WGtYOE1KRnE4eDFuSFI1b284YXZw?= =?utf-8?B?K0dhSHJGTTMzN21FaXVpdVZBdUJienE3Y09UR0NmcjdDaE1LYjJleXFxNVlF?= =?utf-8?B?ZzEwVk4yNWsxWnByZlc3a2Nxc0svMUU3cE91cUwxM1BDc3Uvd1VQdU43bTZt?= =?utf-8?B?UXo2QW50bFc0TVduV01KNW9jd0I5SWdvajF4dXJUOWZ6NDBmQzZGMG85bE1r?= =?utf-8?B?aXhPenM0aVJWUUtKTGt0Y2NBaU1EcDBZdkFlMnV6SzFiQnh1SEtQVC9OYnU0?= =?utf-8?B?TzdtYk50MExTa003bUw2NWpMZGZyS3BFcG5HUWViK2pUREt4cTRwbjFlWmFI?= =?utf-8?B?RFZwOFVwWXZTdngwRGRyelhoZ0pWVDQxbjdSTk1JcHl2VjlBQ0dRa2hBOG9j?= =?utf-8?B?NzlrQ1pCTHcyTnVhbStLZ0NtK0ExVWZKdjh4MDNiNWdBTDZzWWhPZ051YVNO?= =?utf-8?B?M0NGbkcyTW5COHh3b3hjYStOM0hUc0lkYm5ldlQvSU9nZ2xmazlJZ2hqb3FP?= =?utf-8?B?MkU2a09QQU1hMmdJS2ptSWFFcUFkb1JGVDlpQ0d0SXJaaEo5djF2WnVHRjBi?= =?utf-8?B?ZVM5L2F2elRpUGkxOW9pVnhqUzVraEdpcEQrNXA1WXJLTlArV1g2a005YTRU?= =?utf-8?B?WVA3a3UrS3dZK2I4Vkx1cEgwN2VSNTVhWjI4K25ZY1RGcGlKcDZNSWJpYm1q?= =?utf-8?B?c3NZRXpoM2JURFFDMXRNUHZBenlmTEJyK1dBUXB1SkoyYjhYQXZNVm85amNl?= =?utf-8?B?Z0lQK05vcWt0dHJFV1BsZGx2akVUUy9JTGNQVXRLVllyODgyVEN5OTZZMWRq?= =?utf-8?B?Q2VVREkra1NiNXNDeXFwOFY2SnIrbzgwSWx6bEJQaG1NUC9NZVRiQ1RjWnNj?= =?utf-8?B?a3FERnIwb25mTGtIRDJlc3NXdVZjNHpsUEdPdlVXTmJrcjlMVUNPbjB0azNE?= =?utf-8?B?U28wVCtUNThYM1R1N0tadFlFaUpzMmFvdGtUQ1hiTzZtTmVMWUxNaUk3bkNs?= =?utf-8?B?Umduc2hmWEQxcG1ZY295SGZ5S09hTXNSajhPcjc3STdSdFZIRjRjOTVLRzFW?= =?utf-8?Q?rS53U61gDSq9MPPjng/mID70d?= Content-ID: MIME-Version: 1.0 X-OriginatorOrg: solid-run.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8963.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cf651152-b361-4ca3-c73f-08dc16973451 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jan 2024 13:29:45.3059 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a4a8aaf3-fd27-4e27-add2-604707ce5b82 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BkusBQacHl26u2T45wJzm7V2d7Ht5HCLy3tr9k+6dOVRSgQK3ChR2E0f8e45pH5kvcmIfFv5sYi32mq26ZsakQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8241 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240116_052954_450759_13F8D957 X-CRM114-Status: GOOD ( 13.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am 15.01.24 um 11:32 schrieb Josua Mayer: > Am 15.01.24 um 11:21 schrieb Krzysztof Kozlowski: >> On 15/01/2024 11:05, Josua Mayer wrote: >>> + >>> + ti,pruss-gp-mux-sel = <2>, /* MII mode */ >>> + <2>, >>> + <2>, >>> + <2>, /* MII mode */ >>> + <2>, >>> + <2>; This property is described in remoteproc/ti,pru-consumer.yaml without explanation what each numeric value means.| SoC TRM provides these names: "GP", "EnDAT", "MII", "SD". Is it okay to keep number here, or are named constants needed? Additionally, this array better to do in single line?: /* configurei nternal mux for mii mode */ ti,pruss-gp-mux-sel = <2>, <2>, <2>, <2>, <2>, <2>; >>> + >>> + ti,mii-g-rt = <&icssg1_mii_g_rt>; >>> + ti,mii-rt = <&icssg1_mii_rt>; >>> + ti,iep = <&icssg1_iep0>, <&icssg1_iep1>; >>> + >>> + interrupt-parent = <&icssg1_intc>; >>> + interrupts = <24 0 2>, <25 1 3>; >>>>>> None of these are typical interrupt constants/flags? "pruss-intc" interrupt controller driver has a special xlate function, taking 3 integer arguments: event, channel, host. I came up with the below description: /* * icssg subsystem interrupt controller can be programmed * for routing any of 64 predefined subsytem-internal events * (documented in TRM) to one of 20 host interrupts. * Some host interrupts are device-wide, others special * purpose. * Mapping is done via one of 20 channels - channel number * decides processing priority (0 = highest). * * * Map pru-internal interrupt #8 (24) via channel 0 to * host-side pru interrupt #0 (2) (gic 246 / "host_intr0"); * and pru-internal interrupt #9 via channel 0 to * host-side pru interrupt #1 (3) (gic 247 / "host_intr1"). */ I feel it is a bit long to put in dts, perhaps I can put just second paragraph? However this paragraph is still a bit confusing - I should make it more readable, especially how 24 translates to 8 and 2 to 0, etc.. First paragraph is not needed, because bindings doc for this interrupt controller has a good description for #interrupt-cells: interrupt-controller/ti,pruss-intc.yaml The 64 events, and 20 hosts have names in the TRM. Some of them are particular, others are generic, e.g. INTR_REQ[0:15]. Creating a header with named constants seems doable. Is it worth doing this? Sincerely Josua Mayer _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel