From: f.fainelli@gmail.com (Florian Fainelli)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mips: bcm63xx: spi: Fix checkpatch.pl warnings
Date: Mon, 19 Jun 2017 10:21:51 -0700 [thread overview]
Message-ID: <2d01bbe8-33bd-9aea-8906-0fe54bb2c334@gmail.com> (raw)
In-Reply-To: <1497890980-4334-1-git-send-email-aravind.thk@gmail.com>
On 06/19/2017 09:49 AM, Aravind Thokala wrote:
> This patch fixes the checkpatch.pl warnings on the driver
> file.
>
> Signed-off-by: Aravind Thokala <aravind.thk@gmail.com>
The subject should be spi/bcm63xx: Fix checkpatch warnings to be
consistent with previous submissions done to that file.
With that:
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> drivers/spi/spi-bcm63xx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/spi/spi-bcm63xx.c b/drivers/spi/spi-bcm63xx.c
> index 247f71b..84c7356 100644
> --- a/drivers/spi/spi-bcm63xx.c
> +++ b/drivers/spi/spi-bcm63xx.c
> @@ -147,7 +147,7 @@ struct bcm63xx_spi {
>
> /* Platform data */
> const unsigned long *reg_offsets;
> - unsigned fifo_size;
> + unsigned int fifo_size;
> unsigned int msg_type_shift;
> unsigned int msg_ctl_width;
>
> @@ -191,7 +191,7 @@ static inline void bcm_spi_writew(struct bcm63xx_spi *bs,
> #endif
> }
>
> -static const unsigned bcm63xx_spi_freq_table[SPI_CLK_MASK][2] = {
> +static const unsigned int bcm63xx_spi_freq_table[SPI_CLK_MASK][2] = {
> { 20000000, SPI_CLK_20MHZ },
> { 12500000, SPI_CLK_12_50MHZ },
> { 6250000, SPI_CLK_6_250MHZ },
>
--
Florian
next prev parent reply other threads:[~2017-06-19 17:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-19 16:49 [PATCH] mips: bcm63xx: spi: Fix checkpatch.pl warnings Aravind Thokala
2017-06-19 17:21 ` Florian Fainelli [this message]
2017-06-19 17:45 ` Aravind Thokala
2017-06-21 11:16 ` Applied "spi/bcm63xx: Fix checkpatch warnings" to the spi tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d01bbe8-33bd-9aea-8906-0fe54bb2c334@gmail.com \
--to=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).