From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BD45C6369E for ; Thu, 3 Dec 2020 00:14:12 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 992D521527 for ; Thu, 3 Dec 2020 00:14:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 992D521527 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vSMXC/bMxmAYdrWrlwWapUZwV01gPOHg+ghqzPIj3VU=; b=sUKtp/QImesY0ycD//qgEugO+ SWIfQZakURiAGLmxCCBKJda+Pf9bYbPX2Rlr1f6mpFN94kV93f80I9bVyNBHX0UsV/Z5MJpxlM0qa 7f63V4oucDgPHnChONEThYvxWOaDfUFzEZ3yniZ3Q6i4FrSR7rsfrc3tazeo4YsTLFHQ0yIveWxS3 LsOKSJowaEKnbJukWlZLbyFLWv8cvnBEvzRCpsUi3wHzJw53wKbjFKCwTQe+C9VsmGP66b6bxFtYR dUhaVoKBcLDTQ3M5mdwnE8mcVUfdGbp8EuN+/8NTqohZs/A5aHeNbUlYsE0I7lwxiATPoPizInORu 45j17xEQQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkcF1-0007sC-TR; Thu, 03 Dec 2020 00:12:59 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkcEz-0007rh-Ih for linux-arm-kernel@lists.infradead.org; Thu, 03 Dec 2020 00:12:58 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 39101113E; Wed, 2 Dec 2020 16:12:49 -0800 (PST) Received: from [192.168.0.130] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 95B713F575; Wed, 2 Dec 2020 16:12:45 -0800 (PST) Subject: Re: [RFC V2 0/3] mm/hotplug: Pre-validate the address range with platform To: Heiko Carstens References: <1606706992-26656-1-git-send-email-anshuman.khandual@arm.com> <20201202203540.GC11274@osiris> From: Anshuman Khandual Message-ID: <2d2a947f-3c4f-6106-583a-7da4e757a7aa@arm.com> Date: Thu, 3 Dec 2020 05:42:35 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201202203540.GC11274@osiris> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201202_191257_766863_07A2B4E1 X-CRM114-Status: GOOD ( 19.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , linux-s390@vger.kernel.org, Vasily Gorbik , david@redhat.com, Catalin Marinas , linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, Will Deacon , Ard Biesheuvel , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/3/20 2:05 AM, Heiko Carstens wrote: > On Mon, Nov 30, 2020 at 08:59:49AM +0530, Anshuman Khandual wrote: >> This series adds a mechanism allowing platforms to weigh in and prevalidate >> incoming address range before proceeding further with the memory hotplug. >> This helps prevent potential platform errors for the given address range, >> down the hotplug call chain, which inevitably fails the hotplug itself. >> >> This mechanism was suggested by David Hildenbrand during another discussion >> with respect to a memory hotplug fix on arm64 platform. >> >> https://lore.kernel.org/linux-arm-kernel/1600332402-30123-1-git-send-email-anshuman.khandual@arm.com/ >> >> This mechanism focuses on the addressibility aspect and not [sub] section >> alignment aspect. Hence check_hotplug_memory_range() and check_pfn_span() >> have been left unchanged. Wondering if all these can still be unified in >> an expanded memhp_range_allowed() check, that can be called from multiple >> memory hot add and remove paths. >> >> This series applies on v5.10-rc6 and has been slightly tested on arm64. >> But looking for some early feedback here. >> >> Changes in RFC V2: >> >> Incorporated all review feedbacks from David. >> >> - Added additional range check in __segment_load() on s390 which was lost >> - Changed is_private init in pagemap_range() >> - Moved the framework into mm/memory_hotplug.c >> - Made arch_get_addressable_range() a __weak function >> - Renamed arch_get_addressable_range() as arch_get_mappable_range() >> - Callback arch_get_mappable_range() only handles range requiring linear mapping >> - Merged multiple memhp_range_allowed() checks in register_memory_resource() >> - Replaced WARN() with pr_warn() in memhp_range_allowed() >> - Replaced error return code ERANGE with E2BIG >> >> Changes in RFC V1: >> >> https://lore.kernel.org/linux-mm/1606098529-7907-1-git-send-email-anshuman.khandual@arm.com/ >> >> Cc: Heiko Carstens >> Cc: Vasily Gorbik >> Cc: Catalin Marinas >> Cc: Will Deacon >> Cc: Ard Biesheuvel >> Cc: Mark Rutland >> Cc: David Hildenbrand >> Cc: Andrew Morton >> Cc: linux-arm-kernel@lists.infradead.org >> Cc: linux-s390@vger.kernel.org >> Cc: linux-mm@kvack.org >> Cc: linux-kernel@vger.kernel.org > > Btw. please use git send-email's --cc-cover option to make sure that > all patches of this series will be sent to all listed cc's. > I really dislike to receive only the cover-letter and maybe on patch > and then have to figure out where to find the rest. Okay, will ensure that. > > Thanks :) > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel