From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B5B6F36C2A for ; Mon, 20 Apr 2026 06:59:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=T3r02hhZx3Vxqyj1q31IQgqGPj+UcnZ1kBemjU+jdaU=; b=2DpVOa7lE4eelCpxfwdd4TadTP 8iEH44Kl4o2vqn0R5gJ53MISmyGT0+DtyRdPLPHIFSEaKibOAO/NV+PfTjVRSE/sVvJhLvKDHSBDg shDPXxgWsaAbZ8FsM3Jo71psG90hSXwtZlp5poFCGVaOiN6oJJuSAUFmFBQlohpIamQs3pmTKme3z e1Xafhr1eAp+KHBVNoShiNPVu5njdPi3cpSvgsvQdiCZLwWpYFTECbTeywIUFo2N3qC0W6zO1eGhw Dv48AfGty2TdEuWRSI8ZMoN6JhkemUaiiKkc18Ba8+2D21uSnSfGjqy/9KumY4o0K68ShDZSkMJmx /9LKs6Dg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1wEiar-00000006WSM-2YgZ; Mon, 20 Apr 2026 06:58:53 +0000 Received: from mail-dl1-x1236.google.com ([2607:f8b0:4864:20::1236]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1wEiao-00000006WRU-3sSG for linux-arm-kernel@lists.infradead.org; Mon, 20 Apr 2026 06:58:52 +0000 Received: by mail-dl1-x1236.google.com with SMTP id a92af1059eb24-12713e56abdso1508299c88.1 for ; Sun, 19 Apr 2026 23:58:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776668329; x=1777273129; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=T3r02hhZx3Vxqyj1q31IQgqGPj+UcnZ1kBemjU+jdaU=; b=VB1xQeIpyAqymbttticMhp/qeHn1ZrSmDYFFOyUmbmK/iRbzY45nelNSi2eKaHekPk dnG0iP8E/h97+/D6f44Cloy9r6ahZC4Mgdgw1ktqHC20tg0mre3cxcYG0dwN5UOCR72/ 045QhTlSUZ5biT6765qhMynLlLUviY7UCnqaRewpIq3oGyd2bbtNqPel/GVXYHRIv1MO uOVRLP7pJtF+vsqKigb3E8gidpk8odJXZMW/fFrOY5jN4/PPLjvQlKsvTlDeyjiunEy3 GfA/rHO2MguwlSyftZ3SRWfzYylIQkV5bVqB+z39X4mLIXuDRvfQ91dPiAxpOcSrHYdV v5eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776668329; x=1777273129; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=T3r02hhZx3Vxqyj1q31IQgqGPj+UcnZ1kBemjU+jdaU=; b=TT8OYng1uI33wpj2T8vlSn1liPpQBxAoT8VV+gTw5zTYLyDc1eE18DgYbvNN1aYJoP MnMzrnY+RT7NvXqm3qcLUd8AEmJjM9bahHJWjAIobj2WJ8zDYEH3T0sZSbCyJiqz0xdq E31y2Dmu+CULvPjQAJqD18Th/c6U14gcC8fG3Awl6jRZiQOW1m0pc3GspUC+79v7aYWr r0WqROgueowM7LkfrP/R9tiC/HTt+xm1tIakuxE3SupIl6ViesjZ9lPT7b9gvFKBbEZG TuHbbFo3vRLr0+7osOjnbNy9ajn4eVQKnIteT9mA1AcUKXZLIG5rUN0Af3vkyYfLF7CM pdhA== X-Forwarded-Encrypted: i=1; AFNElJ86Ry0gjdOQvJpVwVuYqhMljeozWF+Z3+uhjF/K0pgvwA8Mc7zhPbHfi+GU/NbyUAQuh+q7vab+O5ah4RX2GiIP@lists.infradead.org X-Gm-Message-State: AOJu0Yyw3Nc24uuFGu/TtMBm2sj6tLCiLdQDpLMWdIhlSC+Y5YnTU6mK ROQpCNohT65kurIfjpcRZ2xmr9GDGSG22Q6vKOaa4oaQJdkgyjkAAeAD X-Gm-Gg: AeBDieu7Y+yk1mtIp4JxZfCYH0OlxQ/jm+7PByowrVZwMls8MUwcthe8XFLHia6FyWB V3XmSU6NqUlzTv8r9VOr/gilDVGZbh/3nQPtZJi7XdoYGcB0Yco7BV1Ej3XrpnrfAnRe67M1LrE 9PhC5I0DyaV9YCuSfbZTdgoxYIqzJbzHl78pEG3WUCl12XekmPo0r/dm0BkdKG+J3O/Afm7Fkce h8GldQdmhJGi98a5vfP6b4AQPgcurejfndSDrKrQ1ksT71gfj+2nq67czS4KXQBOZrKYJCuzCKs 5GnnpqPD/8TZM0CnnDLR84V5es5zE46ymkgON/SR/RcsksvY2a2CK7Ix1uz2kdwYsX71AQKge50 z641iqhsYno42brSXfjquXwzIbxIyFD6q+J3OvXWZQt64QKUXoukEOy1mf5ui3r8CAq/VnZYq2M 9HuF51Ac46 X-Received: by 2002:a05:7022:4191:b0:12c:427:dacf with SMTP id a92af1059eb24-12c73b05ceamr5070810c88.10.1776668329484; Sun, 19 Apr 2026 23:58:49 -0700 (PDT) Received: from CNSZTL-PC.lan ([2607:f130:0:13b::3a]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12c74a20b9csm13380651c88.12.2026.04.19.23.58.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 19 Apr 2026 23:58:49 -0700 (PDT) Message-ID: <2d2b1e17-388f-431a-be86-a0f26b5be6cf@gmail.com> Date: Mon, 20 Apr 2026 14:58:44 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] arm64: dts: rockchip: Replace deprecated snps,* props for NanoPi R5S To: Diederik de Haas , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner Cc: Arnd Bergmann , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Quentin Schulz , Jonas Karlman References: <20260401131551.734456-1-diederik@cknow-tech.com> <20260401131551.734456-3-diederik@cknow-tech.com> From: Tianling Shen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260419_235851_267440_B6577314 X-CRM114-Status: GOOD ( 19.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2026/4/15 22:23, Diederik de Haas wrote: > On Wed Apr 1, 2026 at 3:11 PM CEST, Diederik de Haas wrote: >> The various snps,reset-* properties are deprecated, so convert them into >> their replacements. >> >> Signed-off-by: Diederik de Haas >> --- >> arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dts | 7 +++---- >> 1 file changed, 3 insertions(+), 4 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dts b/arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dts >> index 90ce6f0e1dcf..92d044ec696b 100644 >> --- a/arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dts >> +++ b/arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dts >> @@ -85,10 +85,6 @@ &gmac0_tx_bus2 >> &gmac0_rx_bus2 >> &gmac0_rgmii_clk >> &gmac0_rgmii_bus>; >> - snps,reset-gpio = <&gpio0 RK_PC5 GPIO_ACTIVE_LOW>; >> - snps,reset-active-low; >> - /* Reset time is 15ms, 50ms for rtl8211f */ >> - snps,reset-delays-us = <0 15000 50000>; >> tx_delay = <0x3c>; >> rx_delay = <0x2f>; >> status = "okay"; >> @@ -100,6 +96,9 @@ rgmii_phy0: ethernet-phy@1 { >> reg = <1>; >> pinctrl-0 = <&gmac0_rstn_gpio0_c5_pin>; >> pinctrl-names = "default"; >> + reset-assert-us = <15000>; >> + reset-deassert-us = <50000>; >> + reset-gpios = <&gpio0 RK_PC5 GPIO_ACTIVE_LOW>; >> }; >> }; >> > > Please disregard/drop this patch. > > I was recently made aware of 'sashiko.dev' and checked whether it had > also checked my patch, which it did: > https://sashiko.dev/#/patchset/20260401131551.734456-1-diederik%40cknow-tech.com > > And it turns out that the concern raised is valid (thanks Quentin!), so > this patch could introduce a regression. > So it looks like staying with the deprecated properties is actually > better (in this case?). Well actually we more or less rely on U-Boot to reset the PHY first now. Many rockchip boards in tree require a reset before the PHY can be recognized, but we just use the generic "ethernet-phy-ieee802.3-c22" compatible. Another option is to move the reset props to mdio node instead of PHY node, though. Thanks, Tianling. > > Cheers, > Diederik