From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0676C4727F for ; Tue, 29 Sep 2020 13:27:21 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5670C208FE for ; Tue, 29 Sep 2020 13:27:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BiPsI5lu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5670C208FE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:References: To:From:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GoEBOovt36y+wbc2RS+J2v3VhPQPbeBIl9zM2FwEDAo=; b=BiPsI5luKH1ATJAPfoqWHNobI YLm2/wyZmK4YSN6tJCzJWRYU7mjWhICCIeHnFujoQweip80d+1ZDCRh1XMXOIBBJgULZa6pBWWtdo vf/9yIZYMgTcfHxJDQfsfoLiDAdr+eH1swGxN/YjWd0y5I+tk8g56+mROxvaCMf6XJaflBicXslhq Y88anLQlTECA6wbtUXKdMEP36hqzsUtk3TqJ0cjr7Ne8NmEmJU/a2s9qoFeK6mWgDQAfxvzJHYtjO JsX61EPQE33GenEeadjvW8GfCiSx2nmGo5HY5RqHWF0lksT4FZDyLqQsFxo+55WiZfzJ1FEk/Yux9 Z7KLq29Yw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNFdm-0008Jo-Gl; Tue, 29 Sep 2020 13:25:58 +0000 Received: from szxga06-in.huawei.com ([45.249.212.32] helo=huawei.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNFdj-0008GK-Jx for linux-arm-kernel@lists.infradead.org; Tue, 29 Sep 2020 13:25:57 +0000 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 6F51AD853F0E3BA08AE3; Tue, 29 Sep 2020 21:25:42 +0800 (CST) Received: from [127.0.0.1] (10.174.177.253) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.487.0; Tue, 29 Sep 2020 21:25:32 +0800 Subject: Re: [PATCH v4 12/20] dt-bindings: arm: hisilicon: convert hisilicon,hi3798cv200-perictrl bindings to json-schema From: "Leizhen (ThunderTown)" To: Rob Herring References: <20200928151324.2134-1-thunder.leizhen@huawei.com> <20200928151324.2134-13-thunder.leizhen@huawei.com> <20200928191425.GA3099266@bogus> <0568ed90-c6ac-ae1c-45ee-cdc6526d3fcf@huawei.com> <30a08e22-f8bb-1e42-087b-995dc525eaa4@huawei.com> Message-ID: <2d382466-5b91-7b43-2d12-8f7ceafe3691@huawei.com> Date: Tue, 29 Sep 2020 21:25:31 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <30a08e22-f8bb-1e42-087b-995dc525eaa4@huawei.com> Content-Language: en-US X-Originating-IP: [10.174.177.253] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200929_092555_957287_15F73436 X-CRM114-Status: GOOD ( 17.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , Kefeng Wang , linux-kernel , Wei Xu , Libin , Jonathan Cameron , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020/9/29 17:21, Leizhen (ThunderTown) wrote: > > > On 2020/9/29 11:18, Leizhen (ThunderTown) wrote: >> >> >> On 2020/9/29 3:14, Rob Herring wrote: >>> On Mon, Sep 28, 2020 at 11:13:16PM +0800, Zhen Lei wrote: >>>> Convert the Hisilicon Hi3798CV200 Peripheral Controller binding to DT >>>> schema format using json-schema. >>>> >>>> Signed-off-by: Zhen Lei >>>> --- >>>> .../controller/hisilicon,hi3798cv200-perictrl.txt | 21 ---------- >>>> .../controller/hisilicon,hi3798cv200-perictrl.yaml | 45 ++++++++++++++++++++++ >>>> 2 files changed, 45 insertions(+), 21 deletions(-) >>>> delete mode 100644 Documentation/devicetree/bindings/arm/hisilicon/controller/hisilicon,hi3798cv200-perictrl.txt >>>> create mode 100644 Documentation/devicetree/bindings/arm/hisilicon/controller/hisilicon,hi3798cv200-perictrl.yaml >>>> >>>> diff --git a/Documentation/devicetree/bindings/arm/hisilicon/controller/hisilicon,hi3798cv200-perictrl.txt b/Documentation/devicetree/bindings/arm/hisilicon/controller/hisilicon,hi3798cv200-perictrl.txt >>>> deleted file mode 100644 >>>> index 0d5282f4670658d..000000000000000 >>>> --- a/Documentation/devicetree/bindings/arm/hisilicon/controller/hisilicon,hi3798cv200-perictrl.txt >>>> +++ /dev/null >>>> @@ -1,21 +0,0 @@ >>>> -Hisilicon Hi3798CV200 Peripheral Controller >>>> - >>>> -The Hi3798CV200 Peripheral Controller controls peripherals, queries >>>> -their status, and configures some functions of peripherals. >>>> - >>>> -Required properties: >>>> -- compatible: Should contain "hisilicon,hi3798cv200-perictrl", "syscon" >>>> - and "simple-mfd". >>>> -- reg: Register address and size of Peripheral Controller. >>>> -- #address-cells: Should be 1. >>>> -- #size-cells: Should be 1. >>>> - >>>> -Examples: >>>> - >>>> - perictrl: peripheral-controller@8a20000 { >>>> - compatible = "hisilicon,hi3798cv200-perictrl", "syscon", >>>> - "simple-mfd"; >>>> - reg = <0x8a20000 0x1000>; >>>> - #address-cells = <1>; >>>> - #size-cells = <1>; >>>> - }; >>>> diff --git a/Documentation/devicetree/bindings/arm/hisilicon/controller/hisilicon,hi3798cv200-perictrl.yaml b/Documentation/devicetree/bindings/arm/hisilicon/controller/hisilicon,hi3798cv200-perictrl.yaml >>>> new file mode 100644 >>>> index 000000000000000..4e547017e368393 >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/arm/hisilicon/controller/hisilicon,hi3798cv200-perictrl.yaml >>>> @@ -0,0 +1,45 @@ >>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>>> +%YAML 1.2 >>>> +--- >>>> +$id: http://devicetree.org/schemas/arm/hisilicon/controller/hisilicon,hi3798cv200-perictrl.yaml# >>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>>> + >>>> +title: Hisilicon Hi3798CV200 Peripheral Controller >>>> + >>>> +maintainers: >>>> + - Wei Xu >>>> + >>>> +description: | >>>> + The Hi3798CV200 Peripheral Controller controls peripherals, queries >>>> + their status, and configures some functions of peripherals. >>>> + >>>> +properties: >>>> + compatible: >>>> + items: >>>> + - const: hisilicon,hi3798cv200-perictrl >>>> + - const: syscon >>>> + - const: simple-mfd >>>> + >>>> + reg: >>>> + description: Register address and size >>>> + maxItems: 1 >>>> + >>>> + '#address-cells': >>>> + const: 1 >>>> + >>>> + '#size-cells': >>>> + const: 1 >>> >>> That implies child nodes. You need some sort of schema for them. >> >> OK, I will drop #address-cells and #size-cells in this binding. > > I think I misunderstood. I shoud describe child nodes here. > > It's National Day the day after tomorrow, total eight days off. It's so hurry. > I'll give up this patch! And do it for v5.11 I searched the dtsi, these two properties are required by property "ranges", so I will add it. > ">> >>> >>>> + >>>> +required: >>>> + - compatible >>>> + - reg >>>> + >>>> +examples: >>>> + - | >>>> + perictrl: peripheral-controller@8a20000 { >>>> + compatible = "hisilicon,hi3798cv200-perictrl", "syscon", "simple-mfd"; >>>> + reg = <0x8a20000 0x1000>; >>>> + #address-cells = <1>; >>>> + #size-cells = <1>; >>>> + }; >>>> +... >>>> -- >>>> 1.8.3 >>>> >>>> >>> >>> . >>> >> >> >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >> >> . >> > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > > . > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel