From: "Andreas Färber" <afaerber@suse.de>
To: Amit Singh Tomar <amittomer25@gmail.com>,
manivannan.sadhasivam@linaro.org
Cc: matheus@castello.eng.br, andre.przywara@arm.com,
linus.walleij@linaro.org, linux-actions@lists.infradead.org,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] pinctrl: actions: fix function group name for i2c0_group
Date: Sun, 12 Apr 2020 23:58:05 +0200 [thread overview]
Message-ID: <2d629e23-ddb1-6033-5ea3-fe9e02476e18@suse.de> (raw)
In-Reply-To: <1586702060-3769-1-git-send-email-amittomer25@gmail.com>
Hi,
Am 12.04.20 um 16:34 schrieb Amit Singh Tomar:
> After commit 6f87359e8bcaf88381b9c9c038929e0e6872d308("pinctrl: actions: Fix
> functions groups names for S700 SoC") following error has been observed
> while booting Linux on Cubieboard7-lite(based on S700 SoC).
>
> [ 1.206245] pinctrl-s700 e01b0000.pinctrl: invalid group "i2c0_mfp" for function "i2c0"
>
> This commit fixes it by using correct name for i2c0_group.
>
> Fixes: 6f87359 ("pinctrl: actions: Fix functions groups names for S700 SoC")
The commit hash should have 12 digits.
Please also check the white spaces: The subject seems to have too many
after "actions:", and there's one missing before each parenthesis above.
Regards,
Andreas
> Signed-off-by: Amit Singh Tomar <amittomer25@gmail.com>
> ---
> drivers/pinctrl/actions/pinctrl-s700.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/actions/pinctrl-s700.c b/drivers/pinctrl/actions/pinctrl-s700.c
> index 47a4ccd..f579a65 100644
> --- a/drivers/pinctrl/actions/pinctrl-s700.c
> +++ b/drivers/pinctrl/actions/pinctrl-s700.c
> @@ -1435,7 +1435,7 @@ static const char * const sd2_groups[] = {
> static const char * const i2c0_groups[] = {
> "uart0_rx_mfp",
> "uart0_tx_mfp",
> - "i2c0_mfp_mfp",
> + "i2c0_mfp",
> };
>
> static const char * const i2c1_groups[] = {
>
--
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer
HRB 36809 (AG Nürnberg)
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-04-12 21:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-12 14:34 [PATCH] pinctrl: actions: fix function group name for i2c0_group Amit Singh Tomar
2020-04-12 14:58 ` Manivannan Sadhasivam
2020-04-12 21:58 ` Andreas Färber [this message]
2020-04-13 4:49 ` Manivannan Sadhasivam
2020-04-13 5:45 ` Amit Tomer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d629e23-ddb1-6033-5ea3-fe9e02476e18@suse.de \
--to=afaerber@suse.de \
--cc=amittomer25@gmail.com \
--cc=andre.przywara@arm.com \
--cc=linus.walleij@linaro.org \
--cc=linux-actions@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=matheus@castello.eng.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox