From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 25E9DC4345F for ; Sun, 14 Apr 2024 11:41:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=J23Ty/d1Iww3M5Y1mImE2t0/Gyls/vZKuBUXB3HB5uU=; b=zi4bCfF7rAltwG 4WkLUx7tbk8S9aUYqP6UGcceEc3INjvkGsdMoKbJixZ9fgpULKBo5Sux4oyHSKHMhqbWq4m3WJQcO hIJ/VInS812AhQVaZ8LBuXaNNFXv1GyVBkJlTaaXGXnrc8NqbzwQArnlZjHqhUyTkGfjIEfU1Wyto tRg7HSmVRVJCWfPmoR29aV8/rzikzSFw0q+bBuWr4Upq7/NgNIJNyPmvsZ5r137pQzdcTE56zQHA4 /UjdTGaPEPc75MThHoIlQHw6DX1QWMnuSnK7j+9r+OyTHyIyJKzKz5oW/gcvzlkmhkrtOzDJCsjSz O/eMWGwVy0+sdfPjrdkA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvyEx-00000005Mg1-38YI; Sun, 14 Apr 2024 11:41:43 +0000 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvyEu-00000005Mf4-12Ky for linux-arm-kernel@lists.infradead.org; Sun, 14 Apr 2024 11:41:41 +0000 Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-346b146199eso1630277f8f.0 for ; Sun, 14 Apr 2024 04:41:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713094897; x=1713699697; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ZNPrvH/uFX737faIwrBH9u4ApwKYKRw6XwNvCWgpcCk=; b=nDHEIltQ/ZbNHcSY4X+EQpT7asYrWvInl4uku8WHoPcKSSfsdmUnYxxM/X9F1CAy8i AVpbE3Yb4+KpPEc+Tvj4sndbnWEn+3n2mVjeTOe4yilo+vV/UVjwaBZkCjRKMR/7KENz WlQnJe65LVKMlEGHMPPgkrtoSHSgRL4ClLUwH1O9zOc1+m/NedP05RcTFaWp7Euo7Lsn NlKh/8942EaBN1rpsTttygIhVsMvSRvYPZR2EA3PF9ur9gRwY2/9RoO+g0asTaA6iwgd 3Hcyo6l+YqfkjpYmFi+9FPG0vecJHL3nG3EZmyjXt2kr/XTD+Wiy7QQ3tcHY7YnG0Hut KUwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713094897; x=1713699697; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZNPrvH/uFX737faIwrBH9u4ApwKYKRw6XwNvCWgpcCk=; b=GO856vrivx52i0UPF9I0NpNNHsEZh+pNU5lIwDFE4GdNNQgbtnZHtL3uMTtxgM6ICI NChGTeW31D/fKozA52TfCkl+oTeLrt5xI7pwSCOaH+ykpOdkQImrN0IHNgE7abx0vwQs g7XdIKkFamJ62QsbktmFm98zzoyJiTO3qSstzaTBayAgRWOkeqecUoq/rYWDeVbqZcaT M6cM33DSek4DrrMdDgdYqxZPxez/wGVg8PqIN+/FEJo4EA3hwBvb+ANB8lJ7Sj7WvgRE 0mH+Od17yS5ixKh06z/YjNgJkfzya0ZExFkMhRwCxAfqqEJln6eqR7HKDhzeU7wyX+Yw w4+w== X-Forwarded-Encrypted: i=1; AJvYcCXi4HCZC9XKAP4RKdD8NxO+d4ADM5jhC6lBh+7LQRN1j9WKXP/BMXfIWNZVgjz56Qf+Osf5hPfHwk7TGL2JHoE9+3c7XRDrxzGR8N4TrjAUYcRTTRg= X-Gm-Message-State: AOJu0YxAy+CknbTZdxtwS9KIw1vGL7lXs3Ofz2bAWKfNMkWwzmB90kxl ftpdHerZsmLg1+bZh92cPNavf10vN9J6ynS+54RMganJri8xg9Q= X-Google-Smtp-Source: AGHT+IHs6RhKe0Y4tGvcMZrslfWyJRVTebp0xInWZK0eUAtOK4pAEIxVzZS+wR3KWrQ4pydWlFfcLg== X-Received: by 2002:a05:600c:4f89:b0:413:f80f:9f9 with SMTP id n9-20020a05600c4f8900b00413f80f09f9mr4984699wmq.25.1713094897423; Sun, 14 Apr 2024 04:41:37 -0700 (PDT) Received: from p183 ([46.53.253.158]) by smtp.gmail.com with ESMTPSA id ay8-20020a05600c1e0800b004181c91d1dcsm5753154wmb.18.2024.04.14.04.41.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Apr 2024 04:41:36 -0700 (PDT) Date: Sun, 14 Apr 2024 14:41:34 +0300 From: Alexey Dobriyan To: Chaitanya S Prakash Cc: linux-perf-users@vger.kernel.org, anshuman.khandual@arm.com, james.clark@arm.com, Josh Poimboeuf , Peter Zijlstra , Suzuki K Poulose , Mike Leach , John Garry , Will Deacon , Leo Yan , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Chenyuan Mi , Masami Hiramatsu , Ravi Bangoria , Ahelenia =?utf-8?Q?Ziemia=C5=84ska?= , Colin Ian King , Changbin Du , Kan Liang , Athira Rajeev , Tiezhu Yang , Georg =?utf-8?Q?M=C3=BCller?= , Liam Howlett , bpf@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2 0/8] perf tools: Fix test "perf probe of function from different CU" Message-ID: <2d7a896b-bbee-4285-9b2b-3edfab6797d3@p183> References: <20240408062230.1949882-1-ChaitanyaS.Prakash@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240414_044140_310185_9A411C68 X-CRM114-Status: GOOD ( 14.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 11, 2024 at 05:40:04PM +0530, Chaitanya S Prakash wrote: > > On 4/9/24 11:02, Alexey Dobriyan wrote: > > On Mon, Apr 08, 2024 at 11:52:22AM +0530, Chaitanya S Prakash wrote: > > > - Add str_has_suffix() and str_has_prefix() to tools/lib/string.c > > > - Delete ends_with() and replace its usage with str_has_suffix() > > > - Delete strstarts() from tools/include/linux/string.h and replace its > > > usage with str_has_prefix() > > It should be the other way: starts_with is normal in userspace. > > C++, Python, Java, C# all have it. JavaScript too! > > This is done in accordance with Ian's comments on V1 of this patch > series. Please find the link to the same below. Yes, but str_has_suffix() doesn't make sense in the wider context. > https://lore.kernel.org/all/CAP-5=fUFmeoTjLuZTgcaV23iGQU1AdddG+7Rw=d6buMU007+1Q@mail.gmail.com/ The naming ends_with makes sense but there is also strstarts and str_has_prefix, perhaps str_has_suffix would be the most consistent and intention revealing name? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel