From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD41AC00307 for ; Fri, 6 Sep 2019 15:20:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A52FC20650 for ; Fri, 6 Sep 2019 15:20:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="c6B7Q0za" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A52FC20650 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JzeakSZHNzI+1a+iPrky2tv0Yv9Xv5Z+YweHYP7cjtQ=; b=c6B7Q0zanekkwb kIw6hWLseJP70RrFOvnJcHYGtZaQi4GMakjBRCFGaPvoS1LJC6cxlL6O0KKlCvNBuuMOSeQhH+/0s 55SRFf+ShjpwYbKwj6YwN8cfT5r4xCNfyZzTPv3X8vzFnViGaA5rR12DBhkXHlA8ZZc/76uPYYhbA qG2czKq+JgGXQ+8D6qOCQi01DUrg3XO5AQeYZupcLJhlkLm0u4aABDAXhFW0NgNWCffIOPqcGgQzI 5l6yRLYi7Uhj1pkXUQF3eZcboWoOwSkawLVZPWZ8svaygC1VvbXGJnX/BfMHLa80G2dQVZWeuwVp6 Fkh9TxbhRzRCdKuVCOBA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i6G2Q-0006Kl-1b; Fri, 06 Sep 2019 15:20:38 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i6G2J-0006Fi-Qk; Fri, 06 Sep 2019 15:20:33 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D76601576; Fri, 6 Sep 2019 08:20:30 -0700 (PDT) Received: from [10.1.196.105] (unknown [10.1.196.105]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E23E83F59C; Fri, 6 Sep 2019 08:20:27 -0700 (PDT) Subject: Re: [PATCH v3 09/17] arm64, trans_pgd: add trans_pgd_create_empty To: Pavel Tatashin References: <20190821183204.23576-1-pasha.tatashin@soleen.com> <20190821183204.23576-10-pasha.tatashin@soleen.com> From: James Morse Message-ID: <2d9f7511-ce65-d5ca-653e-f4d43994a32d@arm.com> Date: Fri, 6 Sep 2019 16:20:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20190821183204.23576-10-pasha.tatashin@soleen.com> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190906_082032_215754_3AC85757 X-CRM114-Status: UNSURE ( 9.78 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sashal@kernel.org, mark.rutland@arm.com, vladimir.murzin@arm.com, corbet@lwn.net, marc.zyngier@arm.com, catalin.marinas@arm.com, bhsharma@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, jmorris@namei.org, linux-mm@kvack.org, ebiederm@xmission.com, matthias.bgg@gmail.com, will@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Pavel, On 21/08/2019 19:31, Pavel Tatashin wrote: > This functions returns a zeroed trans_pgd using the allocator that is > specified in the info argument. > > trans_pgds should be created by using this function. This function takes the allocator you give it, and calls it once. Given both users need one pgd, and have to provide the allocator, it seems strange that they aren't trusted to call it. I don't think this patch is necessary. Let the caller pass in the pgd_t to the helpers. Thanks, James _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel