From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2DCE4C6FD1D for ; Mon, 20 Mar 2023 16:25:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Cw/3IhWgM6AFjm9+RIOym8nKL9aqqaOI5EcC8eQw88U=; b=vLgGfgR5duq6E1wfjBhB3K5r0S pKLpG80sXyODVl+lu/bfCkBUQj3zG+JQasTlPrkF2H6weCzksMLxs2WqWFL8j3fcyEmSLxHkuE5e7 iJ1vvk4ta5j40EB/ohwa+TqZ8k1eDjeGmeh3OabjdtWJOZDrb1l6X8xJz1ym2IH1xZeu+nwEZHYpB rDnXJ04dPoRLAqDXCgD3d5tNX7NRCHLHxO7eLRbap1jY78HMMvTMH6t9UHp7jfia+pUL82OUkV5eu LdgBQ3Ga4KJ9BIzdk/RHI0ShtLAeyZskve5M24Af+t4YC1at/fDnRhc+66kq7y1K867YQNA1n5roe 8aXCMrcQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1peIJD-009l0w-0T; Mon, 20 Mar 2023 16:24:31 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1peIJ9-009kzv-0Q for linux-arm-kernel@lists.infradead.org; Mon, 20 Mar 2023 16:24:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679329462; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yKuiUgRvJgr0BMcont0ecSgYQ2TFv8+RdPWPNJF4zVg=; b=Owjbtfol9gupKpVQpn8vr52ZHcU16LTzfSHsMgZ6BFyh9PSVfsycyaxZEXRMSVSTIohxLe s72bCH+snqHegJUtY/X5w6tqKKF3Zgd1aPOn0DkGg+Be2fDx1r5cHBrlNVJe2FtP2u+7YC kih23Lxd4zGT2pk/bPe/QFszdg44oyA= Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-515-iFUJZe5LPt6iWvJOHI217w-1; Mon, 20 Mar 2023 12:24:21 -0400 X-MC-Unique: iFUJZe5LPt6iWvJOHI217w-1 Received: by mail-pl1-f199.google.com with SMTP id a9-20020a170902b58900b0019e2eafafddso7378187pls.7 for ; Mon, 20 Mar 2023 09:24:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679329460; h=content-language:content-transfer-encoding:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yKuiUgRvJgr0BMcont0ecSgYQ2TFv8+RdPWPNJF4zVg=; b=T4KhptStxrSzxT3m3zbbzIHY+emCdHcBVilITZvK0tl5uB8c06psomJPXpw5si90C9 FmyxlsvouVuGTEpSP37D+lND+PEpkjtAaf3n8bOGan75emRBGMhcehAD/Wj9vnxL2S6W BPIikUHBWm1wpo/QFePSGqn+VCAMw0GZw1//8V1II5jPHsZDHgCm6+6ScV2boGzxh6Bp mQebJZFFqen8M+lORGYPMk6rW679UXHbT8bEQe+7G8RhKuSSxi0uuUT7Bh0PZitvi52e Qj7nO0e7rxqhBAgZtm1oUKio0YiOeQkz6c59dVd7ejeBa39yBXo2DJ0B4yIB4qEpiRxL XcMQ== X-Gm-Message-State: AO0yUKW7neLE0YpShYdGVU9JETB7DrGDsG7qMm+TkajSIocuzmNVC8/+ SoedATrKBPKNLr3yNxOWn3OlWvt6utTxvjebk33xUpNBvL1Dh+F1+dKBMk5ITjk12+Iwc4zmbuB Q0rEb9iWRwQFh/myXcouMzDQtAWRMiji211/grJYI1YA= X-Received: by 2002:a62:7910:0:b0:625:e77b:93b2 with SMTP id u16-20020a627910000000b00625e77b93b2mr16590853pfc.5.1679329460496; Mon, 20 Mar 2023 09:24:20 -0700 (PDT) X-Google-Smtp-Source: AK7set9RPaNXkyvrZQBlHuyu3LLY2I0lqvkat9qvlTe6YR423Sg2i2SXi7nbLf5x5L1aI2JLWCb6+w== X-Received: by 2002:a62:7910:0:b0:625:e77b:93b2 with SMTP id u16-20020a627910000000b00625e77b93b2mr16590831pfc.5.1679329460084; Mon, 20 Mar 2023 09:24:20 -0700 (PDT) Received: from localhost.localdomain (024-205-208-113.res.spectrum.com. [24.205.208.113]) by smtp.gmail.com with ESMTPSA id g11-20020aa7818b000000b005892ea4f092sm6761949pfi.95.2023.03.20.09.24.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Mar 2023 09:24:19 -0700 (PDT) Subject: Re: [PATCH] fpga: xilinx-pr-decoupler: remove unused xlnx_pr_decouple_read function To: Xu Yilun , Michal Simek Cc: mdf@kernel.org, hao.wu@intel.com, michal.simek@xilinx.com, nathan@kernel.org, ndesaulniers@google.com, linux-fpga@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev References: <20230317230617.1673923-1-trix@redhat.com> From: Tom Rix Message-ID: <2dc1f25d-d621-ec04-6de5-f731f2a8bb41@redhat.com> Date: Mon, 20 Mar 2023 09:24:15 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230320_092427_266308_566EA664 X-CRM114-Status: GOOD ( 16.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/20/23 7:16 AM, Xu Yilun wrote: > On 2023-03-20 at 08:40:22 +0100, Michal Simek wrote: >> >> On 3/18/23 00:06, Tom Rix wrote: >>> CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email. >>> >>> >>> clang with W=1 reports >>> drivers/fpga/xilinx-pr-decoupler.c:37:19: error: unused function 'xlnx_pr_decouple_read' [-Werror,-Wunused-function] >>> static inline u32 xlnx_pr_decouple_read(const struct xlnx_pr_decoupler_data *d, >>> ^ >>> This static function is not used, so remove it. >>> >>> Signed-off-by: Tom Rix >>> --- >>> drivers/fpga/xilinx-pr-decoupler.c | 6 ------ >>> 1 file changed, 6 deletions(-) >>> >>> diff --git a/drivers/fpga/xilinx-pr-decoupler.c b/drivers/fpga/xilinx-pr-decoupler.c >>> index 2d9c491f7be9..b6f18c07c752 100644 >>> --- a/drivers/fpga/xilinx-pr-decoupler.c >>> +++ b/drivers/fpga/xilinx-pr-decoupler.c >>> @@ -34,12 +34,6 @@ static inline void xlnx_pr_decoupler_write(struct xlnx_pr_decoupler_data *d, >>> writel(val, d->io_base + offset); >>> } >>> >>> -static inline u32 xlnx_pr_decouple_read(const struct xlnx_pr_decoupler_data *d, >>> - u32 offset) >>> -{ >>> - return readl(d->io_base + offset); >>> -} >>> - >>> static int xlnx_pr_decoupler_enable_set(struct fpga_bridge *bridge, bool enable) >>> { >>> int err; >>> -- >>> 2.27.0 >>> >> It should be fixed like this instead. >> >> Thanks, >> Michal >> >> diff --git a/drivers/fpga/xilinx-pr-decoupler.c b/drivers/fpga/xilinx-pr-decoupler.c >> index 2d9c491f7be9..58508f44cd49 100644 >> --- a/drivers/fpga/xilinx-pr-decoupler.c >> +++ b/drivers/fpga/xilinx-pr-decoupler.c >> @@ -69,7 +69,7 @@ static int xlnx_pr_decoupler_enable_show(struct >> fpga_bridge *bridge) >> if (err) >> return err; >> >> - status = readl(priv->io_base); >> + status = xlnx_pr_decouple_read(priv); > OK, I'll drop the previous fix, and waiting for the new one. Michal, Will you make this change ? Tom > > Thanks, > Yilun > >> clk_disable(priv->clk); >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel