From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9948BC43381 for ; Fri, 15 Jan 2021 18:09:44 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 59C0D23A59 for ; Fri, 15 Jan 2021 18:09:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 59C0D23A59 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zk7RgcfISUPWG38nsR4ZIKJb9Nm566vQU1h7k4h+g7w=; b=PWq+GN6r1k3D4SJEReWOQOcZA WvXqeUV5d7tiqlAIOer1ZDcqP46wfL07v0jFbv0gfB7A+AQhvUQX03fn/g2k7SgTGuEesXHETWeot +w9aOxzy5FTBrjrz/L4oM7/ZY2cYcfgS7ue95/zbzgVCaXY+vGur9qHw/STO0RJ9LHJ81j0+T7I1j DiajUWBD9rawXPMUKIjm+jfqCYUKpEyBn6DtA9A+quD9DnvSe8urdPAIczfxvjlOfVS876OUWTnP/ U8XsPMphrpS6w/KGDd7R44rVjoCspIJqJ/reOsJtA2T90WgpH2GF/6/P1n96dkbGX9EfqrC8PiEiL XkVeywU4A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l0TVe-00081G-7i; Fri, 15 Jan 2021 18:07:42 +0000 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l0TVb-00080d-Ch for linux-arm-kernel@lists.infradead.org; Fri, 15 Jan 2021 18:07:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610734058; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3Md7vRoyiKJc0iq4tJJs8CQ7dxbz/DxlqmE3R+5lMtE=; b=LdaIQ1r6KXL7oVa2LM+8I7BQzL+s/ihAHP8TEqMwhGOu6UqabLzVAKKBjk/Z8n0VaLI82q 8oB7Jb1X0RkhL0DiRhcQ8NLNG09kvL5IvdTHEAvAdDtfRgZmJbKlWbUGwcdF3tWs/deuva 1cos7jfQ9nxzzCXoXjN+5L52u+0ojuI= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-536-UFZPKDEoOXy0RcRyabtQ7Q-1; Fri, 15 Jan 2021 13:07:28 -0500 X-MC-Unique: UFZPKDEoOXy0RcRyabtQ7Q-1 Received: by mail-qk1-f197.google.com with SMTP id f27so8792855qkh.0 for ; Fri, 15 Jan 2021 10:07:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=3Md7vRoyiKJc0iq4tJJs8CQ7dxbz/DxlqmE3R+5lMtE=; b=rkZmxtgivrgcXdY1Q/AKJOxpBeApA3+anqgEyn5HUCsnoQGq7u2nfcOwftJnae6/PM By9WfN5jmKUK6Kq8iYvPpdxv3EO18LvvnpHrTd06H0WMZ0gFJSoirCi6niM9fjvfixbD pzbwEXkVgCvCK3EaLlJv6ZzGUtRvP7t7okhf2qRT2k3bvzPgHvELAdgZM41NVH0HdwWj cf/4nT6E3dcL0VOJoME93gY3DWocZ30Xsbzac4k5ulTUT5uV2jxLXIXd4B6Mwgh6hkWw VBmfUlvz/f1ngAuOSinPV9iC79jZszOwuZVwOA8lanhMRUDnvSquMNXbR7BbZC+oKT9S 25UA== X-Gm-Message-State: AOAM530y1xrV3BqAjPbYLzy2gStw/O5GD73W4FkkYvzZNTZJWHadn9vS baXHnD2VzDy5agT8YFCf2Y09Ol/t9XSyhJNUTFshDF3eoxbPKMMUBWLRJPsA7J0v1iAqXHKXf5u gXsaiEA6INDIiybtyUgbVlg8fVim8gnhvjDw= X-Received: by 2002:ae9:d847:: with SMTP id u68mr13552515qkf.409.1610734048018; Fri, 15 Jan 2021 10:07:28 -0800 (PST) X-Google-Smtp-Source: ABdhPJyxGGsdmnjkULss7tilHK1g+lYfiaHQlYY+K09kc6sxYHVqk6Jy1JquyFM9u53peKnWffQPag== X-Received: by 2002:ae9:d847:: with SMTP id u68mr13552493qkf.409.1610734047725; Fri, 15 Jan 2021 10:07:27 -0800 (PST) Received: from trix.remote.csb (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id a203sm5516833qkb.31.2021.01.15.10.07.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Jan 2021 10:07:27 -0800 (PST) Subject: Re: [PATCH 1/2] dt-bindings: fpga: Add compatible value for Xilinx DFX AXI shutdown manger To: Nava kishore Manne , mdf@kernel.org, robh+dt@kernel.org, michal.simek@xilinx.com, linux-fpga@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20210115013431.27667-1-nava.manne@xilinx.com> From: Tom Rix Message-ID: <2dd1a504-9bb7-3bdb-028e-7edd0ed99668@redhat.com> Date: Fri, 15 Jan 2021 10:07:25 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210115013431.27667-1-nava.manne@xilinx.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=trix@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210115_130739_489448_40FD4A60 X-CRM114-Status: GOOD ( 23.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: git@xilinx.com, chinnikishore369@gmail.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 1/14/21 5:34 PM, Nava kishore Manne wrote: > This patch Adds compatible value for Xilinx Dynamic Function eXchnage(DFX) > AXI Shutdown manager IP. A multi patch set should have a cover letter. Use git format-patch --cover-letter > Signed-off-by: Nava kishore Manne > --- > .../bindings/fpga/xilinx-pr-decoupler.txt | 19 ++++++++++++++++--- > 1 file changed, 16 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt b/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt > index 4284d293fa61..42fca058a5f4 100644 > --- a/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt > +++ b/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt > @@ -7,13 +7,26 @@ changes from passing through the bridge. The controller can also > couple / enable the bridges which allows traffic to pass through the > bridge normally. Below is some wordsmithing to make the compatibility explicit and remove unneeded words > > +Xilinx LogiCORE Dynamic Function eXchange(DFX) AXI shutdown manager > +Softcore is compatible with the Xilinx LogiCORE pr-decoupler. > + > +The Xilinx LogiCORE Dynamic Function eXchange(DFX) AXI shutdown manager > +manages one or more shutdown managers / fpga bridges. > +The controller can shutdown/passthrough the bridges which prevents Delete 4 lines above. The DFX AXI shutdown manager prevents > +AXI traffic from passing through the bridge. The controller safely > +handles AXI4MM and AXI4-Lite interfaces on a Reconfigurable Partition > +when it is undergoing dynamic reconfiguration (DFX), preventing system I don't know about the use of '(DFX)' here, above it is Dynamic Function eXchange' Here it is dynamic reconfiguration, maybe just delete the '(DFX)' > +deadlock that can occur if AXI transactions are interrupted by DFX > + > The Driver supports only MMIO handling. A PR region can have multiple > -PR Decouplers which can be handled independently or chained via decouple/ > -decouple_status signals. > +PR Decouplers/AXI shutdown manager which can be handled independently > +or chained via decouple/ decouple_status signals. Being compatible, i don't think it is necessary to add to / change this section. > > Required properties: > - compatible : Should contain "xlnx,pr-decoupler-1.00" followed by > - "xlnx,pr-decoupler" > + "xlnx,pr-decoupler" or > + "xlnx,dfx-axi-shutdown-manager-1.00" followed by > + "xlnx,dfx-axi-shutdown-manager" > - regs : base address and size for decoupler module > - clocks : input clock to IP > - clock-names : should contain "aclk" Adding an example similar to the existing would be helpful. Tom _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel