linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Ninad Palsule <ninad@linux.ibm.com>
To: Conor Dooley <conor@kernel.org>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, joel@jms.id.au, andrew@codeconstruct.com.au,
	peterhuewe@gmx.de, jarkko@kernel.org, jgg@ziepe.ca,
	keescook@chromium.org, tony.luck@intel.com, gpiccoli@igalia.com,
	johannes.holland@infineon.com, linux@roeck-us.net,
	broonie@kernel.org, patrick.rudolph@9elements.com,
	vincent@vtremblay.dev, peteryin.openbmc@gmail.com,
	lakshmiy@us.ibm.com, bhelgaas@google.com,
	naresh.solanki@9elements.com, alexander.stein@ew.tq-group.com,
	festevam@denx.de, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	linux-integrity@vger.kernel.org, linux-hardening@vger.kernel.org,
	geissonator@yahoo.com
Subject: Re: [PATCH v1 1/8] dt-bindings: arm: aspeed: add IBM system1-bmc
Date: Tue, 12 Dec 2023 14:06:40 -0600	[thread overview]
Message-ID: <2ddae2e4-de55-41a1-a93e-819f8d55dde6@linux.ibm.com> (raw)
In-Reply-To: <20231212-thrower-ebook-d29a85a6ed96@spud>

Hello Conor,

On 12/12/23 11:09, Conor Dooley wrote:
> On Tue, Dec 12, 2023 at 10:39:57AM -0600, Ninad Palsule wrote:
>> Document the new compatibles used on IBM system1-bmc
>>
>> Tested:
>>      This board is tested using the simics simulator.
> I don't see how this is relevant to dt-bindings patches.
Make sense. Removed it.
>
>> Signed-off-by: Ninad Palsule <ninad@linux.ibm.com>
>> ---
>>   Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
>>   Documentation/devicetree/bindings/trivial-devices.yaml   | 2 ++
> IMO these should be split into two patches.

Make sense. Split it into two patches.

Thank you for the review.

Thanks & Regards,

Ninad

>
> Cheers,
> Conor.
>
>>   2 files changed, 3 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
>> index 6f7543463d89..ebebe14c42aa 100644
>> --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
>> +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
>> @@ -85,6 +85,7 @@ properties:
>>                 - facebook,yosemite4-bmc
>>                 - ibm,everest-bmc
>>                 - ibm,rainier-bmc
>> +              - ibm,system1-bmc
>>                 - ibm,tacoma-bmc
>>                 - inventec,starscream-bmc
>>                 - inventec,transformer-bmc
>> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
>> index 441b55723675..b12a60d2eb0f 100644
>> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
>> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
>> @@ -135,6 +135,8 @@ properties:
>>             - ibm,cffps1
>>               # IBM Common Form Factor Power Supply Versions 2
>>             - ibm,cffps2
>> +            # Infineon barometric pressure and temperature sensor
>> +          - infineon,dps310
>>               # Infineon IR36021 digital POL buck controller
>>             - infineon,ir36021
>>               # Infineon IR38060 Voltage Regulator
>> -- 
>> 2.39.2
>>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-12-12 20:07 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-12 16:39 [PATCH v1 0/8] Add device tree for IBM system1 BMC Ninad Palsule
2023-12-12 16:39 ` [PATCH v1 1/8] dt-bindings: arm: aspeed: add IBM system1-bmc Ninad Palsule
2023-12-12 17:09   ` Conor Dooley
2023-12-12 20:06     ` Ninad Palsule [this message]
2023-12-13 18:18   ` Jarkko Sakkinen
2023-12-13 18:36     ` Ninad Palsule
2023-12-12 16:39 ` [PATCH v1 2/8] dt-bindings: tpm: Add schema for TIS I2C devices Ninad Palsule
2023-12-12 17:14   ` Conor Dooley
2023-12-12 18:20     ` Guenter Roeck
2023-12-14 15:37       ` Ninad Palsule
2023-12-14 15:34     ` Ninad Palsule
2023-12-14 16:35       ` Conor Dooley
2023-12-14 20:13         ` Rob Herring
2023-12-13 16:13   ` Rob Herring
2023-12-14 22:23     ` Ninad Palsule
2024-01-08 19:44     ` Ninad Palsule
2023-12-13 18:20   ` Jarkko Sakkinen
2023-12-13 18:38     ` Ninad Palsule
2023-12-12 16:39 ` [PATCH v1 3/8] ARM: dts: aspeed: System1: IBM system1 BMC board Ninad Palsule
2023-12-12 20:20   ` Krzysztof Kozlowski
2023-12-14 15:06     ` Ninad Palsule
2023-12-12 16:40 ` [PATCH v1 4/8] ARM: dts: aspeed: System1: Add i2c and muxes Ninad Palsule
2023-12-12 20:21   ` Krzysztof Kozlowski
2023-12-14 18:34     ` Ninad Palsule
2023-12-15  7:35       ` Krzysztof Kozlowski
2023-12-12 16:40 ` [PATCH v1 5/8] ARM: dts: aspeed: System1: Voltage regulators Ninad Palsule
2023-12-12 20:22   ` Krzysztof Kozlowski
2023-12-14 16:30     ` Ninad Palsule
2023-12-12 16:40 ` [PATCH v1 6/8] ARM: dts: aspeed: System1: GPIO, Fan ctrl, Led Ninad Palsule
2023-12-12 20:25   ` Krzysztof Kozlowski
2024-01-08 19:56     ` Ninad Palsule
2023-12-12 16:40 ` [PATCH v1 7/8] tpm: tis-i2c: Add more compatible strings Ninad Palsule
2023-12-12 17:15   ` Conor Dooley
2023-12-12 18:00     ` Guenter Roeck
2023-12-12 18:51       ` Conor Dooley
2023-12-12 19:50         ` Guenter Roeck
2024-01-08 20:05           ` Ninad Palsule
2024-01-09 17:14             ` Conor Dooley
2024-01-09 23:55               ` Ninad Palsule
2024-01-09 23:55               ` Ninad Palsule
2024-01-10  7:50                 ` Krzysztof Kozlowski
2024-01-10 14:31                   ` Ninad Palsule
2024-01-10 15:37                     ` Krzysztof Kozlowski
2024-01-10 15:54                       ` Ninad Palsule
2024-01-10 16:23                         ` Conor Dooley
2024-01-10 17:54                         ` Krzysztof Kozlowski
2024-01-10 19:06                           ` Guenter Roeck
2024-01-10 20:34                             ` Krzysztof Kozlowski
2024-01-10 20:36                               ` Krzysztof Kozlowski
2024-01-10 21:41                               ` Guenter Roeck
2024-01-08 20:04     ` Ninad Palsule
2023-12-12 16:40 ` [PATCH v1 8/8] ARM: dts: aspeed: System1: PS, sensor and more Ninad Palsule
2023-12-12 20:26   ` Krzysztof Kozlowski
2023-12-13 19:02     ` Ninad Palsule
2023-12-13 19:37       ` Krzysztof Kozlowski
2023-12-13 19:49         ` Ninad Palsule
2023-12-14  7:24           ` Krzysztof Kozlowski
2023-12-14 14:24             ` Ninad Palsule
2023-12-14 15:04     ` Ninad Palsule

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2ddae2e4-de55-41a1-a93e-819f8d55dde6@linux.ibm.com \
    --to=ninad@linux.ibm.com \
    --cc=alexander.stein@ew.tq-group.com \
    --cc=andrew@codeconstruct.com.au \
    --cc=bhelgaas@google.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=conor@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@denx.de \
    --cc=geissonator@yahoo.com \
    --cc=gpiccoli@igalia.com \
    --cc=jarkko@kernel.org \
    --cc=jgg@ziepe.ca \
    --cc=joel@jms.id.au \
    --cc=johannes.holland@infineon.com \
    --cc=keescook@chromium.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lakshmiy@us.ibm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=naresh.solanki@9elements.com \
    --cc=patrick.rudolph@9elements.com \
    --cc=peterhuewe@gmx.de \
    --cc=peteryin.openbmc@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=tony.luck@intel.com \
    --cc=vincent@vtremblay.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).