From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 35E18C48BC4 for ; Thu, 15 Feb 2024 13:33:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:Reply-To:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:Subject: From:MIME-Version:Date:Message-ID:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gbt7tVGoLdZ6nJW+mvFFP4EJ0etyHSjRUgYs4IGPYN8=; b=lYnCnd951mSE+KkK03ctq5R/DV soPd08QwCbUSxS5NvtBMuMjLjmSBuHgZGWJ2nNgiMHNasNwoxPDJeMZD/SqHOFHNJG+YhmGaoIdXV rSgcx0xIzkiaRc95t5TybE/ZDoUpjWgZVQC8NrFhAlZo/Za37+5X9/XAFGotTVRZyo67zyabymmQf I0D6ljEEIWW2N5vH7BljUW7A/ZmZrTEhZHQoSZokyMstjXwg/VkGMTIOcRAFCKf5LAzRI+9b15npx yZxfef12wiRB4BND3CmJf2bEmiZ7o/8STtsQs6a362oFjUjgj/ARpaufaEbz9Zqdu29ZT3gPUJ1Nl ad5lG89g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rabrW-0000000GOq1-1Ffc; Thu, 15 Feb 2024 13:33:14 +0000 Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rabrT-0000000GOoD-14ZL for linux-arm-kernel@lists.infradead.org; Thu, 15 Feb 2024 13:33:12 +0000 Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-a26fa294e56so130223766b.0 for ; Thu, 15 Feb 2024 05:33:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708003989; x=1708608789; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :references:cc:to:content-language:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=z8FccHgP1nlIIDxh3beS9dJmKPci7aq2sL05JU739TA=; b=xO79KU8uK2fEsYNFhDg0yq+mdcp1Oods0bNSPNuk4sfya+eCu4DG0SwqVv0UVVkHgx PkemgkfdFBj6sgrJzTXdRIAyOn/0bVH0te5gciLJbF/QgWjNMQk5+aaDP0rFDe6X7Hky dYjnQgP1hIzST2Y8POMr9oQNhfsdEOPhjydoCi95v/vbWvyaq2rpVKB7B3HMNkXJQlnV 4T0XHValM/5u7N0wj3KxytfbFGoFandc5GkV5z0m6pfzKQPiu5p6L9FRYJRFfdLMhjFW ZDr7UQClzDqDdPOkkPsDACS7ga1j+BIy/GyXRu8Xfa6nJe72a2BcpxgNXmNMDKLkGaMO 4DYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708003989; x=1708608789; h=content-transfer-encoding:in-reply-to:organization:autocrypt :references:cc:to:content-language:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=z8FccHgP1nlIIDxh3beS9dJmKPci7aq2sL05JU739TA=; b=Y7LpWTESkQWWqVKl3KMGSTdrSJo6BkzILmJ9YhGZJ2LxyOqygIUP8JWUO5PKkQqYpB vqV4B3kdEGVHBSB8eN3/JTxCr0WvKcYjjI728HUM5aLguC/GQ8V4Yp1YneW4K2/pGSoR z1wOWubJaTdxkzPxOAm3IuQqbGaFjobtCr4JqlRTYUY6RiH9gI3JDrRNPpFIFxzp7jI8 gN3FgnbjSFNGePdiPFA8t9r11xa/Cts5rI5GqFAWnk0/aVF05P7E4dF0tnGY+UaqaKCI DMH1TTQ+ttyw9M/1QN8oiAq4+ezuaPfg93UcQ6Eiib3+T44xt5WrBJikpPRchtEIvkir i5yQ== X-Forwarded-Encrypted: i=1; AJvYcCWumJ4jIytXeChNFgmb4RHhKPgAahYFiW1MY2nITyTKdztC+sAKV+3+juOP3dXpsE7Z+CWu13LqICLqk94TioYXN31N6najFKU6iX2aZhqwcub7eD8= X-Gm-Message-State: AOJu0Yw3Ew/HzVJFHlIptphvCoF/0B0dgIsaaIOHgnNKziLI5bdd8ToZ HBBLneFP3NaCUjQVEdUS8IBbZoX+GObQohDS4d7DErP2dTjPPeh0t/fbD4zhiI8= X-Google-Smtp-Source: AGHT+IGXQY2xgSKFPhczZZiTjQ6N1O0RfsfU58vW/70tHk+S+ZXTkDOKRyUr+Bk5Kzb8qmDDxFFdTA== X-Received: by 2002:a17:906:1c8d:b0:a3d:16dd:307c with SMTP id g13-20020a1709061c8d00b00a3d16dd307cmr1498463ejh.5.1708003989366; Thu, 15 Feb 2024 05:33:09 -0800 (PST) Received: from ?IPV6:2a01:e0a:982:cbb0:7555:8187:c6f1:9c02? ([2a01:e0a:982:cbb0:7555:8187:c6f1:9c02]) by smtp.gmail.com with ESMTPSA id oq25-20020a170906cc9900b00a3cd41b3c19sm541532ejb.199.2024.02.15.05.33.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Feb 2024 05:33:08 -0800 (PST) Message-ID: <2df69499-4ffa-46a9-8e7f-041e87ad3034@linaro.org> Date: Thu, 15 Feb 2024 14:33:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: neil.armstrong@linaro.org Subject: Re: [PATCH v2 2/6] dt-bindings: arm-smmu: Document SM8650 GPU SMMU Content-Language: en-US, fr To: Dmitry Baryshkov Cc: Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Will Deacon , Robin Murphy , Joerg Roedel , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev References: <20240215-topic-sm8650-gpu-v2-0-6be0b4bf2e09@linaro.org> <20240215-topic-sm8650-gpu-v2-2-6be0b4bf2e09@linaro.org> Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro Developer Services In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240215_053311_333389_AAFA61FB X-CRM114-Status: GOOD ( 16.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: neil.armstrong@linaro.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 15/02/2024 10:32, Dmitry Baryshkov wrote: > On Thu, 15 Feb 2024 at 11:29, Neil Armstrong wrote: >> >> On 15/02/2024 10:25, Dmitry Baryshkov wrote: >>> On Thu, 15 Feb 2024 at 11:20, Neil Armstrong wrote: >>>> >>>> Document the GPU SMMU found on the SM8650 platform. >>>> >>>> Signed-off-by: Neil Armstrong >>>> --- >>>> Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 7 +++++-- >>>> 1 file changed, 5 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >>>> index a4042ae24770..3ad5c850f3bf 100644 >>>> --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >>>> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >>>> @@ -93,6 +93,7 @@ properties: >>>> - qcom,sm8350-smmu-500 >>>> - qcom,sm8450-smmu-500 >>>> - qcom,sm8550-smmu-500 >>>> + - qcom,sm8650-smmu-500 >>>> - const: qcom,adreno-smmu >>>> - const: qcom,smmu-500 >>>> - const: arm,mmu-500 >>>> @@ -508,7 +509,10 @@ allOf: >>>> - if: >>>> properties: >>>> compatible: >>>> - const: qcom,sm8550-smmu-500 >>>> + contains: >>>> + enum: >>>> + - qcom,sm8550-smmu-500 >>>> + - qcom,sm8650-smmu-500 >>> >>> Doesn't this cause warnings for non-GPU SMMU on this platform? >> >> No because it doesn't add those to required, it simply allows clock the properties. > > Can we further constrain this branch so that it is applicable only to > the Adreno SMMUs (and enforce requirement)? And maybe constrain the > second if-branch so that it doesn't apply to the Adreno SMMUs? Indeed, it's done like that for the a6 gpu, I'll send a fix for that Neil > >> >>> >>>> then: >>>> properties: >>>> clock-names: >>>> @@ -544,7 +548,6 @@ allOf: >>>> - qcom,sdx65-smmu-500 >>>> - qcom,sm6350-smmu-500 >>>> - qcom,sm6375-smmu-500 >>>> - - qcom,sm8650-smmu-500 >>>> - qcom,x1e80100-smmu-500 >>>> then: >>>> properties: >>>> >>>> -- >>>> 2.34.1 >>>> >>> >>> >> > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel