From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 79B68CFB43F for ; Mon, 7 Oct 2024 15:02:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:CC:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BJ8Knk1OilaXvESuSFI3aU6RMgbAH9yejobycbQkYhg=; b=szmxm2Ob3mE8yYdP4saDTh/xrD mN0FChT/55I9hxw8Eqzvbtf/Hdt+Ihs0obZ8VIrMclsx2iIliJ/94AltBG0WVtBnIohrp/emku3Zg 5Vf2x0uDWcEDqpSWdb9eJPL7IUS5ld6BG/7/SdNFrKI8nuAz0eLdDIElz8BzrhrOdQyyba+nkD0u9 r2Dgtl1ivHbh9b1nApnvr4lOwG7md2aFbe74VoAU4z+gg1rTRwzSAWNSfcPocVmRues6yOGbu7pz8 yu7ZUTE7JgSMNkSKMZMT7q9UIvIS+/Ur5R4cs/gfV5NXZhX2H7SHIxECX2v0bd+4A0rzgXGn0H1pv 8aPZTDxg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sxpF4-00000002qPX-0TfO; Mon, 07 Oct 2024 15:01:46 +0000 Received: from mx07-00178001.pphosted.com ([185.132.182.106]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1sxpDX-00000002poE-0t0Y for linux-arm-kernel@lists.infradead.org; Mon, 07 Oct 2024 15:00:13 +0000 Received: from pps.filterd (m0369458.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 497BL5xg003601; Mon, 7 Oct 2024 16:59:53 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=selector1; bh= BJ8Knk1OilaXvESuSFI3aU6RMgbAH9yejobycbQkYhg=; b=faxNql5faKfAou6p EZ+UECY5U+KLZiBJtDX1R4fkCO+eRfv/PxOodhiM2F9+CfvRiHFNJltQrMyARQu+ GqXh/y0uf2LAAm0DYLsOOHKKH0nQE4/utct4UE5ErMfuEm5EO7A7DY1Sa2G7Wszh nsB72b33nxoXkKlgni+In0vQrPpTTIE98wO9PN392ts5YhC/FwIKtthF62DuNtjb RygPljlMDnOfnAsN7ncI/MNIhP2Woteuac0GIijAn1siZe8KcoTEnowX+yOOpbQ3 E5lVd8jG7FevDcGGtKMe6T4syzrH8i8QGIozLNvOsRQnQMJ5WeKBTnSdawgjdVqh 8Pl7bw== Received: from beta.dmz-ap.st.com (beta.dmz-ap.st.com [138.198.100.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 423f10pt0g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 07 Oct 2024 16:59:53 +0200 (MEST) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-ap.st.com (STMicroelectronics) with ESMTP id A773E40048; Mon, 7 Oct 2024 16:58:23 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 379592216F8; Mon, 7 Oct 2024 16:57:27 +0200 (CEST) Received: from [10.48.86.225] (10.48.86.225) by SHFDAG1NODE1.st.com (10.75.129.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.37; Mon, 7 Oct 2024 16:57:26 +0200 Message-ID: <2e1ee778-06b1-4cb3-b10a-6f5a97338d82@foss.st.com> Date: Mon, 7 Oct 2024 16:57:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] dt-bindings: rng: add st,stm32mp25-rng support To: Marek Vasut , Olivia Mackall , Herbert Xu , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin , Alexandre Torgue CC: =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Lionel Debieve , , , , , , Yang Yingliang References: <20241007132721.168428-1-gatien.chevallier@foss.st.com> <20241007132721.168428-2-gatien.chevallier@foss.st.com> Content-Language: en-US From: Gatien CHEVALLIER In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.48.86.225] X-ClientProxiedBy: SHFCAS1NODE2.st.com (10.75.129.73) To SHFDAG1NODE1.st.com (10.75.129.69) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241007_080011_778219_E02615AD X-CRM114-Status: GOOD ( 12.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/7/24 15:53, Marek Vasut wrote: > On 10/7/24 3:27 PM, Gatien Chevallier wrote: >> Add RNG STM32MP25x platforms compatible. Update the clock >> properties management to support all versions. >> >> Signed-off-by: Gatien Chevallier >> --- >>   .../devicetree/bindings/rng/st,stm32-rng.yaml | 41 +++++++++++++++++-- >>   1 file changed, 38 insertions(+), 3 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/rng/st,stm32-rng.yaml >> b/Documentation/devicetree/bindings/rng/st,stm32-rng.yaml >> index 340d01d481d1..c92ce92b6ac9 100644 >> --- a/Documentation/devicetree/bindings/rng/st,stm32-rng.yaml >> +++ b/Documentation/devicetree/bindings/rng/st,stm32-rng.yaml >> @@ -18,12 +18,19 @@ properties: >>       enum: >>         - st,stm32-rng >>         - st,stm32mp13-rng >> +      - st,stm32mp25-rng >>     reg: >>       maxItems: 1 >>     clocks: >> -    maxItems: 1 >> +    minItems: 1 >> +    maxItems: 2 >> + >> +  clock-names: >> +    items: >> +      - const: rng_clk >> +      - const: rng_hclk >>     resets: >>       maxItems: 1 >> @@ -57,15 +64,43 @@ allOf: >>         properties: >>           st,rng-lock-conf: false >> +  - if: >> +      properties: >> +        compatible: >> +          contains: >> +            enum: >> +              - st,stm32mp25-rng > Maybe this match should be inverted, it is likely the next generation of > stm32 will also use 2 input clock into the RNG block and it will be only > the legacy MP1 that uses one clock. Hi, sure, makes more sense, I'll change it for V2. Gatien