From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B2D3C2D0A3 for ; Thu, 12 Nov 2020 11:11:16 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1212A22201 for ; Thu, 12 Nov 2020 11:11:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Xb6qDLv8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1212A22201 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ox4O2252mZl8R0AFXhHqWcv6H4T+nWwEj7ftpzZWoz8=; b=Xb6qDLv8qCjaOksU4CS++jH0F qRDT9BreYi20yq63BUl8umfEP7/fm/b/DNKDS+L0detBX+i8uit9HsLapoeRmAJqWzB83su8cvwRU n9+uRSSPck5cSrATcgj9wEv2570rspUPivICYGSPOE9FOZ+YTaJp4thgHrUMHbxqNi4/UqNeprk+q NdH9upLXjaJgUdfWcwQWyg4PZag08d3tgPTt2HTGNW3N+Az7u64d6Nfq0g/JVApsg0gcmO7agBFP/ Sje7nmEdscbZFvTmA9/Uu9xS65jPkErN/2w6PLTiPzsIZliNJm6KsbZrpZMbh1TFprrxzQJAK6V61 1aO/yyx4Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kdAUM-00026F-QQ; Thu, 12 Nov 2020 11:10:02 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kdAUJ-00025F-4d for linux-arm-kernel@lists.infradead.org; Thu, 12 Nov 2020 11:10:00 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2CB4A139F; Thu, 12 Nov 2020 03:09:57 -0800 (PST) Received: from [10.57.23.123] (unknown [10.57.23.123]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E0F943F73C; Thu, 12 Nov 2020 03:09:55 -0800 (PST) Subject: Re: [RFC 02/11] coresight: etm-perf: Allow an event to use different sinks To: Linu Cherian References: <1605012309-24812-1-git-send-email-anshuman.khandual@arm.com> <1605012309-24812-3-git-send-email-anshuman.khandual@arm.com> <67e0864f-e025-aa08-d1b7-36cf19629197@arm.com> From: Suzuki K Poulose Message-ID: <2e51db24-5d37-7f3f-c306-adde5fbe0dff@arm.com> Date: Thu, 12 Nov 2020 11:09:49 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201112_060959_318365_9BA327AD X-CRM114-Status: GOOD ( 18.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mathieu Poirier , Anshuman Khandual , Coresight ML , linux-kernel@vger.kernel.org, Linu Cherian , linux-arm-kernel , Mike Leach Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/12/20 10:37 AM, Linu Cherian wrote: > Hi Suzuki, > > On Thu, Nov 12, 2020 at 2:51 PM Suzuki K Poulose wrote: >> >> Hi Linu, >> >> Please could you test this slightly modified version and give us >> a Tested-by tag if you are happy with the results ? >> >> Suzuki >> >> >> On 11/10/20 12:45 PM, Anshuman Khandual wrote: >>> From: Suzuki K Poulose >>> >>> When there are multiple sinks on the system, in the absence >>> of a specified sink, it is quite possible that a default sink >>> for an ETM could be different from that of another ETM. However >>> we do not support having multiple sinks for an event yet. This >>> patch allows the event to use the default sinks on the ETMs >>> where they are scheduled as long as the sinks are of the same >>> type. >>> >>> e.g, if we have 1x1 topology with per-CPU ETRs, the event can >>> use the per-CPU ETR for the session. However, if the sinks >>> are of different type, e.g TMC-ETR on one and a custom sink >>> on another, the event will only trace on the first detected >>> sink. >>> >>> Signed-off-by: Suzuki K Poulose >>> Signed-off-by: Anshuman Khandual >>> --- >>> @@ -284,7 +307,12 @@ static void *etm_setup_aux(struct perf_event *event, void **pages, >>> if (!sink_ops(sink)->alloc_buffer || !sink_ops(sink)->free_buffer) >>> goto err; >>> >>> - /* Allocate the sink buffer for this session */ >>> + /* >>> + * Allocate the sink buffer for this session. All the sinks >>> + * where this event can be scheduled are ensured to be of the >>> + * same type. Thus the same sink configuration is used by the >>> + * sinks. >>> + */ >>> event_data->snk_config = >>> sink_ops(sink)->alloc_buffer(sink, event, pages, >>> nr_pages, overwrite); >>> >> > > Perf record and report worked fine with this as well, with formatting > related opencsd hacks. > > Tested-by : Linu Cherian Thanks Linu, much appreciated. Suzuki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel