From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A5A29CDB482 for ; Fri, 13 Oct 2023 14:39:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=asBKcnQucRs1ZvGT/Fi4mx87AWV3XZlOX2vsP1Cp00M=; b=GKn6iuxaK1Hak1 vAylh5DAEV8Vo3pGRYKCQsI0AwH9eZdi3IzdBbNcgX1tLr8GrzbprbPoAbtUTuXIwiEsEBh4S11ah t+QbefvyLo4V4mTThOO03ZdV+H2nQh4dcnhIgd3GqEgk6yKZJ6xukoHJA2negiyr/1dc27bumbNij GVOgDO1+j+dn3JW4hoaR/aPdSgo/Ep+B7rVJIGvxgxDU14Y2xMJFktj7IYh1HDXpqE3qQPVRZv8zz UouSOk0awnauU9FO51Prz7e3I2sOdvYm4TmllBrSqVN53v1f8nOva6BP4KfqWBHVJzrjzD0HCXiC/ EwxtdBn+NSYqIvjOQjvQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qrJIj-003bcM-2D; Fri, 13 Oct 2023 14:38:05 +0000 Received: from mail-ot1-x32b.google.com ([2607:f8b0:4864:20::32b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qrJIa-003baw-2c for linux-arm-kernel@lists.infradead.org; Fri, 13 Oct 2023 14:38:01 +0000 Received: by mail-ot1-x32b.google.com with SMTP id 46e09a7af769-6bf58009a8dso1362113a34.1 for ; Fri, 13 Oct 2023 07:37:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697207875; x=1697812675; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UbPsrJcoBy9BqlyOGafIHjglt8aQnlICvj5agohrEkI=; b=IzxxA9YCVDGIkMjrPpaMt7AvrqAWCiLyFpJntL6hsKv+BoneyB5zIfwUwinob6vxid 4gURU/Rf2DhyZRSAJJKxoZYkb+v4Aikc+pYG0H+q7jM5C7YhPTtQgkOUdU4PIJFgRfyI cUnlnlO8HZF1gPQvk54koEOHoDQ9Yph7oiamRgNnJLWj3hPdLwfD9FprZ/PUeh+pa/WK UvcZhbJnG0ypgHzvEsB/PErlscWvetdvmVvhFsdziWxkdpWwbiTtSo/haCND3vxO17cq oVjsnMqlXT9HpdN7thCkTE7EqWNbrkZGcZ7LAjZhtW6Av5K1jA8cLVPgmBWQnTueCg4b E5iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697207875; x=1697812675; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UbPsrJcoBy9BqlyOGafIHjglt8aQnlICvj5agohrEkI=; b=YK2gyG1rz6uWcGUsqV83mtGvSa9zS1SWaFWtQMs29gMOM8FyNS7xlqL2378RlxoaKz DEp6DUYf5cPjusvy9De4eXqY1RGztu5NF2iaDBrcMdlWPYgoDvB7tgqkymufJI0AKDDU P6ZKMyjisYX44qeqgWzzIPUy7POeGcb89X9OzPlSWT+17poXnI4FRqOvPIfkwQihVY6l nxwBLMzMVJi2xnjcZCM1ckx4z8OMtPmvAoQVJxycGTMZ7zvfk73jjXO5Juo3lyXVz6ic b5uKtQZbh+6IqvUarM650v0m82bmfYhnaUoZWJMEaRFnsrQnCUU3XsQXzveI3lOPdf4W gZhA== X-Gm-Message-State: AOJu0YwWoAmnnErDY8lcaBr0bVKq+z1v/GvSQ320AnZ5VY/N68h8zDnU /X3ShZYo2VhMVMI/ZW6JAwg= X-Google-Smtp-Source: AGHT+IFfm+l7CiPc096l3so6sYjYDqpMw8wulF9kO9eG3vYQ6hHQHV4GyWqRQmtsxauxwFJ4npblNw== X-Received: by 2002:a05:6830:18f8:b0:6c4:e81f:59b8 with SMTP id d24-20020a05683018f800b006c4e81f59b8mr27317088otf.22.1697207874959; Fri, 13 Oct 2023 07:37:54 -0700 (PDT) Received: from [172.16.49.130] (cpe-70-114-247-242.austin.res.rr.com. [70.114.247.242]) by smtp.googlemail.com with ESMTPSA id t26-20020a05683014da00b006c4d56392f4sm684143otq.24.2023.10.13.07.37.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Oct 2023 07:37:54 -0700 (PDT) Message-ID: <2e52c8b4-e70a-453f-853a-1962c8167dfa@gmail.com> Date: Fri, 13 Oct 2023 09:37:52 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] crypto: remove md4 driver Content-Language: en-US To: Herbert Xu , Dimitri John Ledkov Cc: "David S. Miller" , Maxime Coquelin , Alexandre Torgue , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, James Prestwood , Marcel Holtmann References: <20231008040140.1647892-1-dimitri.ledkov@canonical.com> From: Denis Kenzior In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231013_073756_845279_92A347D3 X-CRM114-Status: GOOD ( 12.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Herbert, On 10/13/23 05:39, Herbert Xu wrote: > On Sun, Oct 08, 2023 at 05:01:39AM +0100, Dimitri John Ledkov wrote: >> No internal users left and cryptographically insecure. Users should >> upgrade to something else, e.g. sha256 blake3. >> >> Some drivers have their own full or partial md4 implementation without >> using crypto/md4. >> >> Userspace code search indicates a few copies of hash_info.h >> https://codesearch.debian.net/search?q=HASH_ALGO_MD4&literal=1 without >> need for MD4. >> >> Preserve uapi hash algorithm indexes and array length, but rename the >> MD4 enum. >> >> Signed-off-by: Dimitri John Ledkov >> --- >> crypto/Kconfig | 6 - >> crypto/Makefile | 1 - >> crypto/hash_info.c | 4 +- >> crypto/md4.c | 241 --------------------------------- >> crypto/tcrypt.c | 12 -- >> crypto/testmgr.c | 6 - >> crypto/testmgr.h | 42 ------ >> include/uapi/linux/hash_info.h | 2 +- >> 8 files changed, 3 insertions(+), 311 deletions(-) >> delete mode 100644 crypto/md4.c > > Patch applied. Thanks. Does this patch break userspace? Here's a thread regarding MD4 the last time its removal was attempted: https://lore.kernel.org/linux-crypto/20210818144617.110061-1-ardb@kernel.org/ Please note that iwd does use MD4 hashes here: https://git.kernel.org/pub/scm/libs/ell/ell.git/tree/ell/checksum.c#n63 https://git.kernel.org/pub/scm/network/wireless/iwd.git/tree/src/eap-mschapv2.c#n165 Regards, -Denis _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel