From: Iuliana Prodan <iuliana.prodan@nxp.com>
To: "S.J. Wang" <shengjiu.wang@nxp.com>,
"Iuliana Prodan (OSS)" <iuliana.prodan@oss.nxp.com>,
Bjorn Andersson <andersson@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
SOF-Team <sof-team@msteams.nxp.com>,
MPU AUDIOSW-AUDIOSW <Mpuaudiosw@nxp.com>
Cc: dl-linux-imx <linux-imx@nxp.com>,
"linux-remoteproc@vger.kernel.org"
<linux-remoteproc@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Pengutronix Kernel Team <kernel@pengutronix.de>
Subject: Re: [PATCH] remoteproc: imx_dsp_rproc: add module parameter to ignore ready flag from remote processor
Date: Tue, 17 Jan 2023 11:09:16 +0200 [thread overview]
Message-ID: <2e594495-0eaa-6580-17eb-16f5db76865d@nxp.com> (raw)
In-Reply-To: <DB9PR04MB935597568D763916CA4ECA13E3C69@DB9PR04MB9355.eurprd04.prod.outlook.com>
On 1/17/2023 9:36 AM, S.J. Wang wrote:
>> There are cases when we want to test a simple "hello world"
>> application on the DSP and we don't have IPC between the cores.
>> Therefore, skip the wait for remote processor to start.
>>
>> Added "ignoreready" flag while inserting the module to ignore remote
>> processor reply after start.
>> By default, this is off - do not ignore reply from rproc.
>>
>> Signed-off-by: Iuliana Prodan <iuliana.prodan@nxp.com>
>> ---
>> drivers/remoteproc/imx_dsp_rproc.c | 17 +++++++++++++++++
>> 1 file changed, 17 insertions(+)
>>
>> diff --git a/drivers/remoteproc/imx_dsp_rproc.c
>> b/drivers/remoteproc/imx_dsp_rproc.c
>> index 95da1cbefacf..ec298f8b019f 100644
>> --- a/drivers/remoteproc/imx_dsp_rproc.c
>> +++ b/drivers/remoteproc/imx_dsp_rproc.c
>> @@ -26,9 +26,20 @@
>> #include "remoteproc_elf_helpers.h"
>> #include "remoteproc_internal.h"
>>
>> +#define IMX_DSP_IGNORE_REMOTE_READY 0
>> +
>> +/*
>> + * Module parameters
>> + */
>> +static unsigned int imx_dsp_rproc_ignoreready =
>> +IMX_DSP_IGNORE_REMOTE_READY; module_param_named(ignoreready,
>> +imx_dsp_rproc_ignoreready, int, 0644); MODULE_PARM_DESC(ignoreready,
>> + "Ignore remote proc reply after start, default is 0 (off).");
>> +
>> #define DSP_RPROC_CLK_MAX 5
>>
>> #define REMOTE_IS_READY BIT(0)
>> +#define REMOTE_SKIP_WAIT BIT(31)
> Can we use a close bit with REMOTE_IS_READY, like BIT(1)?
Sure, I'll send a v2.
Thanks,
Iulia
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-01-17 9:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 22:53 [PATCH] remoteproc: imx_dsp_rproc: add module parameter to ignore ready flag from remote processor Iuliana Prodan (OSS)
2023-01-17 7:36 ` S.J. Wang
2023-01-17 9:09 ` Iuliana Prodan [this message]
2023-01-17 9:28 ` Daniel Baluta
2023-01-17 11:05 ` Iuliana Prodan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e594495-0eaa-6580-17eb-16f5db76865d@nxp.com \
--to=iuliana.prodan@nxp.com \
--cc=Mpuaudiosw@nxp.com \
--cc=andersson@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=festevam@gmail.com \
--cc=iuliana.prodan@oss.nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shengjiu.wang@nxp.com \
--cc=sof-team@msteams.nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox