Re: [PATCH v6 2/4] thermal: qoriq: add i.MX93 tmu support

[Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>]

On 4/30/26 04:53, Jacky Bai wrote:
> For Thermal monitor unit(TMU) used on i.MX93, the HW revision info read
> from the ID register is the same the one used on some of the QorIQ
> platform, but the config has some slight differance. Add i.MX93 compatible
> string and corresponding code for it.
> 
> Signed-off-by: Alice Guo <alice.guo@nxp.com>
> Reviewed-by: Frank Li <Frank.Li@nxp.com>
> Signed-off-by: Jacky Bai <ping.bai@nxp.com>
> ---

[ ... ]

> +	data->drvdata = of_device_get_match_data(&pdev->dev);
> +	if (!data->drvdata)
> +		return dev_err_probe(dev, -EINVAL, "Failed to get match data\n");

I'm not sure testing the return value is something very accurate because 
it is like the code is testing itself as everything is self-encapsulated 
in the driver.

> +

[ ... ]

>   static const struct of_device_id qoriq_tmu_match[] = {
> -	{ .compatible = "fsl,qoriq-tmu", },
> -	{ .compatible = "fsl,imx8mq-tmu", },
> +	{ .compatible = "fsl,qoriq-tmu", .data = &qoriq_tmu_data },
> +	{ .compatible = "fsl,imx8mq-tmu", .data = &imx8mq_tmu_data },
> +	{ .compatible = "fsl,imx93-tmu", .data = &imx93_data },
>   	{},
>   };
>   MODULE_DEVICE_TABLE(of, qoriq_tmu_match);