From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 185F1CED273 for ; Tue, 8 Oct 2024 07:06:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Zl37Y91oO+8z1/qTktKLwFztniusr05Po5+KGzWrEPk=; b=FiOwvv7IrxjNNH/h6LVt/jOXxh JMu6AfEzvkSi47IfdVInl8/GWZHuiZe1jj+MYwM7CI+TLUp6NXZsMI6ON9MWUDd/5DoEMafjly8/f yoEkWaNMzxe3LBGyX0U2U0ah2ODQ7CFDF2L5wqqpK2X7NB+A/3eU8ETJ0u2UiVcJOGQ/vdBj7aFfo fm3OK9AclAkOsJpTC+RJMyRfIr0r9Yzh1IBIZW4fkcdN1hWiuKSiMo8wM8y3h6mfBQRNpvdFF/5h5 5vFJ1Emkd0JlqD5Mnox02mWjlFdZuNo4WIZ6hth1Vqnv+Mw2rPpkCFcUn3A8LijhlD9p6cTCS4w7g c+licKLA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sy4Ig-00000004kW5-1flS; Tue, 08 Oct 2024 07:06:30 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sy4Fm-00000004jnW-1r6w for linux-arm-kernel@lists.infradead.org; Tue, 08 Oct 2024 07:03:32 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 078F4DA7; Tue, 8 Oct 2024 00:03:57 -0700 (PDT) Received: from [10.163.38.160] (unknown [10.163.38.160]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BCA453F640; Tue, 8 Oct 2024 00:03:22 -0700 (PDT) Message-ID: <2e9e559e-82b3-4ba7-8316-a514abe9dd38@arm.com> Date: Tue, 8 Oct 2024 12:33:18 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC v2 1/2] binfmt_elf: Wire up AT_HWCAP3 at AT_HWCAP4 To: Mark Brown , Alexander Viro , Christian Brauner , Jan Kara , Eric Biederman , Kees Cook , Catalin Marinas , Will Deacon , Jonathan Corbet Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yury Khrustalev , Wilco Dijkstra , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org References: <20241004-arm64-elf-hwcap3-v2-0-799d1daad8b0@kernel.org> <20241004-arm64-elf-hwcap3-v2-1-799d1daad8b0@kernel.org> Content-Language: en-US From: Anshuman Khandual In-Reply-To: <20241004-arm64-elf-hwcap3-v2-1-799d1daad8b0@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241008_000330_572954_12037E20 X-CRM114-Status: GOOD ( 14.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/5/24 01:56, Mark Brown wrote: > AT_HWCAP3 and AT_HWCAP4 were recently defined for use on PowerPC in commit > 3281366a8e79 ("uapi/auxvec: Define AT_HWCAP3 and AT_HWCAP4 aux vector, > entries"). Since we want to start using AT_HWCAP3 on arm64 add support for > exposing both these new hwcaps via binfmt_elf. > > Signed-off-by: Mark Brown > --- > fs/binfmt_elf.c | 6 ++++++ > fs/binfmt_elf_fdpic.c | 6 ++++++ > fs/compat_binfmt_elf.c | 10 ++++++++++ > 3 files changed, 22 insertions(+) > > diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c > index 06dc4a57ba78a7939bbde96bf181eefa950ea13a..3039a6b7aba4bd38f26e21b626b579cc03f3a03e 100644 > --- a/fs/binfmt_elf.c > +++ b/fs/binfmt_elf.c > @@ -257,6 +257,12 @@ create_elf_tables(struct linux_binprm *bprm, const struct elfhdr *exec, > NEW_AUX_ENT(AT_RANDOM, (elf_addr_t)(unsigned long)u_rand_bytes); > #ifdef ELF_HWCAP2 > NEW_AUX_ENT(AT_HWCAP2, ELF_HWCAP2); > +#endif > +#ifdef ELF_HWCAP3 > + NEW_AUX_ENT(AT_HWCAP3, ELF_HWCAP3); > +#endif > +#ifdef ELF_HWCAP4 > + NEW_AUX_ENT(AT_HWCAP4, ELF_HWCAP4); > #endif > NEW_AUX_ENT(AT_EXECFN, bprm->exec); > if (k_platform) { > diff --git a/fs/binfmt_elf_fdpic.c b/fs/binfmt_elf_fdpic.c > index 4fe5bb9f1b1f5e0be6e8d1ef5b20492935b90633..31d253bd3961a8679678c600f4346bba23502598 100644 > --- a/fs/binfmt_elf_fdpic.c > +++ b/fs/binfmt_elf_fdpic.c > @@ -623,6 +623,12 @@ static int create_elf_fdpic_tables(struct linux_binprm *bprm, > NEW_AUX_ENT(AT_HWCAP, ELF_HWCAP); > #ifdef ELF_HWCAP2 > NEW_AUX_ENT(AT_HWCAP2, ELF_HWCAP2); > +#endif > +#ifdef ELF_HWCAP3 > + NEW_AUX_ENT(AT_HWCAP3, ELF_HWCAP3); > +#endif > +#ifdef ELF_HWCAP4 > + NEW_AUX_ENT(AT_HWCAP4, ELF_HWCAP4); > #endif > NEW_AUX_ENT(AT_PAGESZ, PAGE_SIZE); > NEW_AUX_ENT(AT_CLKTCK, CLOCKS_PER_SEC); > diff --git a/fs/compat_binfmt_elf.c b/fs/compat_binfmt_elf.c > index 8f0af4f626316ed2e92204ff9bf381cd14103ae9..d5ef5469e4e620f6ee97f40ce9cbbfa48e37e33c 100644 > --- a/fs/compat_binfmt_elf.c > +++ b/fs/compat_binfmt_elf.c > @@ -80,6 +80,16 @@ > #define ELF_HWCAP2 COMPAT_ELF_HWCAP2 > #endif > > +#ifdef COMPAT_ELF_HWCAP3 > +#undef ELF_HWCAP3 > +#define ELF_HWCAP3 COMPAT_ELF_HWCAP3 > +#endif > + > +#ifdef COMPAT_ELF_HWCAP4 > +#undef ELF_HWCAP4 > +#define ELF_HWCAP4 COMPAT_ELF_HWCAP4 > +#endif > + > #ifdef COMPAT_ARCH_DLINFO > #undef ARCH_DLINFO > #define ARCH_DLINFO COMPAT_ARCH_DLINFO > Reviewed-by: Anshuman Khandual