From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 83ED7C2BD09 for ; Tue, 25 Jun 2024 00:17:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZPulY/FFLXx2qRuEGoIYRBxFDaCi/EahkPsQ00jC1wI=; b=eSc+KTjAmghHhog5qyvui9Q1lD uOAE6BFgUszxuPK1WSq/Y1bdPT3VaMyV/CdpXbcNI/fEjHdJTtN1qWLTCbyI5pbilf8n/7nujoNb9 EpAIHCa0+stjkAwf898UHgODZv3/P66J3+vk4u7lc32eX/u0Fs6hKJUG9z6HROlKsze/RtBBp7Sw6 dN8epcc5GqmIx/mdESyfJdfmEbapcE71IYBXXqqIvuwrEw9eaxchWrRrUeJ9fPe2T/fLThr3XbpvW abhpZowizb5X2DYIZAyCQfhfvjFaK0E8HORhTjn0LMNG6M4lIsu9lM8+zSuzmtzGKmRK5Fme/Z/IE CiJ7HtYQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sLtrx-000000014ef-0bBX; Tue, 25 Jun 2024 00:17:09 +0000 Received: from mail-pg1-x534.google.com ([2607:f8b0:4864:20::534]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sLtrr-000000014c8-2uAo for linux-arm-kernel@lists.infradead.org; Tue, 25 Jun 2024 00:17:05 +0000 Received: by mail-pg1-x534.google.com with SMTP id 41be03b00d2f7-7182a634815so2223249a12.3 for ; Mon, 24 Jun 2024 17:16:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719274614; x=1719879414; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZPulY/FFLXx2qRuEGoIYRBxFDaCi/EahkPsQ00jC1wI=; b=PC9zPhoQEDfS/x3Aut/eHXBkFENw5V3YFFV5c87dAoN6+ZaKPoZLTRQQlDvTjK9P6K /4zstnDxAhs+Rty0jkisatafpVrREn0rFWtWH0KQe1h1ywQguJNRWv/Xbv6yyd07UOR/ 4VBMiRSDk6bemUfjijBHJ2twEEl4pWo0n5V+nGoM2KDOIXEljvGUxMcYZuq3DLOjFFWf 2e84y4b2sOP1quMpXI9cpTvPzvhxMyUrR6qyQuQduieF2yKluwHEUFhiiQ6s+UDVDWzu 8QTSHj0Vn0If3R62dXBh6xA5xX/1jkxauIVuez9nceEItQbm3w0HuwfG0ROzhPVVzbq6 SnsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719274614; x=1719879414; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZPulY/FFLXx2qRuEGoIYRBxFDaCi/EahkPsQ00jC1wI=; b=bY9Yd8oEjk62lvsPC4+4pRGqGFnNFBxV++UsPSNJM514MKG6MsW+pYEon3Xc2qJ1Ti T2aalAbUDn4FDPkQ0VgTjyBpWYvYiWa6GlLQa5fgb7B+3qo65JgiTCECBrAPh/b2k27T i2KaKw+EX4Slu/eBGeBZAzboB6NgiUlt1DM/3L/u0NHLfyAcqD07vFGqFiq2ZPpuSntC Js/GA3nQlKcBl0a9YKanZ+7PUm+VJfRGa0uTWoo3BSbRIf4H38tJ65XxKI+OB3mw113k EcnRAzcS2rmrLDTJKKtiNAoGQIL3q+2IZE+VMqesFEc+S2a99ueKe0zrdESGBrkEQUtG OunQ== X-Forwarded-Encrypted: i=1; AJvYcCXGq1NHUsGkfJgOwk6F1tlgUY44fDcAR23q54+hjLPsD0m+Un602jYniwLTHNHQ+SCl33yJZAaVkgvfqdkmwkcbproP5QNkhfKzJ83Py0SJrwFh438= X-Gm-Message-State: AOJu0Yz2ILXsPZDZM7rcT4+tgE3CDzw182vZEicpt8ipQc2PTIPwbJoQ w9M8xw8pjZiWWV+f3fL/QN1/5P4LezzG928R5qeVh7oySLT5bpCF X-Google-Smtp-Source: AGHT+IF9BMSkE/ux+AVW7JbiLQQPv8C6XRkzWf+ZclsqfrnQ8j5lIAMEMb2kreKQKUdDeFUgLD0t0g== X-Received: by 2002:a05:6a20:af19:b0:1b1:ed95:c9b1 with SMTP id adf61e73a8af0-1bcf7fc2cc4mr4822661637.40.1719274614054; Mon, 24 Jun 2024 17:16:54 -0700 (PDT) Received: from [172.19.1.47] (60-250-192-107.hinet-ip.hinet.net. [60.250.192.107]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f9eb3205e8sm68609215ad.68.2024.06.24.17.16.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Jun 2024 17:16:53 -0700 (PDT) Message-ID: <2ea41efa-2160-446f-9fb0-0df0ffdeab05@gmail.com> Date: Tue, 25 Jun 2024 08:16:50 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] tty: serial: ma35d1: Add a NULL check for of_node To: Greg KH Cc: dan.carpenter@linaro.org, jirislaby@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Jacky Huang References: <20240614054554.80-1-ychuang570808@gmail.com> <2024062404-avoid-grieving-a3fa@gregkh> Content-Language: en-US From: Jacky Huang In-Reply-To: <2024062404-avoid-grieving-a3fa@gregkh> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240624_171703_762037_5214DACE X-CRM114-Status: GOOD ( 12.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dear Greg, On 2024/6/24 下午 09:37, Greg KH wrote: > On Fri, Jun 14, 2024 at 05:45:54AM +0000, Jacky Huang wrote: >> From: Jacky Huang >> >> The pdev->dev.of_node can be NULL if the "serial" node is absent. >> Add a NULL check to return an error in such cases. >> >> Fixes: 930cbf92db01 ("tty: serial: Add Nuvoton ma35d1 serial driver support") >> Signed-off-by: Jacky Huang > You forgot a "Reported-by:" line as Dan did report this to you. > >> --- >> drivers/tty/serial/ma35d1_serial.c | 13 +++++++------ >> 1 file changed, 7 insertions(+), 6 deletions(-) > Also, no info as to what changed from v1 :( > > thanks, > > greg k-h I got it. I will add the "Reported-by:" line and version info to the v3 patch. Best Regards, Jacky Huang