From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,FROM_EXCESS_BASE64,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31B20C282CE for ; Tue, 9 Apr 2019 16:33:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0380E2084F for ; Tue, 9 Apr 2019 16:33:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IGF1E6Mz"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.b="XO9xNChp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0380E2084F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RzPlZ5t5ydWblMRYf6PX6YinRTDrgutmtrzJQm/+rxw=; b=IGF1E6MzE/mapv SVQj+Mw8qcDmnpmDyG+B2ax2l2i5+xjZd3jpQird+izULmoMEYHilgA+MlpjlrFpQwqqpOQ2lfIkc yEKv220KAF1CH7d935906mym8wbwB/19x4D8cO6iqn7lUpLZWQONgh20XMSPoqwwjPghMeu6y0qQc GuRKqTk5yEZKZZemzpmYpzwpKW09Lqb5Y+mNHRjRbhMXpwRlimpDsfVXv/tlEWuHiuJrPPOEAZfD5 tYHZR/p9twSpDadS3W71zNPq5891SDtBJT2abzO9p7nitnCpLTBAc74xqaOLY797bEoPDJ5OpuHKd ZudmFMNWEYMtCygDiuIA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDth1-0006s7-6U; Tue, 09 Apr 2019 16:33:51 +0000 Received: from mail-eopbgr150053.outbound.protection.outlook.com ([40.107.15.53] helo=EUR01-DB5-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDtgs-0006fq-OD for linux-arm-kernel@lists.infradead.org; Tue, 09 Apr 2019 16:33:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Az/K+onyhoxx2Ww4scP1ZCp3wMtn7Eh3EZqD+IZndfQ=; b=XO9xNChpAUyymRTmS9iUHO28/QqFF0CaxOUNswBm4+amVxCVAb6jfFGpjUhiQRY1qsa3Vyub1d/SwKEPB+gCr3MS2UR9X1/V1e9QXSw1uuIyq5JJIKRa0TKZkXBnHEy5LPwB4Fuhl0E/+KYNAtl099KHvsmFnjzlmPDLXp7v4gQ= Received: from DB7PR08MB3865.eurprd08.prod.outlook.com (20.178.84.149) by DB7PR08MB4601.eurprd08.prod.outlook.com (20.178.85.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1771.16; Tue, 9 Apr 2019 16:33:38 +0000 Received: from DB7PR08MB3865.eurprd08.prod.outlook.com ([fe80::e86b:208d:988e:119f]) by DB7PR08MB3865.eurprd08.prod.outlook.com ([fe80::e86b:208d:988e:119f%4]) with mapi id 15.20.1771.019; Tue, 9 Apr 2019 16:33:38 +0000 From: =?utf-8?B?UmFwaGHDq2wgR2F1bHQ=?= To: Julien Thierry , Mark Rutland , Peter Zijlstra Subject: Re: [RFC 3/6] objtool: arm64: Adapt the stack frame checks and the section analysis for the arm architecture Thread-Topic: [RFC 3/6] objtool: arm64: Adapt the stack frame checks and the section analysis for the arm architecture Thread-Index: AQHU7tulYY+OqZKg/k6QJwe1WY2Za6Y0ADkAgAADb4CAAAD3AIAAAaCA Date: Tue, 9 Apr 2019 16:33:38 +0000 Message-ID: <2ebce265-d544-4943-6ddb-3f4858aab6a4@arm.com> References: <20190409135243.12424-1-raphael.gault@arm.com> <20190409135243.12424-4-raphael.gault@arm.com> <20190409161204.GS11158@hirez.programming.kicks-ass.net> <20190409162420.GB32587@lakrids.cambridge.arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: LO2P265CA0058.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:60::22) To DB7PR08MB3865.eurprd08.prod.outlook.com (2603:10a6:10:32::21) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Raphael.Gault@arm.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [217.140.106.53] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: dc42cbcc-0537-4131-5907-08d6bd091e2f x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600139)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:DB7PR08MB4601; x-ms-traffictypediagnostic: DB7PR08MB4601: x-microsoft-antispam-prvs: x-forefront-prvs: 000227DA0C x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(346002)(136003)(396003)(366004)(39860400002)(40434004)(199004)(189003)(6512007)(102836004)(52116002)(97736004)(446003)(11346002)(6506007)(4326008)(2616005)(72206003)(476003)(31686004)(110136005)(76176011)(386003)(53546011)(486006)(256004)(106356001)(5024004)(14444005)(85202003)(71200400001)(186003)(105586002)(25786009)(54906003)(316002)(99286004)(26005)(71190400001)(53936002)(14454004)(81156014)(66066001)(229853002)(6116002)(3846002)(6436002)(31696002)(7736002)(5660300002)(81166006)(2906002)(6486002)(86362001)(478600001)(6246003)(93886005)(68736007)(36756003)(8676002)(8936002)(85182001)(305945005); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR08MB4601; H:DB7PR08MB3865.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: Ca4AU1PK/kmzlP5AogkbJO1AXPxXsA3fmB6E3jd9gyoQG/koc4K0hzPU91iFtqn/MXY3WPZRtQQeu4M2I7qx9bNvBTc54fePYxm4ZBlBS4j12EqbL1OjEeW63pipU7o7ooSvalQn8HwqTWgyoJuwWa0AV2Bh00lm3eqLrY1Eb6TXmV6pgNASXwS9X4jwfkPXHEJWheWyALlR1P85jSYK+ld4blKj0lvf3dT084w+y/vVKCo9iUqYfk2JDTaRHXGtysz00TUStrUhVYfd6hi8hx6w1ialevuzz38oj7gXI6yem6bN9ilYoUVNdHutu6Yh/VOgJU4FyO5uM4y2+MzhqLOldSCqSw0VYOmleon/FI4W+mFKQ+9XKK8zTNRuR3z6RDQ+GK0Nnt39oi2cF2V2giGt4kH9ufj6HPi1breg384= Content-ID: <8A4657ED86250246A95FEC4DD6E4B80D@eurprd08.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: dc42cbcc-0537-4131-5907-08d6bd091e2f X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Apr 2019 16:33:38.0340 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB4601 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190409_093343_122142_69E88FBE X-CRM114-Status: GOOD ( 15.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catalin Marinas , Will Deacon , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "jpoimboe@redhat.com" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On 4/9/19 5:27 PM, Julien Thierry wrote: > > > On 09/04/2019 17:24, Mark Rutland wrote: >> On Tue, Apr 09, 2019 at 06:12:04PM +0200, Peter Zijlstra wrote: >>> >>> I'm just doing my initial read-through,.. however >>> >>> On Tue, Apr 09, 2019 at 02:52:40PM +0100, Raphael Gault wrote: >>>> +if (!(sec->sh.sh_flags & SHF_EXECINSTR) >>>> +&& (strcmp(sec->name, ".altinstr_replacement") || !IGNORE_SHF_EXEC_FLAG)) >>>> continue; >>> >>> could you please not format code like that. Operators go at the end of >>> the line, and continuation should match the indentation of the opening >>> paren. So the above would look like: >>> >>>> +if (!(sec->sh.sh_flags & SHF_EXECINSTR) && >>>> + (strcmp(sec->name, ".altinstr_replacement") || !IGNORE_SHF_EXEC_FLAG)) >>>> continue; >>> >>> You appear to be doing that quit consistently, and it is against style. Thank you for these remarks, I will correct this! >> >> Raphael, as a heads-up, ./scripts/checkpatch.pl can catch issues like >> this. You can run it over a list of patches, so for a patch series you >> can run: >> >> $ ./scripts/checkpatch.pl *.patch >> >> ... and hopefully most of the output will be reasonable. >> > > For this particular case, checkpatch only warns about it if you pass it > "--strict" option. So in general it might be useful to include this > option at least for the first pass at including large pieces of code. > Indeed that sounds usefull, thanks, > Cheers, > Cheers, -- Raphael Gault IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel