From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DDDEACA101F for ; Fri, 12 Sep 2025 16:02:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=O4AijFM310ZNNUP//uVrl2uWtXPbvXEcuvzwcffIPac=; b=FRPdPQ8qEDAjS1cARY7epCLG4M 3d2IwkCNiIegt5EojbXR1Wrko9MRzqElcjpX3vs0dMqXfYE4vXBcTJBqimdtRaD+LAxdvlRfQXhTp PB6fISnVO50RQKUPERS02x8sPhHA0TFPwFujcxWJaIFLzbbQaAx0ePP0e24wqGAe0tToR2P24jEzx pcapwc23GfAtU8ostEiFhDrFKtR7uhIEf2oc+0W7SoYn5VTaquZBMXbkBggOsBP8IGX8e1IjIikmi tMZ+1WycUsDF2vsJODtbtSKyAkJOIj+ZXqMuN+QSWB565tW0IR6EhzURpUD/iFOJ4lOLGIkBTbtsu bqHa4+Lw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1ux6Dt-0000000AQsU-1Be1; Fri, 12 Sep 2025 16:02:05 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1ux6Dq-0000000AQqu-3zFE for linux-arm-kernel@lists.infradead.org; Fri, 12 Sep 2025 16:02:04 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 801991515; Fri, 12 Sep 2025 09:01:53 -0700 (PDT) Received: from [10.1.196.46] (e134344.arm.com [10.1.196.46]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AD4933F66E; Fri, 12 Sep 2025 09:01:56 -0700 (PDT) Message-ID: <2ed1be84-5097-488d-b8ce-7abebf5b9a7e@arm.com> Date: Fri, 12 Sep 2025 17:01:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 29/29] arm_mpam: Add kunit tests for props_mismatch() To: James Morse , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org Cc: D Scott Phillips OS , carl@os.amperecomputing.com, lcherian@marvell.com, bobo.shaobowang@huawei.com, tan.shaopeng@fujitsu.com, baolin.wang@linux.alibaba.com, Jamie Iles , Xin Hao , peternewman@google.com, dfustini@baylibre.com, amitsinght@marvell.com, David Hildenbrand , Dave Martin , Koba Ko , Shanker Donthineni , fenghuay@nvidia.com, baisheng.gao@unisoc.com, Jonathan Cameron , Rob Herring , Rohit Mathew , Rafael Wysocki , Len Brown , Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , Catalin Marinas , Will Deacon , Greg Kroah-Hartman , Danilo Krummrich References: <20250910204309.20751-1-james.morse@arm.com> <20250910204309.20751-30-james.morse@arm.com> From: Ben Horgan Content-Language: en-US In-Reply-To: <20250910204309.20751-30-james.morse@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250912_090203_038367_34799AA3 X-CRM114-Status: GOOD ( 13.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi James, On 9/10/25 21:43, James Morse wrote: > When features are mismatched between MSC the way features are combined > to the class determines whether resctrl can support this SoC. > > Add some tests to illustrate the sort of thing that is expected to > work, and those that must be removed. > > Signed-off-by: James Morse > --- > Changes since v1: > * Waggled some words in comments. > * Moved a bunch of variables to be global - shuts up a compiler warning. > --- > drivers/resctrl/mpam_internal.h | 8 +- > drivers/resctrl/test_mpam_devices.c | 321 ++++++++++++++++++++++++++++ > 2 files changed, 328 insertions(+), 1 deletion(-) > Looks good to me, I checked the tests for v1. I agree with Jonathan that you could make RESET_FAKE_HIEARCHY() a function now that you've changed to use globals. Reviewed-by: Ben Horgan Thanks, Ben