From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFB8AC433B4 for ; Thu, 8 Apr 2021 16:46:26 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 53263610D1 for ; Thu, 8 Apr 2021 16:46:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 53263610D1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PZQin5tTDX4K4feSRwnQlaMFb6ekGfwUELsCLTMSZp0=; b=W3zanjIhX5ttrVxld4d5W2b+c K+f4K867VJNyazxGXlmd+eSr/pmO2QQw65wuNN/hdtkqufz6lRHpKRK8wWjBVOmyQGDtV38BnqaG+ TvtkwzvykyIBiH+bqrTNQ0LgFK5MJnJe3AJQQ18uDsgd2uyX2UGAMFRX2Wl/352hqQKGa2EKkBRFh 0kb/1CbItrvmYXNfixeVXzNVd8kYR0QEiY9mdIsOmg3rg9MP4S4MV78arcUQo877hoXX8Pb00XG3V rtIqji2u5IM8ctU3j9CdIkJe2C9bpv7qrc7vZEWiqD0jUkPlk0sAvMvoLIK/cCX/W8JUgBRDQuIPS yF71+TKMA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lUXlt-008flX-Mj; Thu, 08 Apr 2021 16:44:45 +0000 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lUXlq-008fkI-17 for linux-arm-kernel@lists.infradead.org; Thu, 08 Apr 2021 16:44:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617900278; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VfhnCQAyCfEthQPScFLk5+XhVK1UjdBG138qICZvuow=; b=ar0/Ev9C0RCZwi438X39cNfOMLl1aBxWyLAyi6OyKjc/zmU21i8LPN6N//W+yq4FJzONLH 4bNCvaseHH+G98bKUZPu2XxiX4jNnubPWEEZJnpEkiC2wbd0vRl6off2h9mF0ecii+Kn54 wndNFJqgSqM1p/J1PSyOJyr7ZUDhsiY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-153-x1HZ9uJoOgSGPofB8dKw8A-1; Thu, 08 Apr 2021 12:44:34 -0400 X-MC-Unique: x1HZ9uJoOgSGPofB8dKw8A-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DA2FB801814; Thu, 8 Apr 2021 16:44:30 +0000 (UTC) Received: from [10.36.113.26] (ovpn-113-26.ams2.redhat.com [10.36.113.26]) by smtp.corp.redhat.com (Postfix) with ESMTP id 63A0A60636; Thu, 8 Apr 2021 16:44:24 +0000 (UTC) Subject: Re: [PATCH v1 2/2] drivers/gpu/drm: don't select DMA_CMA or CMA from aspeed or etnaviv To: Linus Walleij Cc: Arnd Bergmann , Linux Kernel Mailing List , Linux-MM , Joel Stanley , David Airlie , Daniel Vetter , Andrew Jeffery , Lucas Stach , Russell King , Christian Gmeiner , Mike Rapoport , Bartlomiej Zolnierkiewicz , Michal Simek , Masahiro Yamada , Randy Dunlap , Peter Collingbourne , linux-aspeed , dri-devel , Linux ARM , The etnaviv authors , Linux Fbdev development list References: <20210408092011.52763-1-david@redhat.com> <20210408092011.52763-3-david@redhat.com> <7496ac87-9676-1b4e-3444-c2a662ec376b@redhat.com> <3a2d64a7-8425-8daf-17ee-95b9f0c635f9@redhat.com> From: David Hildenbrand Organization: Red Hat GmbH Message-ID: <2ef3b65c-c0ef-7bbe-0e05-39ee8f2bae48@redhat.com> Date: Thu, 8 Apr 2021 18:44:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210408_174442_265960_7D4F1FF7 X-CRM114-Status: GOOD ( 22.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 08.04.21 14:49, Linus Walleij wrote: > On Thu, Apr 8, 2021 at 2:01 PM David Hildenbrand wrote: > >>> This is something you could do using a hidden helper symbol like >>> >>> config DRMA_ASPEED_GFX >>> bool "Aspeed display driver" >>> select DRM_WANT_CMA >>> >>> config DRM_WANT_CMA >>> bool >>> help >>> Select this from any driver that benefits from CMA being enabled >>> >>> config DMA_CMA >>> bool "Use CMA helpers for DRM" >>> default DRM_WANT_CMA >>> >>> Arnd >>> >> >> That's precisely what I had first, with an additional "WANT_CMA" -- but >> looking at the number of such existing options (I was able to spot 1 !) > > If you do this it probably makes sense to fix a few other drivers > Kconfig in the process. It's not just a problem with your driver. > "my" drivers: > :) I actually wanted to convert them to "depends on DMA_CMA" but ran into recursive dependencies ... > drivers/gpu/drm/mcde/Kconfig > drivers/gpu/drm/pl111/Kconfig > drivers/gpu/drm/tve200/Kconfig I was assuming these are "real" dependencies. Will it also work without DMA_CMA? > > certainly needs this as well, and pretty much anything that is > selecting DRM_KMS_CMA_HELPER or > DRM_GEM_CMA_HELPER "wants" DMA_CMA. "wants" as in "desires to use but can life without" or "wants" as in "really needs it". ? -- Thanks, David / dhildenb _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel