From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C29D4C433EF for ; Mon, 27 Jun 2022 10:34:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Js8GPjQNyKCN6rIH+1T63oktDvefLbDfEC2av96x1jI=; b=p4f0SwFJDQT86Y E6TAtxlA2pCMLR/yGwpxsNpw5c8g2nTCr1Qn2qSxzdATXgzPpLJUMHJLji5v9QL4BTr9898XkeBtM dn+BYQNjx9kYHk5P7frOLsCfUoTbsLObsjfz2GGP7VkA/ELXy6iM0k97d0lBcXOm1s+F4bRMk0rgY v8r7vfHJly8hQRqsJ9dvQGxYDgif1TsmBTI1sxX8U6vpJeYz56fyGN49W8t2Ym/dpjJaHm1jIEbzo R2oLS4NxWs8AEmzHLWX1CRw4CZCL/ZDdMJSDdZYiuLBmSMSv0VCe5HBI0+WLU8+iTjLNC/oOTqhh1 EGreeUxJzT/XmldTmZYw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o5m47-0008oL-GD; Mon, 27 Jun 2022 10:33:59 +0000 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o5m42-0008mB-Mt for linux-arm-kernel@lists.infradead.org; Mon, 27 Jun 2022 10:33:56 +0000 Received: by mail-wr1-x435.google.com with SMTP id o4so8432748wrh.3 for ; Mon, 27 Jun 2022 03:33:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=Fu4PRWXrnet8l+Wzlc9u5ZP+FAA0ZHxV8ImVTD46fu4=; b=v4ZXKOx56aXRHkRYD+3x19r45JbK0YB5ZD6H6BW7wTKUW7Jmb0uEWElqEXZpNcm+Mc PqsE+9O2TIYI38NY1HFnw5toFCep++jR44ayUMC9rUEU6w/lingU/+iahFPk+/8CZgAx 1FiefvUiwks8IlnPzSXvNk4706pFoTlwUAx3zDoAOjLhLLhBWQpq92dOmCWsLCMIijTa qn0nZ0PIHB0LznFuoZsTIDmiVQx+9/ivpBhy49cQL0K2moY63HVy0RPGNwu4fZwBBgOh fI77xGIINwf5yBMK1iA4RZknY0WzwDhWOGjH/0/RqUPANuNzPLSlYm2qiRdJKp0IPbJg 2dCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Fu4PRWXrnet8l+Wzlc9u5ZP+FAA0ZHxV8ImVTD46fu4=; b=rFbxdY0jjrc/BfFjBqFganbh4RwvmLMmwh4Bh0cN3pryqfS8qSljFcMOXYcWO3JqtN W0DGgEs/XG2H6sPhqa+/VBS8nhQMTdsbOVEezT0fhaeex/Izh9dEA9DDbcI4WkT369rL gGuPnghPXBzLTDlFa/pa2WzluwnLLQ093hikcbgKCpEIct/nlQDRiJwuIvVKCUyl7C4b QaLdEDkIDgkJnmjDx+BnhkEBrzqYyHoaMczrsrUFc6QAsbVrOgyVXT3MS5do/QTmAQJM qssSL5+epVcpT/dRS0VZTHBiBQpOc55lXqvT/zu5M7Z+pcobkw9bLYkQ0omt2NhKKKzs GuLg== X-Gm-Message-State: AJIora/O80qeENMKDtrwu3RPxWpldtsSoqEuPfxs8horSDZm+/V101y3 rLv50W2pmoUV+uQ1Q1niIOgakg== X-Google-Smtp-Source: AGRyM1vrMf7GTnVelKxnSwRHWWbdVw3djaiQiOu0uxngmY4+SVTXF6d/YiYWRDu9588N45dwC8jkUw== X-Received: by 2002:a5d:64cc:0:b0:21b:ba06:4d4d with SMTP id f12-20020a5d64cc000000b0021bba064d4dmr11794574wri.157.1656326032961; Mon, 27 Jun 2022 03:33:52 -0700 (PDT) Received: from [192.168.0.248] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id 4-20020a1c1904000000b0039c4506bd25sm15039945wmz.14.2022.06.27.03.33.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Jun 2022 03:33:52 -0700 (PDT) Message-ID: <2efd725f-3d99-c1df-23ce-9ee60bbe4600@linaro.org> Date: Mon, 27 Jun 2022 12:33:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] tty: serial: samsung_tty: support more than 4 uart ports Content-Language: en-US To: Chanho Park , Greg Kroah-Hartman Cc: Jiri Slaby , Alim Akhtar , Hector Martin , Jaewon Kim , Vincent Whitchurch , linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20220627071512.18180-1-chanho61.park@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <20220627071512.18180-1-chanho61.park@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220627_033354_803902_7B09347A X-CRM114-Status: GOOD ( 14.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 27/06/2022 09:15, Chanho Park wrote: > Regarding Exynos Auto v9 SoC, it supports uarts up to 12. However, the > maximum number of the ports has been derived from > CONFIG_SERIAL_SAMSUNG_UARTS and tightly coupled with the config for > previous Samsung SoCs such as s3c24xx and s3c64xx. To overcome this > limitation, this changes the usage of the definition to UART_NR which is > widely used from other serial drivers. This also defines the value to 12 > only for ARM64 SoCs to not affect the change to previous arm32 SoCs. > Instead of enumerating all the ports as predefined arrays, this > introduces s3c24xx_serial_init_port_default that is initializing the > structure as default value. > Regarding the ports which are greater than 4 > will be initialized as default value and the fifo size will be retrieved > from the DT property. You need to explain why you are doing this. It's confusing to initialize some statically and some dynamically. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel