From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D08D9C433E2 for ; Fri, 11 Sep 2020 02:49:01 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 82DF82078B for ; Fri, 11 Sep 2020 02:49:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="HQPoWc7r"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="CDDzIjjM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 82DF82078B Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YHUg7oVDU7HT4DglodhybalSy0W8qJy2UMB7QJa4aSA=; b=HQPoWc7r1K3BLNMQVIbOEKbdM sOj9BitBjuIDwST9StZzAeODpe0pCawRuRUh4LrkPsXnQINlRLP2L0KlTYtG6S1H3ZnPnFX06d3M9 JWy0Ju9I3gdNLqJuGfhvAiFmTWX4JKC+P3HbPLxlVXmA1OLzY5hXX6QSJyHZIvGn7yCboCuS2dede JOaZ04pzx/+N19NGjc2ESIxzkXfgRw9/lWXyqOsTDgnI5bjLVeFqAVMnMYcE0z0+aL1e2CcwqnDji MBp5x1L2Shb5ixsXojl+9/OaE8+5LyO9TFecF+THl8Y/4TozfiPX/kD2NwCT1XZ1Jz4AvQ7G3M9ol Hg8VskaOA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kGZ68-00006Y-9j; Fri, 11 Sep 2020 02:47:36 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kGZ64-00005P-Vh for linux-arm-kernel@lists.infradead.org; Fri, 11 Sep 2020 02:47:34 +0000 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 08B2lT69001288; Thu, 10 Sep 2020 21:47:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1599792449; bh=5C3n2ifpxrT79tXAyyVK3erCrf7btBkT3WK13Eaxp2s=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=CDDzIjjMX+l0PbwvSzod1v7ljTHGoTvevREDyEYi0f1ai7HA+ezU29cQBGKdnXp2V iutUlcgxpDF+yywaGtiYfvkYxkvNPP1OY6/h6LgfJrPy9l8hdBMvGjAAKgDXEUZAyZ fmHl3du0yKgSdMr+gSyDZie75w4SlZ2tAk/xz+eo= Received: from DLEE106.ent.ti.com (dlee106.ent.ti.com [157.170.170.36]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 08B2lT7F017863 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 10 Sep 2020 21:47:29 -0500 Received: from DLEE114.ent.ti.com (157.170.170.25) by DLEE106.ent.ti.com (157.170.170.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Thu, 10 Sep 2020 21:47:28 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE114.ent.ti.com (157.170.170.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Thu, 10 Sep 2020 21:47:29 -0500 Received: from [10.250.66.47] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 08B2lRXY049564; Thu, 10 Sep 2020 21:47:27 -0500 Subject: Re: [PATCH v3 4/5] arm64: dts: ti: Add support for J7200 SoC To: Nishanth Menon References: <20200908162252.17672-1-lokeshvutla@ti.com> <20200908162252.17672-5-lokeshvutla@ti.com> <20200910171928.xzfwhix46lcsiup7@akan> <83122b2e-4dba-a2f9-b722-e510acfa9135@ti.com> <20200910182020.t4xkpgyzu5ryxkp5@akan> From: Suman Anna Message-ID: <2f06e21a-798d-cbe2-80cc-202a8069ce9f@ti.com> Date: Thu, 10 Sep 2020 21:47:27 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200910182020.t4xkpgyzu5ryxkp5@akan> Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200910_224733_111713_164C2C35 X-CRM114-Status: GOOD ( 20.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Device Tree Mailing List , Grygorii Strashko , Lokesh Vutla , Sekhar Nori , Kishon Vijay Abraham I , Tero Kristo , Rob Herring , Linux ARM Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/10/20 1:20 PM, Nishanth Menon wrote: > On 12:54-20200910, Suman Anna wrote: > [...] > >>>> + }; >>> >>> I think we could introduce base infrastructure stuff like intr and >>> inta nodes here? Also, the gpio_intr? >> >> FYI, they are currently being added in Patch 1 from Grygorii's "[v2,0/4] arm64: >> dts: ti: k3-j7200: add dma and mcu cpsw" series, >> https://patchwork.kernel.org/cover/11763711/ >> >> The overall series seems to have some dependencies, so better to separate out >> those nodes and include as an additional add-on patch to this series, atleast it >> can unblock all others who use the TI-SCI Interrupt node. >> > > There is dependency on udma which in turn needs chipid stuff merged, > but I dont see anything preventing inta intr (which are infrastructure > components) from being merged in. It is not just udma driver that uses these > infrastructure. Yep, I also meant the same. > > [...] >>>> + >>>> +/ { >>>> + model = "Texas Instruments K3 J7200 SoC"; >>>> + compatible = "ti,j7200"; >>>> + interrupt-parent = <&gic500>; >>>> + #address-cells = <2>; >>>> + #size-cells = <2>; >>>> + >>>> + aliases { >>>> + serial0 = &wkup_uart0; >>>> + serial1 = &mcu_uart0; >>>> + serial2 = &main_uart0; >>>> + serial3 = &main_uart1; >>>> + serial4 = &main_uart2; >>>> + serial5 = &main_uart3; >>>> + serial6 = &main_uart4; >>>> + serial7 = &main_uart5; >>>> + serial8 = &main_uart6; >>>> + serial9 = &main_uart7; >>>> + serial10 = &main_uart8; >>>> + serial11 = &main_uart9; >>>> + }; >>>> + >>> >>> might be nice to leave a chosen { }; here to indicate board >>> files fill it up.. just to maintain consistency with rest of SoC dtsis? >> >> Doesn't serve any purpose IMO. I remember commenting about that blank node to >> remove it during some earlier reviews. > > I know. just consistency for board files to add things in -> you can > see similar usage else where as well. if we are going to drop it, we might > drop from am65 and j721e as well. for bootloaders that look for the node, it > tends to be consistently present OR not.. I'd rather they be consistently > be available than to deal with mix for downstream boards. No strong feelings > either way, but.. lets stay consistent throughout. > > $ git grep 'chosen { };' arch/arm64/boot/dts/ > arch/arm64/boot/dts/apm/apm-merlin.dts: chosen { }; > arch/arm64/boot/dts/apm/apm-mustang.dts: chosen { }; > arch/arm64/boot/dts/arm/foundation-v8.dtsi: chosen { }; > arch/arm64/boot/dts/arm/fvp-base-revc.dts: chosen { }; > arch/arm64/boot/dts/arm/rtsm_ve-aemv8a.dts: chosen { }; > arch/arm64/boot/dts/hisilicon/hip06-d03.dts: chosen { }; > arch/arm64/boot/dts/mediatek/mt8173-evb.dts: chosen { }; > arch/arm64/boot/dts/qcom/msm8916.dtsi: chosen { }; > arch/arm64/boot/dts/qcom/msm8992.dtsi: chosen { }; > arch/arm64/boot/dts/qcom/msm8994.dtsi: chosen { }; > arch/arm64/boot/dts/qcom/msm8996.dtsi: chosen { }; > arch/arm64/boot/dts/qcom/msm8998.dtsi: chosen { }; > arch/arm64/boot/dts/qcom/qcs404.dtsi: chosen { }; > arch/arm64/boot/dts/qcom/sc7180.dtsi: chosen { }; > arch/arm64/boot/dts/qcom/sdm630.dtsi: chosen { }; > arch/arm64/boot/dts/qcom/sdm660.dtsi: chosen { }; > arch/arm64/boot/dts/qcom/sdm845.dtsi: chosen { }; > arch/arm64/boot/dts/qcom/sm8150.dtsi: chosen { }; > arch/arm64/boot/dts/qcom/sm8250.dtsi: chosen { }; > arch/arm64/boot/dts/ti/k3-am65.dtsi: chosen { }; > arch/arm64/boot/dts/ti/k3-j721e.dtsi: chosen { }; > Yeah ok to add back then. regards Suman _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel