Re: [PATCH v7 10/10] drm: bridge: samsung-dsim: Add i.MX8MM support

Marek Vasut
2022-10-15T21:31:29Z

On 10/5/22 17:13, Jagan Teki wrote:

[...]

> +static const struct samsung_dsim_driver_data imx8mm_dsi_driver_data = {
> + .reg_ofs = exynos5433_reg_ofs,
> + .plltmr_reg = 0xa0,
> + .has_clklane_stop = 1,
> + .num_clks = 2,
> + .max_freq = 2100,
> + .wait_for_reset = 0,
> + .num_bits_resol = 12,
> + /**

Should this really be kerneldoc style /** comment or plain /* comment ?
If the later, please fix globally, there are multiple such FIXME comments.

> + * FIXME:
> + * Offset value used from downstream drivers/gpu/drm/bridge/sec-dsim.c
> + * remove this comment if it is true else update the logic.
> + */
> + .pll_p_offset = 14,
> + .reg_values = imx8mm_dsim_reg_values,
> +}; …