From: Wenyou.Yang@Microchip.com (Yang, Wenyou)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 2/3] media: ov7670: Add the get_fmt callback
Date: Mon, 18 Sep 2017 17:25:28 +0800 [thread overview]
Message-ID: <2f2a0259-1176-74b7-d9f7-a5cf7392ebdf@Microchip.com> (raw)
In-Reply-To: <20170918073628.nwjdyfdk7hvsetfb@valkosipuli.retiisi.org.uk>
Hi Sakari,
On 2017/9/18 15:36, Sakari Ailus wrote:
> Hi Wenyou,
>
> On Mon, Sep 18, 2017 at 02:45:13PM +0800, Wenyou Yang wrote:
>> @@ -998,8 +1002,15 @@ static int ov7670_set_fmt(struct v4l2_subdev *sd,
>> ret = ov7670_try_fmt_internal(sd, &format->format, NULL, NULL);
>> if (ret)
>> return ret;
>> - cfg->try_fmt = format->format;
>> +#ifdef CONFIG_VIDEO_V4L2_SUBDEV_API
>> + struct v4l2_mbus_framefmt *mbus_fmt;
> This will emit a compiler warning at least.
Thank you for your review.
Will be fixed in next version.
>
>> +
>> + mbus_fmt = v4l2_subdev_get_try_format(sd, cfg, format->pad);
>> + *mbus_fmt = format->format;
>> return 0;
>> +#else
>> + return -ENOTTY;
>> +#endif
>> }
>>
>> ret = ov7670_try_fmt_internal(sd, &format->format, &ovfmt, &wsize);
Best Regards,
Wenyou Yang
next prev parent reply other threads:[~2017-09-18 9:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-18 6:45 [PATCH v4 0/3] media: ov7670: Add entity init and power operation Wenyou Yang
2017-09-18 6:45 ` [PATCH v4 1/3] media: ov7670: Add entity pads initialization Wenyou Yang
2017-09-18 6:45 ` [PATCH v4 2/3] media: ov7670: Add the get_fmt callback Wenyou Yang
2017-09-18 7:35 ` kbuild test robot
2017-09-18 7:36 ` Sakari Ailus
2017-09-18 9:25 ` Yang, Wenyou [this message]
2017-09-18 6:45 ` [PATCH v4 3/3] media: ov7670: Add the s_power operation Wenyou Yang
2017-09-18 7:35 ` Sakari Ailus
2017-09-18 9:26 ` Yang, Wenyou
2017-09-18 13:26 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f2a0259-1176-74b7-d9f7-a5cf7392ebdf@Microchip.com \
--to=wenyou.yang@microchip.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).