From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 280FEC10F11 for ; Wed, 24 Apr 2019 08:47:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EC52B218D3 for ; Wed, 24 Apr 2019 08:47:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GXrtdM6/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EC52B218D3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fw8zMyGTpUAmht7/1ECu+8bNvfxbEOa4xu/5XkvsvAw=; b=GXrtdM6/q3OATa mA+qe5gVfDiCVEJ/vU8op861Rr3LTpKVfRD8S+TaTebABc+5DiW+KvM5oz63DldODh8asqnmAb6gO sVE8XcRqeDfU/zS1KA9ixUzbMQKsl3uDDKJ/UkGFTC6zHI9WVuOfBSwC229ELlrBSY7KGE7dji7Mj Y9zovRaWZWiiDU54ayKfnwBUBFLigkN6QGVLX8z0P0y5/hUGWkGobacfHLd66rkt4CkPeXU4RdXiC nYAlaVLOhwxJfBvaWNwQR7njcy7THYKDzDTjq+NnR8gk7gDrxfysTqVpfIcjFQuAikkOQx8QMw3s1 SLk87rEjAgSvd3oZk4xQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hJDZ7-00052x-30; Wed, 24 Apr 2019 08:47:41 +0000 Received: from szxga06-in.huawei.com ([45.249.212.32] helo=huawei.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hJDZ3-00052A-BL for linux-arm-kernel@lists.infradead.org; Wed, 24 Apr 2019 08:47:38 +0000 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id CDD7D1EBDC12C0F9947D; Wed, 24 Apr 2019 16:47:32 +0800 (CST) Received: from [127.0.0.1] (10.177.31.96) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.439.0; Wed, 24 Apr 2019 16:47:29 +0800 Subject: Re: [PATCH] soc: imx: Fix build error without CONFIG_SOC_BUS To: Leonard Crestez , "shawnguo@kernel.org" , Abel Vesa References: <20190424075946.23124-1-yuehaibing@huawei.com> From: YueHaibing Message-ID: <2f2b461f-2ad3-c81e-0826-ed7819de5518@huawei.com> Date: Wed, 24 Apr 2019 16:47:27 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.177.31.96] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190424_014737_563809_8B7E15BD X-CRM114-Status: UNSURE ( 9.34 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aisheng Dong , Anson Huang , "s.hauer@pengutronix.de" , "linux-kernel@vger.kernel.org" , dl-linux-imx , "kernel@pengutronix.de" , "festevam@gmail.com" , "linux-arm-kernel@lists.infradead.org" , "l.stach@pengutronix.de" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2019/4/24 16:11, Leonard Crestez wrote: > On 4/24/2019 11:00 AM, Yue Haibing wrote: >> From: YueHaibing >> >> During randconfig builds, I occasionally run into an invalid configuration >> >> drivers/soc/imx/soc-imx8.o: In function `imx8_soc_init': >> soc-imx8.c:(.init.text+0x144): undefined reference to `soc_device_register' >> >> while CONFIG_SOC_BUS is not set, the building failed like this. This patch >> selects SOC_BUS to fix it. >> >> diff --git a/drivers/soc/imx/Kconfig b/drivers/soc/imx/Kconfig >> @@ -5,6 +5,7 @@ config IMX_GPCV2_PM_DOMAINS >> depends on ARCH_MXC || (COMPILE_TEST && OF) >> depends on PM >> select PM_GENERIC_DOMAINS >> + select SOC_BUS >> default y if SOC_IMX7D > > You should "select SOC_BUS" from "config ARCH_MXC" in arm64 > Kconfig.platforms, not from a power domain implementation. > > Your patch works because arm64 ARCH_MXC currently does "select > IMX_GPCV2_PM_DOMAINS" but it's silly to use this intermediary. Yes, you are right, thanks! > > -- > Regards, > Leonard > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel