From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3DBCFC47258 for ; Tue, 23 Jan 2024 16:37:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bL1fbnh5bLeXFSYbBl68ZSvbCOLVEpB+Cpvjx7TWqkM=; b=fKQkB9pGiOZqxu UcF3Du6xi4WUb7X+9bymOMNiK9F0PhAnwkJkcH7oy2UCGj4PU7Qq1gth01+a78qZbL7sVVUzQ2Fyb q/i8mxa+p4XDjhcE60j3AaD5bZ+yiiw67iYiQvICb0SM5QBH2JfuF0dSaePzSr8pvG3fMrrN8jNmg aij4Vfwbv98iz2nb24bFWftDvUhIz3zPzbeOyP1wt9879bWsMJRQ57TS5fQyUugh5RIj4HS9nJ6B0 z5pBnJCAbw6Obcw46C9o/GT/Ge893D1AWyR6KC5vCtQI4hvvszGBfHypTdLF79k2T3+yhn9LANLjm IyYHjwu1Kte4Ms2LV5Ww==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rSJlW-00HIZp-1I; Tue, 23 Jan 2024 16:36:46 +0000 Received: from mx07-00178001.pphosted.com ([185.132.182.106]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rSJlS-00HIXX-1B for linux-arm-kernel@lists.infradead.org; Tue, 23 Jan 2024 16:36:44 +0000 Received: from pps.filterd (m0241204.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 40NDGPpY025074; Tue, 23 Jan 2024 17:36:16 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= selector1; bh=f4r28JTyj8rXZ4Hw+jKUzy+y+XqwXgGyRB/ME3czeEQ=; b=YK fS3eVU2geFjov0jvlj6gp55G9D36a/Vtu/dBbrqUO+EmXt/PHpGaOlnatwsOHzla pnceUuwDeuPJ/cJGKmqpuZrJC8dgmMRCCPoYwH9kqHFop/H2EsbWbUrl1VgOYgOT msiBqbhfAciUF9eHFyB162PxPx0RL2pVG0uILjz2foGJCd4MMwjx4xAcIRifgcSK APKUuzTFKj/A/dKJUa0MMWRqi8NzDmEPUL8rrd3YQu9hIQov2fGPHuJdl/5Yapb8 IFRNHriS5sk2Iw9pqe7+mcxCDfk3TWXBpS43WRLtZUdRl6/+g+/Gy5vgG1/ws+LS FqaVhG5Tunxej4ENyxag== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3vsrxppbxv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 23 Jan 2024 17:36:16 +0100 (CET) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 117BF100056; Tue, 23 Jan 2024 17:36:14 +0100 (CET) Received: from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 0607628E3B4; Tue, 23 Jan 2024 17:36:14 +0100 (CET) Received: from [10.201.21.122] (10.201.21.122) by SHFDAG1NODE1.st.com (10.75.129.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 23 Jan 2024 17:36:13 +0100 Message-ID: <2f3144e2-2438-4ea8-ada0-3fbdd79ee131@foss.st.com> Date: Tue, 23 Jan 2024 17:36:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 5/5] ARM: dts: add stm32f769-disco-mb1225-revb03-mb1166-reva09 Content-Language: en-US To: Dario Binacchi , CC: , Lee Jones , Raphael Gallais-Pou , Linus Walleij , Andre Przywara , Baruch Siach , Conor Dooley , Krzysztof Kozlowski , =?UTF-8?Q?Leonard_G=C3=B6hrs?= , Maxime Coquelin , Peter Rosin , Rob Herring , Sean Nyekjaer , , , References: <20240112144902.40044-1-dario.binacchi@amarulasolutions.com> <20240112144902.40044-6-dario.binacchi@amarulasolutions.com> From: Alexandre TORGUE In-Reply-To: <20240112144902.40044-6-dario.binacchi@amarulasolutions.com> X-Originating-IP: [10.201.21.122] X-ClientProxiedBy: EQNCAS1NODE4.st.com (10.75.129.82) To SHFDAG1NODE1.st.com (10.75.129.69) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-23_09,2024-01-23_02,2023-05-22_02 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240123_083642_739055_9C8390A2 X-CRM114-Status: GOOD ( 25.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Dario On 1/12/24 15:48, Dario Binacchi wrote: > As reported in the section 8.3 (i. e. Board revision history) of document > UM2033 (i. e. Discovery kit with STM32F769NI MCU) these are the changes > related to the board revisions addressed by the patch: > - Board MB1225 revision B-03: > - Memory MICRON MT48LC4M32B2B5-6A replaced by ISSI IS42S32400F-6BL > - Board MB1166 revision A-09: > - LCD FRIDA FRD397B25009-D-CTK replaced by FRIDA FRD400B25025-A-CTK > > The patch only adds the DTS support for the new display which belongs to > to the Novatek NT35510-based panel family. > > Signed-off-by: Dario Binacchi > Reviewed-by: Linus Walleij > Reviewed-by: Raphael Gallais-Pou > I still have YAML error. Do you have same on your side or maybe I missed a dt-binding patch somewhere ? /arch/arm/boot/dts/st/stm32f769-disco-mb1225-revb03-mb1166-reva09.dtb: dsi@40016c00: Unevaluated properties are not allowed ('interrupts', 'panel-dsi@0' were unexpected) from schema $id: http://devicetree.org/schemas/display/st,stm32-dsi.yaml# /arch/arm/boot/dts/st/stm32f769-disco-mb1225-revb03-mb1166-reva09.dtb: panel-dsi@0: 'port' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/display/panel/novatek,nt35510.yaml# Aside that, I just have a cosmetic question. Can we find a shorter name for the board ? (not sure we can). Cheers Alex > --- > > Changes in v8: > - Add Reviewed-by tag of Linus Walleij > - Add Reviewed-by tag of Raphael Gallais-Pou > > Changes in v7: > - Replace .dts with .dtb in the Makefile > > Changes in v6: > - Drop patches > - [5/8] dt-bindings: nt35510: add compatible for FRIDA FRD400B25025-A-CTK > - [7/8] drm/panel: nt35510: move hardwired parameters to configuration > - [8/8] drm/panel: nt35510: support FRIDA FRD400B25025-A-CTK > because applied by the maintainer Linus Walleij > > Changes in v5: > - Replace GPIOD_ASIS with GPIOD_OUT_HIGH in the call to devm_gpiod_get_optional(). > > Changes in v2: > - Change the status of panel_backlight node to "disabled" > - Delete backlight property from panel0 node. > - Re-write the patch [8/8] "drm/panel: nt35510: support FRIDA FRD400B25025-A-CTK" > in the same style as the original driver. > > arch/arm/boot/dts/st/Makefile | 1 + > ...2f769-disco-mb1225-revb03-mb1166-reva09.dts | 18 ++++++++++++++++++ > 2 files changed, 19 insertions(+) > create mode 100644 arch/arm/boot/dts/st/stm32f769-disco-mb1225-revb03-mb1166-reva09.dts > > diff --git a/arch/arm/boot/dts/st/Makefile b/arch/arm/boot/dts/st/Makefile > index 7892ad69b441..aa5b50d7ac61 100644 > --- a/arch/arm/boot/dts/st/Makefile > +++ b/arch/arm/boot/dts/st/Makefile > @@ -23,6 +23,7 @@ dtb-$(CONFIG_ARCH_STM32) += \ > stm32f469-disco.dtb \ > stm32f746-disco.dtb \ > stm32f769-disco.dtb \ > + stm32f769-disco-mb1225-revb03-mb1166-reva09.dtb \ > stm32429i-eval.dtb \ > stm32746g-eval.dtb \ > stm32h743i-eval.dtb \ > diff --git a/arch/arm/boot/dts/st/stm32f769-disco-mb1225-revb03-mb1166-reva09.dts b/arch/arm/boot/dts/st/stm32f769-disco-mb1225-revb03-mb1166-reva09.dts > new file mode 100644 > index 000000000000..014cac192375 > --- /dev/null > +++ b/arch/arm/boot/dts/st/stm32f769-disco-mb1225-revb03-mb1166-reva09.dts > @@ -0,0 +1,18 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (c) 2023 Dario Binacchi > + */ > + > +#include "stm32f769-disco.dts" > + > +&panel_backlight { > + status = "disabled"; > +}; > + > +&panel0 { > + compatible = "frida,frd400b25025", "novatek,nt35510"; > + vddi-supply = <&vcc_3v3>; > + vdd-supply = <&vcc_3v3>; > + /delete-property/backlight; > + /delete-property/power-supply; > +}; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel