From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35178C352AC for ; Thu, 26 Sep 2019 13:06:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 073F5222C3 for ; Thu, 26 Sep 2019 13:06:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Z3uBs5qZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 073F5222C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=A1THZFLp6sbnj9D9xwDC4bC5IovezhAolimSx+GWC4w=; b=Z3uBs5qZkYEXxs7Z5NkEHkStU OIicyTCJKBr/7ehMvBmjF4A9tMTPf2DukH6zY2WykqRYPYm1ZDnwDJS5pekzRLxwUBwXNa9rPolKl fvy3l9yf/M+P4oQrPYxUkNyAbfnsUiovIqthohvP3VzDT5b8d5MWU7cWzcC5T91CZFM/7ATEZ9z49 ICJUWsgc89hMoC/+SIMaRvB9+2ayZxe29f/30ZuPGqorciwBEIa2GVIJXkO1BlMH4mOHDoA4lCOeF RUSTHekacKp3Mc7+BGPPXiftO+po5pJSVS4eD1kXqJZRFlNHkWKqJPLDBcXbYluYclci6tVFjVkzI P5IpxHFNQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iDTTU-0003td-5q; Thu, 26 Sep 2019 13:06:24 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iDTTQ-0003q4-57 for linux-arm-kernel@lists.infradead.org; Thu, 26 Sep 2019 13:06:21 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 58226142F; Thu, 26 Sep 2019 06:06:16 -0700 (PDT) Received: from dawn-kernel.cambridge.arm.com (unknown [10.1.197.116]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1B6E63F763; Thu, 26 Sep 2019 06:06:14 -0700 (PDT) Subject: Re: [RFC PATCH v4 2/5] ptp: Reorganize ptp_kvm modules to make it arch-independent. To: Jianyong Wu , netdev@vger.kernel.org, yangbo.lu@nxp.com, john.stultz@linaro.org, tglx@linutronix.de, pbonzini@redhat.com, sean.j.christopherson@intel.com, maz@kernel.org, richardcochran@gmail.com, Mark.Rutland@arm.com, Will.Deacon@arm.com References: <20190926114212.5322-1-jianyong.wu@arm.com> <20190926114212.5322-3-jianyong.wu@arm.com> From: Suzuki K Poulose Message-ID: <2f338b57-b0b2-e439-6089-72e5f5e4f017@arm.com> Date: Thu, 26 Sep 2019 14:06:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 MIME-Version: 1.0 In-Reply-To: <20190926114212.5322-3-jianyong.wu@arm.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190926_060620_320409_64FA8E35 X-CRM114-Status: GOOD ( 14.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: justin.he@arm.com, kvm@vger.kernel.org, Steve.Capper@arm.com, linux-kernel@vger.kernel.org, Kaly.Xin@arm.com, nd@arm.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jianyong, On 26/09/2019 12:42, Jianyong Wu wrote: > Currently, ptp_kvm modules implementation is only for x86 which includs > large part of arch-specific code. This patch move all of those code > into new arch related file in the same directory. > > Signed-off-by: Jianyong Wu > --- > drivers/ptp/Makefile | 1 + > drivers/ptp/{ptp_kvm.c => kvm_ptp.c} | 77 ++++++------------------ > drivers/ptp/ptp_kvm_x86.c | 87 ++++++++++++++++++++++++++++ > include/asm-generic/ptp_kvm.h | 12 ++++ > 4 files changed, 118 insertions(+), 59 deletions(-) > rename drivers/ptp/{ptp_kvm.c => kvm_ptp.c} (63%) minor nit: Could we not skip renaming the file ? Given you are following the ptp_kvm_* for the arch specific files and the header files, wouldn't it be good to keep ptp_kvm.c ? Rest looks fine. Cheers Suzuki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel