From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B3E05CD37AA for ; Tue, 3 Sep 2024 17:47:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:References:Cc:To:Subject:From:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3U/qOEAcWb5c4MQDovr6aE/At0h1Z9coG62wGqmbh7c=; b=Ti9Z9giN9/mf5do+j4ENQESnUn c3Z3FuakJmKAfQedp4KRYyzBoJSzHFQqgE41iraxm9+MdN2PoYt25Wol7T2p55IDtttoz3ALb5CI5 ycUtpQdnSY8YJLzNsCm93/UchKXbdw04wvRfZ6IHj7r7+tHnM9cFLBYZu08tHNCjLA4iAZB/M07P5 +bcBZGowm+CN3/fP6oLd8koX8G0RhNPTMTSgH3FixED/ehqCL3lUBpaC32/QO0isyK4PCM93HQXQ4 9RW+jsO1p4kq8kOwKVqxrXQGVKR+x8v+W9WkIdZYj2IXbpQTsL07Y8ICu7UbpAwVw6Y55VztZY/DF p0bXfbNQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1slXct-00000001MCs-2RwF; Tue, 03 Sep 2024 17:47:35 +0000 Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1slXb7-00000001LXV-2z2D for linux-arm-kernel@lists.infradead.org; Tue, 03 Sep 2024 17:45:47 +0000 Received: by mail-pf1-x42b.google.com with SMTP id d2e1a72fcca58-7141feed424so4432724b3a.2 for ; Tue, 03 Sep 2024 10:45:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1725385545; x=1725990345; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:subject:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=3U/qOEAcWb5c4MQDovr6aE/At0h1Z9coG62wGqmbh7c=; b=XSss12eTMaHQwT4zayDzc2x2tHcBpZYJW8e1VsQbIxEJrlx29E0toF+V1ZXzJzeA7O 3JdL9oJDkfBPTF8PgqL6+vF+j6XqojybiSIIcx5+qbrsQzEXHYYGLuna9CUvd8EuGTnA XI9ITUijHbTD6k3jtJQCz0NumSeclrkS++T6g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725385545; x=1725990345; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:subject:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3U/qOEAcWb5c4MQDovr6aE/At0h1Z9coG62wGqmbh7c=; b=v0Fkw9f/gVniRALZ+rcejnSqUV6S2iIUVvxND0pjPdjiAH+IaiOcdg7EJ+MP1wY9do jtCxA9NCudCjjru47whGEvGQpoE+hhwFgeFUQiSoz1ooiJoJAPllhGWzs8kO1r9neAdh r4RdaqHr2Hc/tZQ+QKnUpuOXgLaHrOx5j/gZmrLu4FOtYIlxytWCYeH8aQ8tSO92644A 8gL7cPc4II3UJHYIZfD+aN0K7dpvfYfm21mSKpX+LHb4fwVwZBsNndKm093nynNjPZqD VVsXg4+m9YUiO8+YM2Jq4WDDf4gMqc9NoJHCq3DgOOclx9/VeYRZgYp6lyRPHTrZ/mFE R+8g== X-Forwarded-Encrypted: i=1; AJvYcCUW+QHN1oV5aNt6jNIWRFfTM3LVkuTkaoB2GD9j78fSbDTgEmhBcUphioGEeztJ+Fb7nK4ue62A1aw2XDjiSgh/@lists.infradead.org X-Gm-Message-State: AOJu0YzQ7ttCVNYSIGmj0rbKBD3nkrFzF9aO0BEDwc9xei+r9VjaUIp1 mqWlYqHOy6s4N9wo9t2C/1QVzW3u8rvfFiU/W9iBwn3jzZzUF3gp4gwXAHB2WQ== X-Google-Smtp-Source: AGHT+IGM+TTtHmKs1QSDI2elSVemAmtiLyWfX+nlSvkMSsZAECRrfa7OaE627B71XLU6LRmGdYHT7Q== X-Received: by 2002:a05:6a00:22d5:b0:70d:2a88:a483 with SMTP id d2e1a72fcca58-7173f8adafdmr10905636b3a.0.1725385544296; Tue, 03 Sep 2024 10:45:44 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-717785996d0sm137258b3a.145.2024.09.03.10.45.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Sep 2024 10:45:43 -0700 (PDT) Message-ID: <2f3e01d0-9b4b-4678-b05b-226074579b8a@broadcom.com> Date: Tue, 3 Sep 2024 10:45:41 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Florian Fainelli Subject: Re: [PATCH v6 07/13] PCI: brcmstb: PCI: brcmstb: Make HARD_DEBUG, INTR2_CPU_BASE offsets SoC-specific To: Bjorn Helgaas , Jim Quinlan Cc: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , Stanimir Varbanov , Manivannan Sadhasivam , Krzysztof Kozlowski , bcm-kernel-feedback-list@broadcom.com, jim2101024@gmail.com, Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list References: <20240902194649.GA224705@bhelgaas> Content-Language: en-US Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: <20240902194649.GA224705@bhelgaas> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240903_104545_903854_36A1130A X-CRM114-Status: GOOD ( 20.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/2/24 12:46, Bjorn Helgaas wrote: > On Thu, Aug 15, 2024 at 06:57:20PM -0400, Jim Quinlan wrote: >> Do prepatory work for the 7712 SoC, which is introduced in a future commit. >> Our HW design has changed two register offsets for the 7712, where >> previously it was a common value for all Broadcom SOCs with PCIe cores. >> Specifically, the two offsets are to the registers HARD_DEBUG and >> INTR2_CPU_BASE. > >> @@ -1499,12 +1502,16 @@ static const int pcie_offsets[] = { >> [RGR1_SW_INIT_1] = 0x9210, >> [EXT_CFG_INDEX] = 0x9000, >> [EXT_CFG_DATA] = 0x9004, >> + [PCIE_HARD_DEBUG] = 0x4204, >> + [PCIE_INTR2_CPU_BASE] = 0x4300, >> }; >> >> static const int pcie_offsets_bmips_7425[] = { >> [RGR1_SW_INIT_1] = 0x8010, >> [EXT_CFG_INDEX] = 0x8300, >> [EXT_CFG_DATA] = 0x8304, >> + [PCIE_HARD_DEBUG] = 0x4204, >> + [PCIE_INTR2_CPU_BASE] = 0x4300, >> }; >> >> static const struct pcie_cfg_data generic_cfg = { >> @@ -1539,6 +1546,8 @@ static const int pcie_offset_bcm7278[] = { >> [RGR1_SW_INIT_1] = 0xc010, >> [EXT_CFG_INDEX] = 0x9000, >> [EXT_CFG_DATA] = 0x9004, >> + [PCIE_HARD_DEBUG] = 0x4204, >> + [PCIE_INTR2_CPU_BASE] = 0x4300, >> }; > > What's the organization scheme here? We now have: > > static const int pcie_offsets[] = { ... }; > static const int pcie_offsets_bmips_7425[] = { ... }; > static const int pcie_offset_bcm7712[] = { ... }; > > static const struct pcie_cfg_data generic_cfg = { ... }; > static const struct pcie_cfg_data bcm7425_cfg = { ... }; > static const struct pcie_cfg_data bcm7435_cfg = { ... }; > static const struct pcie_cfg_data bcm4908_cfg = { ... }; > > static const int pcie_offset_bcm7278[] = { ... }; > > static const struct pcie_cfg_data bcm7278_cfg = { ... }; > static const struct pcie_cfg_data bcm2711_cfg = { ... }; > static const struct pcie_cfg_data bcm7216_cfg = { ... }; > static const struct pcie_cfg_data bcm7712_cfg = { ... }; > > So we have pcie_offsets_bmips_7425[] and pcie_offset_bcm7712[] (with > gratuituously different "offset" vs "offsets") which are all together > before the pcie_cfg_data. > > Then we have pcie_offset_bcm7278[] (again gratuitously different > "offset") separately, next to bcm7278_cfg. > > It would be nice to pick one scheme and stick to it. > > Also a seemingly random order of the pcie_cfg_data structs and > .compatible strings. > > Also a little confusing to have "bmips_7425" and "bcm7425" associated > with the same chip. I suppose there's historical reason for it, but I > don't think it's helpful in this usage. All fair points, especially the lack of consistency, thanks for cleaning that up. -- Florian