From: Markus Elfring <Markus.Elfring@web.de>
To: Ruoyu Wang <ruoyuw560@gmail.com>,
linux-perf-users@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: Jing Zhang <renyu.zj@linux.alibaba.com>,
Mark Rutland <mark.rutland@arm.com>,
Shuai Xue <xueshuai@linux.alibaba.com>,
Will Deacon <will@kernel.org>,
Yunhui Cui <cuiyunhui@bytedance.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [v2] perf/dwc_pcie: Fix PCI device reference leak in probe
Date: Thu, 20 Aug 2026 16:43:37 +0200 [thread overview]
Message-ID: <2f6036e6-4dbe-44ae-8d59-f1f577516759@web.de> (raw)
In-Reply-To: <CAK_7xqwRdXEe63YoMNE5KtLKA3+Nx=qVYj_mqfJmTVjb2-f-cQ@mail.gmail.com>
> I think keeping the function scope is clearer here :)
I got an other impression because a pci_dev_put(pdev) call was applied
before a devm_kasprintf() call.
https://elixir.bootlin.com/linux/v7.2/source/drivers/perf/dwc_pcie_pmu.c#L695-L717
Regards,
Markus
next prev parent reply other threads:[~2026-08-20 14:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-20 13:56 [PATCH v2] perf/dwc_pcie: Fix PCI device reference leak in probe Ruoyu Wang
2026-08-20 14:16 ` Markus Elfring
[not found] ` <CAK_7xqwRdXEe63YoMNE5KtLKA3+Nx=qVYj_mqfJmTVjb2-f-cQ@mail.gmail.com>
2026-08-20 14:43 ` Markus Elfring [this message]
2026-08-21 7:00 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f6036e6-4dbe-44ae-8d59-f1f577516759@web.de \
--to=markus.elfring@web.de \
--cc=cuiyunhui@bytedance.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=renyu.zj@linux.alibaba.com \
--cc=ruoyuw560@gmail.com \
--cc=will@kernel.org \
--cc=xueshuai@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox