From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 04FF7E94113 for ; Fri, 6 Oct 2023 20:08:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=j7anqq5tDBbGbL7MBaVPPM4MxxZCOwOfasLqTll+4Dk=; b=WQvlUC2R3hOFBe 9L9C2Yw59vQaUTDC5hWMZq+N0jLfycoHYJc+Tv6k8VsYFxL2SXrpHCoHc4r2u8lfqtg6ndiU/oqeO gnHh2kdNEqkulddgAn7+snSTngp3hG2AdafmSrvmS5K3J+WDN/1VZ5WJ9NBwo2GlUImP2SqGvX6kf rnsXK4sTk6VpX/liCv5nAkK+ICLbcGbvar81nTOIGL8ugZlYF8dpjIOhoswlZ5DAC4dpBh7JTotez boetDvef1PlA1ShXZVgFkP0nLB/D9LjQsEBXN+WGWU7umtZCgxHWiGAgHXn3m/3Hn8NC/SBeNA6Pn pfGn3sulTfdNHBVfqwjQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qor7c-006Qc1-32; Fri, 06 Oct 2023 20:08:28 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qor7Z-006Qau-0v for linux-arm-kernel@lists.infradead.org; Fri, 06 Oct 2023 20:08:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696622904; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ms/DXkkYNfaLBZlXzvAGFAiNgJdqqoDux/SIe2Qpatk=; b=WzOemcF3ntdA5BK7bnMF9mBVK/Y3f3ZHW+/Yykpr73QaqSC+BGTk7VraCudELEVjMRCedm NiOm9KP8iRZoES8ukbZZ/G8LcN61rJPKbKihhp6tUZckzewvLLNBfJrIQll1AcwxBlYNtV QffvnLdscgHQJjKS7RYDHEu1Z2+PLuk= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-245-taiuZAPRM2mzNiN6ILWafw-1; Fri, 06 Oct 2023 16:08:23 -0400 X-MC-Unique: taiuZAPRM2mzNiN6ILWafw-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-40566c578b7so18530765e9.0 for ; Fri, 06 Oct 2023 13:08:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696622902; x=1697227702; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ms/DXkkYNfaLBZlXzvAGFAiNgJdqqoDux/SIe2Qpatk=; b=bE/fQNU9X7np9qloo3Zcx4FyrPe6zVNGrSKe3AcGvUOnIJP4P5aAWZm+DcFQSO0Ypi +ZL2miUEZwmBSTRpMm1ejavFTh70jciZQSwJhY0eFe3zOispXjI2Cw3bNdGyaJqrXeKS +Sr2dir2NJJI8ijdV7whAB49Gi0i8Tjxy1YHP9HIaPLw7Zrr8k9qMX0vp082keMVjgIF tJtoWbPLR8hNWZeSiqBfAg0+lOheuNvwAld7VJDcaiwjWN8K3zngZdrmPv8javS+p3Gd Oe/CqgzHw8Nn1D1N2g9EwdBWDtZB9cuco5zMxzTDJVDLhImjs4yJIS9ovAQ0oB8l/9fv o7vQ== X-Gm-Message-State: AOJu0YzxSOTX27ZCSYHE3abc5tcHCTk5aSpJw6XFPYkVh2Urec7Bf9pb 6zgwAak0D/rMbBlJ9UQ0TZqUskuEdHqcIFHTpgozxMi0I4zEURNRK8jDz7+TI2ni7+UbbOoOzJh nTRHbgDw0NUEry4iSEuDGBmpatkIlIWnschM= X-Received: by 2002:a05:600c:d1:b0:405:3a3d:6f42 with SMTP id u17-20020a05600c00d100b004053a3d6f42mr8171897wmm.39.1696622901966; Fri, 06 Oct 2023 13:08:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IENTI2KRa9s/ItyJi1/4U0Y6qvQkJ3F+dDC3uabzJW4LFvFgnLD/TOZGvGmi56M5FncjAz+7Q== X-Received: by 2002:a05:600c:d1:b0:405:3a3d:6f42 with SMTP id u17-20020a05600c00d100b004053a3d6f42mr8171870wmm.39.1696622901443; Fri, 06 Oct 2023 13:08:21 -0700 (PDT) Received: from ?IPV6:2003:cb:c715:ee00:4e24:cf8e:3de0:8819? (p200300cbc715ee004e24cf8e3de08819.dip0.t-ipconnect.de. [2003:cb:c715:ee00:4e24:cf8e:3de0:8819]) by smtp.gmail.com with ESMTPSA id c19-20020a7bc853000000b004064288597bsm4411230wml.30.2023.10.06.13.08.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Oct 2023 13:08:21 -0700 (PDT) Message-ID: <2f64809e-0d0d-cc61-71ac-8d9b072efc3a@redhat.com> Date: Fri, 6 Oct 2023 22:08:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v6 6/9] mm: thp: Add "recommend" option for anon_orders To: Ryan Roberts , Andrew Morton , Matthew Wilcox , Yin Fengwei , Yu Zhao , Catalin Marinas , Anshuman Khandual , Yang Shi , "Huang, Ying" , Zi Yan , Luis Chamberlain , Itaru Kitayama , "Kirill A. Shutemov" , John Hubbard , David Rientjes , Vlastimil Babka , Hugh Dickins Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230929114421.3761121-1-ryan.roberts@arm.com> <20230929114421.3761121-7-ryan.roberts@arm.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230929114421.3761121-7-ryan.roberts@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231006_130825_399523_7FBFE19A X-CRM114-Status: GOOD ( 35.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 29.09.23 13:44, Ryan Roberts wrote: > In addition to passing a bitfield of folio orders to enable for THP, > allow the string "recommend" to be written, which has the effect of > causing the system to enable the orders preferred by the architecture > and by the mm. The user can see what these orders are by subsequently > reading back the file. > > Note that these recommended orders are expected to be static for a given > boot of the system, and so the keyword "auto" was deliberately not used, > as I want to reserve it for a possible future use where the "best" order > is chosen more dynamically at runtime. > > Recommended orders are determined as follows: > - PMD_ORDER: The traditional THP size > - arch_wants_pte_order() if implemented by the arch > - PAGE_ALLOC_COSTLY_ORDER: The largest order kept on per-cpu free list > > arch_wants_pte_order() can be overridden by the architecture if desired. > Some architectures (e.g. arm64) can coalsece TLB entries if a contiguous > set of ptes map physically contigious, naturally aligned memory, so this > mechanism allows the architecture to optimize as required. > > Here we add the default implementation of arch_wants_pte_order(), used > when the architecture does not define it, which returns -1, implying > that the HW has no preference. > > Signed-off-by: Ryan Roberts > --- > Documentation/admin-guide/mm/transhuge.rst | 4 ++++ > include/linux/pgtable.h | 13 +++++++++++++ > mm/huge_memory.c | 14 +++++++++++--- > 3 files changed, 28 insertions(+), 3 deletions(-) > > diff --git a/Documentation/admin-guide/mm/transhuge.rst b/Documentation/admin-guide/mm/transhuge.rst > index 732c3b2f4ba8..d6363d4efa3a 100644 > --- a/Documentation/admin-guide/mm/transhuge.rst > +++ b/Documentation/admin-guide/mm/transhuge.rst > @@ -187,6 +187,10 @@ pages (=16K if the page size is 4K). The example above enables order-9 > By enabling multiple orders, allocation of each order will be > attempted, highest to lowest, until a successful allocation is made. > If the PMD-order is unset, then no PMD-sized THPs will be allocated. > +It is also possible to enable the recommended set of orders, which > +will be optimized for the architecture and mm:: > + > + echo recommend >/sys/kernel/mm/transparent_hugepage/anon_orders > > The kernel will ignore any orders that it does not support so read the > file back to determine which orders are enabled:: > diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h > index af7639c3b0a3..0e110ce57cc3 100644 > --- a/include/linux/pgtable.h > +++ b/include/linux/pgtable.h > @@ -393,6 +393,19 @@ static inline void arch_check_zapped_pmd(struct vm_area_struct *vma, > } > #endif > > +#ifndef arch_wants_pte_order > +/* > + * Returns preferred folio order for pte-mapped memory. Must be in range [0, > + * PMD_ORDER) and must not be order-1 since THP requires large folios to be at > + * least order-2. Negative value implies that the HW has no preference and mm > + * will choose it's own default order. > + */ > +static inline int arch_wants_pte_order(void) > +{ > + return -1; > +} > +#endif > + > #ifndef __HAVE_ARCH_PTEP_GET_AND_CLEAR > static inline pte_t ptep_get_and_clear(struct mm_struct *mm, > unsigned long address, > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index bcecce769017..e2e2d3906a21 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -464,10 +464,18 @@ static ssize_t anon_orders_store(struct kobject *kobj, > int err; > int ret = count; > unsigned int orders; > + int arch; > > - err = kstrtouint(buf, 0, &orders); > - if (err) > - ret = -EINVAL; > + if (sysfs_streq(buf, "recommend")) { > + arch = max(arch_wants_pte_order(), PAGE_ALLOC_COSTLY_ORDER); > + orders = BIT(arch); > + orders |= BIT(PAGE_ALLOC_COSTLY_ORDER); > + orders |= BIT(PMD_ORDER); > + } else { > + err = kstrtouint(buf, 0, &orders); > + if (err) > + ret = -EINVAL; > + } > > if (ret > 0) { > orders &= THP_ORDERS_ALL_ANON; :/ don't really like that. Regarding my proposal, one could have something like that in an "auto" setting for the "enabled" value, or a "recommended" setting [not sure]. -- Cheers, David / dhildenb _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel