linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: robin.murphy@arm.com (Robin Murphy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] iommu/arm-smmu-v3: suppress MSI allocation failure message
Date: Wed, 17 Jan 2018 18:54:02 +0000	[thread overview]
Message-ID: <2f651cfe-e006-cf1d-b624-08e2ba5340fc@arm.com> (raw)
In-Reply-To: <1516214399-24012-1-git-send-email-nwatters@codeaurora.org>

[ +Marc just in case ]

On 17/01/18 18:39, Nate Watterson wrote:
> From: Sinan Kaya <okaya@codeaurora.org>
> 
> Even though QDF2400 supports MSI interrupts with SMMUv3, it is not enabled
> in ACPI FW to preserve compatibility with older kernel versions. Code is
> emitting warning message during boot.
> 
> This is causing some test tools to record a false warning and is causing
> support issues.
> 
> Better reduce the message level.

Ugh, that's unfortunate, since there are also plenty of genuine error 
conditions encapsulated in there which we *would* want to report as such 
(but still then fall back to wired IRQs if possible). Is the return 
value sufficient to differentiate the "there is no MSI parent" and 
"there are MSIs but something went wrong" cases, or is it more 
complicated than that?

Robin.

> Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
> Signed-off-by: Nate Watterson <nwatters@codeaurora.org>
> ---
>   drivers/iommu/arm-smmu-v3.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iommu/arm-smmu-v3.c b/drivers/iommu/arm-smmu-v3.c
> index 744592d..2118fda 100644
> --- a/drivers/iommu/arm-smmu-v3.c
> +++ b/drivers/iommu/arm-smmu-v3.c
> @@ -2331,7 +2331,7 @@ static void arm_smmu_setup_msis(struct arm_smmu_device *smmu)
>   	/* Allocate MSIs for evtq, gerror and priq. Ignore cmdq */
>   	ret = platform_msi_domain_alloc_irqs(dev, nvec, arm_smmu_write_msi_msg);
>   	if (ret) {
> -		dev_warn(dev, "failed to allocate MSIs\n");
> +		dev_info(dev, "failed to allocate MSIs\n");
>   		return;
>   	}
>   
> 

  reply	other threads:[~2018-01-17 18:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-17 18:39 [PATCH] iommu/arm-smmu-v3: suppress MSI allocation failure message Nate Watterson
2018-01-17 18:54 ` Robin Murphy [this message]
2018-01-17 19:08   ` Marc Zyngier
2018-01-17 19:23     ` Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2f651cfe-e006-cf1d-b624-08e2ba5340fc@arm.com \
    --to=robin.murphy@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).