From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6D0FDC25B48 for ; Thu, 26 Oct 2023 17:32:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TMibSv575NRY8dIqciBX82l025MRVfVR5Z40AI8sxyk=; b=WmmJlDowh8Q6XR O4jUV2XbU9Ykt6MLAjJDa1+yacqSsQOBqFcl7esyJV1CZIphrhNpi9dVfDIoZ+hxrtWMsjJk1rMVN GSprKko/K996fxn6WkX8L19iFqQgzOPAjuNkQvAtdwTmafFlJNiw438pGgRgEOXuQ1C52LAXF9ypd 1J+Kq50nDP92B6sdVnXQT+vXS6a2NH0ljjdXrumkGtrcG1e8IOzrYgnTk+3BY6aCazBznl+VDtFqf LWGi0uRY6R8FXEGkFIqDykpMSNaFRGCX5oEx6C7/J4dcU8s1meWbOeBfTTKJbqZUIJa3BfSreqEJ1 kiJEcrjUAI3COaev+gHA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qw4DP-00Evix-38; Thu, 26 Oct 2023 17:32:15 +0000 Received: from vps0.lunn.ch ([156.67.10.101]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qw4DM-00EviB-2t for linux-arm-kernel@lists.infradead.org; Thu, 26 Oct 2023 17:32:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=SmHx3jkl1z1Z5WNyZ0jqXx1N6p/MHLa5cPZwrRRH/XA=; b=R+HFFvzodLije/BLIFZLopOoVf Rp3kMh5BdeSEJ5iH1IOZnJ5WIaOMhXfwYGYdbuJ9XEDo+AUXwMTG5gLJEqfw7hLXFgo2twpKrd3sZ Vyk2uQ7c1ffibVdPcjrodNXTiZC+7Qd9HWwagc/aYcENpFGmrF6BZKP1ydilbu9RyKC8=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1qw4DA-000Goq-FI; Thu, 26 Oct 2023 19:32:00 +0200 Date: Thu, 26 Oct 2023 19:32:00 +0200 From: Andrew Lunn To: Elad Nachman Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, pali@kernel.org, mrkiko.rs@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, cyuval@marvell.com Subject: Re: [PATCH v3 1/3] arm64: dts: cn913x: add device trees for COM Express boards Message-ID: <2f7ab700-cd87-42f2-870d-950a4c75b17d@lunn.ch> References: <20231026084735.3595944-1-enachman@marvell.com> <20231026084735.3595944-2-enachman@marvell.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231026084735.3595944-2-enachman@marvell.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231026_103212_937396_E6A75DFF X-CRM114-Status: UNSURE ( 9.93 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > +#include "cn9131-db-comexpress.dtsi" > + > +/ { > + model = "Marvell Armada AC5X RD COM EXPRESS type 7 carrier board"; > + compatible = "marvell,ac5x_rd_carrier", "marvell,cn9131", "marvell,cn9130", > + "marvell,armada-ap807-quad", "marvell,armada-ap807"; This is really a question to the DT Maintainers. This is a carrier board for a standardised Com express type 7 board. In theory, you should be able to plug any Com Express module into it, not just Marvells. So should the compatible list just have a compatible for the carrier itself? Not the module which would normally be mounted in it? Should the carrier have a .dtsi file describing it? And then we have a .dts file which combines the module .dtsi and the carrier .dtsi? Sorry i did not ask this earlier, i was thinking more about SolidRuns systems, which tend to have custom SOMs and customs carriers, so you can only really mount one particular SOM into one particular carrier. But that is not true here. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel