From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7D12C4332F for ; Fri, 15 Oct 2021 08:07:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A180C6115C for ; Fri, 15 Oct 2021 08:07:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A180C6115C Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=roX12w7eJJ9Ky74eXKFY9yRzk6Rk/+VR4dAd4SqOkqA=; b=GVYD2tTfHqCXWi 2PzW8ziUs0PxV6OZg8Hyh9fvdQy1K74AvgfZsfmWdfSdrIpwH75Ju2UrSW2IBN2KU8Bou2isC56wN aYHGWKM+SyADCCa0d2dVkiuY3YQGAXPfN44SVvD5TERor/mCwO/KaUKz79YMfNMRqUy6Do1ymCFTB FujQJFTp3VEtezrcU+UJy7OzBmox1oMPpqAd/+6FqB57QYkAWnxuFsvMi8Fhgl4u0kUvVKfJjPS6Q RtOa18KBx3eghTbLwKcMcgWBbqlkFcEQGWGgvO4nWPYCAGydgWZjHLUVnLl5/0Jsbhu0aSKE1gbHP X7U0/seJYWbpny9Koz3w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mbICd-005qio-Pq; Fri, 15 Oct 2021 08:04:33 +0000 Received: from esa.microchip.iphmx.com ([68.232.153.233]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mbI9a-005pS5-TX for linux-arm-kernel@lists.infradead.org; Fri, 15 Oct 2021 08:01:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1634284882; x=1665820882; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=l8YS04J6TxsJ3upxIg2G369h0E9NlS6upnnzsFrbiPc=; b=zi6wvYS6OS4pfl90av0YoW1Gr4fsZoUPerZ2PNCp9+rWC0buzFJLhENk P5VLgummvcY0jMpFeZi7XvPN47nGzh6U/C0RLdzkgiqgoeszQSnByTCEd gc5sAwmfiq7VV2dBjnh7zfNrOTOtO4C8Pxb85moc9CmA10qFpIGDZQRnH XgZcd8D7sxuokkJ2bKQiATORNjdCuR0zvpozrkmKjw+iTbXOhurk61gfa zk+g+1GuRU7b8zMDXN2w12kRwhkciQqOdKA3DHi/oWPt0kuTaptmJIopS pxZEvVjVZhs7tLO4PyYXYycHQMnlH1Gj8CKjZzcMRp9/ku1OfN9mYcsvE w==; IronPort-SDR: 2wLt9jrQOqXY6JJ09/JmHFb+NoLjNkGVJzHn6JNMJnCQhQK7V9v8Wox5izfJQdzKvaA51QBDRA fCGlSIXS4cfH3etNeeBlgjLzjLbkRf1BHkUWx9CHVyFw7NJ1eBejdi/mTazllExX8I4l6/yte/ yq6pY1k2g83RIJQsRPH8g29Nzldnpf5PZ2vtkQ6w3hiYX2d9rT+zpQ189a8kiNvkgCwElkH1a2 vHOXXjfG+mW8u65dLH/cs+N8cWqv7/CchtrAZZMQaqW+CiXaut0hF6fknmnI10QyMZWCntf4v5 ovwp1lb4Z+J2dKPU6Ew7Sjan X-IronPort-AV: E=Sophos;i="5.85,375,1624345200"; d="scan'208";a="140404536" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa3.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 15 Oct 2021 01:01:21 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Fri, 15 Oct 2021 01:01:21 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14 via Frontend Transport; Fri, 15 Oct 2021 01:01:21 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bWOBmqIb81LSIDF+n5qe3gShbVeUZkAck7q4fDJpGj5ZQRn7C930vuAyj1bTr3sZmKsRedVoElROM17k3ZULfILXWEYHjcoaFmzt7jaJQu616B5Cwf17suIy9gKerb50x/PHoYBFMxdkcs0YRUJycsVZJJGXnvVOR9nKkxKjLqNTQ7MAMQ8PoXQurcFCzso6PL6RHuOeGA12F81xdWq7sIrrhhpINLRbZ8cBl3zPpOHxFpdTOMjM2hp3GNDfVUZHZBr0Kydp3IeGWK8kJ3a7/Dq5s5GH7Kv5Kq1WL5RBQh5mfj3MYn6hcnmY0rfWDdAH1zGBlnJFtpEHBFmocWW40g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=l8YS04J6TxsJ3upxIg2G369h0E9NlS6upnnzsFrbiPc=; b=DFBoZD+dMJoG7fv6tPPKSUtkfirJPgZ60s2xByrg77JvmNCQbCnThA4KGpWOMuR504VxophSW+cdHOGgNQIN+FtFx0h0DBi2Vw7u8/KcoIQwjKbvZN5wEnkIXWjob7SCZNkFVDGhMKRXnKiwUiF12i2suRyoxLc3JZMAcI8tege47Q6QXCms7iScHwrMncOuXlDl7ksDXAZnVPZ/F4yLr9PvVNYADMrDrB6K9N9XQ/09hWKXs9Hp5ylxICYOR/ZNqMREF6Vw+MAWPRqwh4NOYlB0w6KmM3URrjQqlR9WRoSvBsWVutN7FiOWVyWWGbj7KeRm4ICmQ5rfZLPJzEljDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l8YS04J6TxsJ3upxIg2G369h0E9NlS6upnnzsFrbiPc=; b=QlEBVkA/OrLNRD3BHKuiiLQSLhcygLJDmVG9V/WP6jBsOXs+KmtDaJBq7xxUHkK8U3EQldkWd8iAyrhjOu36UI3sAo6cBw6DnYsiHgpPfdWyMFQPK+qY521iD9DO+Mm08Vaz+yZrLw32YGniBy2p4dR10K4CaEAi+cpDDhZIFUk= Received: from SA2PR11MB4874.namprd11.prod.outlook.com (2603:10b6:806:f9::23) by SA0PR11MB4717.namprd11.prod.outlook.com (2603:10b6:806:9f::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Fri, 15 Oct 2021 08:01:16 +0000 Received: from SA2PR11MB4874.namprd11.prod.outlook.com ([fe80::a496:d4af:df74:5213]) by SA2PR11MB4874.namprd11.prod.outlook.com ([fe80::a496:d4af:df74:5213%9]) with mapi id 15.20.4587.026; Fri, 15 Oct 2021 08:01:16 +0000 From: To: , , CC: , , Subject: Re: [PATCH 3/4] dmaengine: at_xdmac: use __maybe_unused for pm functions Thread-Topic: [PATCH 3/4] dmaengine: at_xdmac: use __maybe_unused for pm functions Thread-Index: AQHXwZrUafk2m7OWmUi676gTLPMENQ== Date: Fri, 15 Oct 2021 08:01:16 +0000 Message-ID: <2f897cb2-a498-c386-2d5b-26a304f20d1f@microchip.com> References: <20211007111230.2331837-1-claudiu.beznea@microchip.com> <20211007111230.2331837-4-claudiu.beznea@microchip.com> In-Reply-To: <20211007111230.2331837-4-claudiu.beznea@microchip.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 authentication-results: microchip.com; dkim=none (message not signed) header.d=none;microchip.com; dmarc=none action=none header.from=microchip.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 996687bb-1079-4508-ede3-08d98fb1f72a x-ms-traffictypediagnostic: SA0PR11MB4717: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4502; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BqyUynV74T2x9YMHIan47AI2GRh0TnuvfaUoBWUhIM1l5lJDmhlpPnCL+70f/1oLX8auNsoo+ii6oru+u0/QHFaTVGwskHLc2YPbjkRNrGrfBSLFvI84QkbFzSmJcWThcgPZMXFcIdD2zcB8wveeWBha1iyN1MNp1KM+MuWVYAyNa8KwUNPHfklCGaJLQvxLyaBVThGDUxg9vwrNIDZh+KZqjdeU99tQueV56Z1XjHQzNAF6Ns6Cwe39QedArRWOQIwO8R5md+p68APPX5DsA6hGyVr9PvIQLsC3reERsSJ27FxeEWXsFYa87rSCrW8h0iy+y1U+NDBmOoMdccANbY5SFx+LrkQoIW3aXZQs35vDVqjhG+gpGKPwv89ZSyfdPgjZPf6VBKcxIR1WO2/D9bMVgxBuF2L6xc4Kxg8TzW2D51derhFVSnIBQ+s5cq1c7yat0JwNeeaAY8vWWClLEyXdJeLEGR6E987A9GM+COr0HF2gQ1W/F/woc9WORfpbnrF4R6imibD/zW2+NSxM3xn8FpXdBhB1LzTdQlzOuzjKREyBQ8OZY0cZQ2usNH3WucsHtJJwzftG4eNTG0ZDb0SPEU6kEwq9/OU++0jdpRzAvS27aedT4S0NLm1OfC/SZcxlTyuBmS9n++CHuj/6IZN7eVAwcnjQjwp5U1dJ/qJ6KDTCkiFS3Q/sb3w2k1GxOdHKBzRSv57iqTgBIdQRn3Z8CCT/5bmNKNbePBpClk73e/gYYQ61VS9Cp+4dZosDpVGFCuG2cc7dSgPMuNZbjg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA2PR11MB4874.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(6512007)(2616005)(8936002)(8676002)(66446008)(6506007)(64756008)(66946007)(91956017)(71200400001)(86362001)(76116006)(54906003)(66556008)(316002)(2906002)(5660300002)(53546011)(66476007)(508600001)(83380400001)(110136005)(31696002)(186003)(4326008)(31686004)(38070700005)(38100700002)(122000001)(36756003)(26005)(6486002)(43740500002)(45980500001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?M2Nhc3crSXNibEdqN0dkRW1aREdZYU9wM3BBSUpHN1Nkbnovb040d01VTlJy?= =?utf-8?B?SU9rdEhNTnVhenNORW00UGpOTVp2TlA4NG5GVmdzVGlSZ3BocElSNFBzSkpV?= =?utf-8?B?cE1lK0tLaEFzNnpQeGdvMm9SemZiMnZPR1ZpUWRUQnZOcWpLck1xcE9OeTZl?= =?utf-8?B?cmdGSHJOWWNCOFNWc1huR01qV2VvNWVQSW1ydVV5Z2JYRlUvUTkrVzNka0FZ?= =?utf-8?B?TFBTYWp4WHU3dU4wL3FpOHhPYXZDeEpmaFdqdkh1YkVPd2tXSk93ZUVBTUFX?= =?utf-8?B?L0tLQnU5QU9QV2RUT25MRHRKNDF1SkNMQzNocEVSYU51cVlaUTl2eUhBRDk3?= =?utf-8?B?bElSQyt3MmhGYnk0UmlkRiswZHIrbndJdk5YbUF1S0xNQmcwSjZycWNzN0sr?= =?utf-8?B?MmJ5cit3SjRDWlNjM1lRNG5EL3Z3Z2RxYmVkdXllL3p3MW1vQVd4Z05UTjJv?= =?utf-8?B?WDFQbmdrRi85aVNKN0VkVWxDYmRPcnpvSXRJTDhmbTJ4SVdIdTkrWlBKcGx1?= =?utf-8?B?Ujg1aXhmcy9Kd0RYWmhjZGFPWG9MYkFGQkVqNHR5Ty9vWDRRdURqUWlGR1dX?= =?utf-8?B?ZSt1USt5SHlyNk5iSlVNMk1NZ0hrYnNDenZBVnFmN2ZWeEhjZ1BOQldFdlFP?= =?utf-8?B?UEhlbGw0MEJOVWJXVTkrbzhUT0QrNTVlMGtqYVlpUXlDMFcxYjZEYnpzY1gv?= =?utf-8?B?R25tWDJuaGU5RndmaFFnU3kySjNvblVlYlg2WFpmMFNLb2I3M1ZzSnN4N25G?= =?utf-8?B?ajJhN0tYK1JBZDh2TE5XczY5TWFrcnFBQ2RlVnd0N1VIT2M1TEdRVngvTGYw?= =?utf-8?B?OWxucmYxd3lNTzBDeHVnMzZwSkFCSFhmc1BtY3NmdVBlRlNvdndEZDJXMFVS?= =?utf-8?B?eHYyaVlRNWtrckg0dzlTTTVzV2ZsU2pHaEJ5TWtwWVc0YTlnalVSZ2xrRlpF?= =?utf-8?B?L0luODR0bTlFazU4R1BxaWZMSWp0NmpaOC9oOGtxOEtURTR6d0x4cFA0dXMx?= =?utf-8?B?eWtUSU1XeUlibEMwd0k2ZUFBejJFSUR1cXlsNldoU2JVSE12cENyeEhhdm04?= =?utf-8?B?MzhyVVVTV1hBZHdyK2ZBWFJseUI3NEw4WHVMVkYvTWVwdWV5ZnBpTk9rZkN5?= =?utf-8?B?cUxEZUFqK1BBdDlEeVpERzhyZkxQOUYyazJNbFQzVUxCYnpENmxmaW40TG9X?= =?utf-8?B?OFVwWVo2YW5DSFhUaGoxVml2S21PUE5EZXlsalpnVXdGMTBDem5kOG1qY3lj?= =?utf-8?B?eFhBSWRpRDUvYU9aRnY0aU1xQnZZS1g1UnM5d3VPOHg4dmh6L1h5RnBkaTUz?= =?utf-8?B?eFQ3cEJLRE8xaFEyNzJDUHY1U3dpWnIwM0lBUjBtNVd2SGwxK25Lc3FnUytH?= =?utf-8?B?S2ZmY1huQ2FjUEhhamJmVk80eHlPTGt3aHMyMzdBRE5VSko1YUdoaW5LbjFl?= =?utf-8?B?VU55MERzU0VwdWVlMElHaVEvVUZqd2VDcnExNHVHZ0RkaEZ5OGNHbDBKR2d0?= =?utf-8?B?OHg1aDA1cCtJSkREZFM3ZkFxa2ZETW5XVmVHaDVaTm1IRGk3MVFFT2NUMHlU?= =?utf-8?B?Zi9penNIaStTZW0vNmJ6SUMzZnF1b1lsK3BhVmVYWmRxNUNoTE5IaDU5K1Vr?= =?utf-8?B?TlZyeU0rTU15SUxSU3lHOVVkbzBGQWN4ME4rVWpFZ3pIV0pZK29DYnFzazBh?= =?utf-8?B?Zzc3bnJ6YVNMUGhrNjk4blBXYkY2UW1mU2Y0bEhsdTQyM3V6RzlGb0drWUtn?= =?utf-8?Q?Jmj2jpriQgY2zcgxOs=3D?= Content-ID: <8FAE3876F6208A4390BF48C2AA1666BD@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA2PR11MB4874.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 996687bb-1079-4508-ede3-08d98fb1f72a X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Oct 2021 08:01:16.6821 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Knn7iPkNGkv2cWk4OiO3cif804zOTLpHHqCtzfZ3FWiJAdrLjdmBswMm2VPdtu2QhBxYhcfSfASCUSu7Rq0p9SLdKNjKm8AqxZ2CiNzON9c= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4717 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211015_010123_031700_000AAD72 X-CRM114-Status: GOOD ( 16.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/7/21 2:12 PM, Claudiu Beznea wrote: > Use __maybe_unused for pm functions. Explaining why would be nice. E.g. avoiding ifdefs throughout the code, and stop defining atmel_xdmac_prepare as NULL. > > Signed-off-by: Claudiu Beznea Reviewed-by: Tudor Ambarus > --- > drivers/dma/at_xdmac.c | 12 +++--------- > 1 file changed, 3 insertions(+), 9 deletions(-) > > diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c > index e18abbd56fb5..12371396fcc0 100644 > --- a/drivers/dma/at_xdmac.c > +++ b/drivers/dma/at_xdmac.c > @@ -1950,8 +1950,7 @@ static void at_xdmac_axi_config(struct platform_device *pdev) > } > } > > -#ifdef CONFIG_PM > -static int atmel_xdmac_prepare(struct device *dev) > +static int __maybe_unused atmel_xdmac_prepare(struct device *dev) > { > struct at_xdmac *atxdmac = dev_get_drvdata(dev); > struct dma_chan *chan, *_chan; > @@ -1965,12 +1964,8 @@ static int atmel_xdmac_prepare(struct device *dev) > } > return 0; > } > -#else > -# define atmel_xdmac_prepare NULL > -#endif > > -#ifdef CONFIG_PM_SLEEP > -static int atmel_xdmac_suspend(struct device *dev) > +static int __maybe_unused atmel_xdmac_suspend(struct device *dev) > { > struct at_xdmac *atxdmac = dev_get_drvdata(dev); > struct dma_chan *chan, *_chan; > @@ -1994,7 +1989,7 @@ static int atmel_xdmac_suspend(struct device *dev) > return 0; > } > > -static int atmel_xdmac_resume(struct device *dev) > +static int __maybe_unused atmel_xdmac_resume(struct device *dev) > { > struct at_xdmac *atxdmac = dev_get_drvdata(dev); > struct at_xdmac_chan *atchan; > @@ -2032,7 +2027,6 @@ static int atmel_xdmac_resume(struct device *dev) > } > return 0; > } > -#endif /* CONFIG_PM_SLEEP */ > > static int at_xdmac_probe(struct platform_device *pdev) > { > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel