From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 38660E7F150 for ; Wed, 27 Sep 2023 02:33:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QmA7loJ0kuoGt90pgYbzjbFmXwKIzufYqAae/YTWc9w=; b=mvbWBPHjR4AmU4 ev2iXaXxsrqz+SsnjERveZ684NcCiX6+TPsIX6ae21iel8gJyEhFeIc68NQn+loI87DIO+PjK2nKg o2DGlnLKdvca+wSqtfpjaubmsiXpaoexoeZpSiElo3kLU6BYCd0QYND/562i2Sr4IvkXCwdVZTA1V xBJOUS5QtY2T/Qdb0bNZ1IwF9e6XaYzS8zWfk9PXDcc6SheXFtGId8DMohqPxxdefDsf4K54bKVRH Yq8DFVFRQpISuCAZ9ntU3QiCCTrGB3ysiLxFoI3r7dIoumampT7nsMAQmik/PhSwLMlqO4A0qdqST oWS3koPLWjkH7hG8BylQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qlKMe-00HNG7-2n; Wed, 27 Sep 2023 02:33:24 +0000 Received: from lelv0142.ext.ti.com ([198.47.23.249]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qlKMa-00HNFU-2B for linux-arm-kernel@lists.infradead.org; Wed, 27 Sep 2023 02:33:22 +0000 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 38R2XHfP013973; Tue, 26 Sep 2023 21:33:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1695781997; bh=7AKkCUIIjXosndBxlHmGTWyhZDiPu05U+B4Tu8+KOIU=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=FWMWOdL2282Hn15OJHg+R6Uj7jQasuCdJja0grMRBeDFTpEXYnWsw8CNVWmM67gjZ b6iDwjdMup+0C1bGqzzqWf/K/I1VMGjYwWJ+ctBGIrvOJx6UpG3qBTLqTEKE3BJVWL BAws93Y4/9W+wuNcuJFZV8nE1ILXNI+X/W44ewDs= Received: from DFLE102.ent.ti.com (dfle102.ent.ti.com [10.64.6.23]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 38R2XHmO023481 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 26 Sep 2023 21:33:17 -0500 Received: from DFLE109.ent.ti.com (10.64.6.30) by DFLE102.ent.ti.com (10.64.6.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Tue, 26 Sep 2023 21:33:16 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE109.ent.ti.com (10.64.6.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Tue, 26 Sep 2023 21:33:17 -0500 Received: from [10.249.131.134] (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 38R2XDGJ096415; Tue, 26 Sep 2023 21:33:13 -0500 Message-ID: <2f9d2c67-a056-3422-baff-9398a4c6b147@ti.com> Date: Wed, 27 Sep 2023 08:03:12 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v5 4/7] arm64: dts: ti: k3-j784s4-main: Add the main domain watchdog instances Content-Language: en-US To: Nishanth Menon CC: , , , , , , , , References: <20230926132805.6518-1-j-keerthy@ti.com> <20230926132805.6518-5-j-keerthy@ti.com> <20230926171213.nihjj2nsnnvnxhel@gradation> From: "J, KEERTHY" In-Reply-To: <20230926171213.nihjj2nsnnvnxhel@gradation> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230926_193320_797603_CAB426F8 X-CRM114-Status: GOOD ( 14.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/26/2023 10:42 PM, Nishanth Menon wrote: > On 18:58-20230926, Keerthy wrote: >> There are totally 19 instances of watchdog module. One each for the >> 8 A72 cores, one each for the 4 C7x cores, 1 for the GPU, 1 each >> for the 6 R5F cores in the main domain. Keeping only the A72 instances >> enabled and disabling the rest by default. >> >> Signed-off-by: Keerthy >> --- >> arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi | 182 +++++++++++++++++++++ >> 1 file changed, 182 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi >> index 26dc3776f911..8c3efe066803 100644 >> --- a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi >> +++ b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi >> @@ -1576,4 +1576,186 @@ >> <695>; >> bootph-pre-ram; >> }; >> + >> + watchdog0: watchdog@2200000 { >> + compatible = "ti,j7-rti-wdt"; >> + reg = <0x00 0x2200000 0x00 0x100>; >> + clocks = <&k3_clks 348 1>; >> + power-domains = <&k3_pds 348 TI_SCI_PD_EXCLUSIVE>; >> + assigned-clocks = <&k3_clks 348 0>; >> + assigned-clock-parents = <&k3_clks 348 4>; >> + }; >> + >> + watchdog1: watchdog@2210000 { >> + compatible = "ti,j7-rti-wdt"; >> + reg = <0x00 0x2210000 0x00 0x100>; >> + clocks = <&k3_clks 349 1>; >> + power-domains = <&k3_pds 349 TI_SCI_PD_EXCLUSIVE>; >> + assigned-clocks = <&k3_clks 349 0>; >> + assigned-clock-parents = <&k3_clks 349 4>; >> + }; >> + >> + watchdog2: watchdog@2220000 { >> + compatible = "ti,j7-rti-wdt"; >> + reg = <0x00 0x2220000 0x00 0x100>; >> + clocks = <&k3_clks 350 1>; >> + power-domains = <&k3_pds 350 TI_SCI_PD_EXCLUSIVE>; >> + assigned-clocks = <&k3_clks 350 0>; >> + assigned-clock-parents = <&k3_clks 350 4>; >> + }; >> + >> + watchdog3: watchdog@2230000 { >> + compatible = "ti,j7-rti-wdt"; >> + reg = <0x00 0x2230000 0x00 0x100>; >> + clocks = <&k3_clks 351 1>; >> + power-domains = <&k3_pds 351 TI_SCI_PD_EXCLUSIVE>; >> + assigned-clocks = <&k3_clks 351 0>; >> + assigned-clock-parents = <&k3_clks 351 4>; >> + }; >> + >> + watchdog4: watchdog@2240000 { >> + compatible = "ti,j7-rti-wdt"; >> + reg = <0x00 0x2240000 0x00 0x100>; >> + clocks = <&k3_clks 352 1>; >> + power-domains = <&k3_pds 352 TI_SCI_PD_EXCLUSIVE>; >> + assigned-clocks = <&k3_clks 352 0>; >> + assigned-clock-parents = <&k3_clks 352 4>; >> + }; >> + >> + watchdog5: watchdog@2250000 { >> + compatible = "ti,j7-rti-wdt"; >> + reg = <0x00 0x2250000 0x00 0x100>; >> + clocks = <&k3_clks 353 1>; >> + power-domains = <&k3_pds 353 TI_SCI_PD_EXCLUSIVE>; >> + assigned-clocks = <&k3_clks 353 0>; >> + assigned-clock-parents = <&k3_clks 353 4>; >> + }; >> + >> + watchdog6: watchdog@2260000 { >> + compatible = "ti,j7-rti-wdt"; >> + reg = <0x00 0x2260000 0x00 0x100>; >> + clocks = <&k3_clks 354 1>; >> + power-domains = <&k3_pds 354 TI_SCI_PD_EXCLUSIVE>; >> + assigned-clocks = <&k3_clks 354 0>; >> + assigned-clock-parents = <&k3_clks 354 4>; >> + }; >> + >> + watchdog7: watchdog@2270000 { >> + compatible = "ti,j7-rti-wdt"; >> + reg = <0x00 0x2270000 0x00 0x100>; >> + clocks = <&k3_clks 355 1>; >> + power-domains = <&k3_pds 355 TI_SCI_PD_EXCLUSIVE>; >> + assigned-clocks = <&k3_clks 355 0>; >> + assigned-clock-parents = <&k3_clks 355 4>; >> + }; >> + >> + watchdog16: watchdog@2300000 { >> + status = "disabled"; > > wow.. lots of watchdogs.. but you seem to have missed the document why > disabled comment here AND missed the comment about using status > as the last property. > https://lore.kernel.org/all/5187c590-ee9a-4c46-b326-655f4c371aaf@linaro.org/ I will fix it in v6. > >> + compatible = "ti,j7-rti-wdt"; >> + reg = <0x00 0x2300000 0x00 0x100>; >> + clocks = <&k3_clks 356 1>; >> + power-domains = <&k3_pds 356 TI_SCI_PD_EXCLUSIVE>; >> + assigned-clocks = <&k3_clks 356 0>; >> + assigned-clock-parents = <&k3_clks 356 4>; >> + }; >> + >> + watchdog17: watchdog@2310000 { >> + status = "disabled"; >> + compatible = "ti,j7-rti-wdt"; >> + reg = <0x00 0x2310000 0x00 0x100>; >> + clocks = <&k3_clks 357 1>; >> + power-domains = <&k3_pds 357 TI_SCI_PD_EXCLUSIVE>; >> + assigned-clocks = <&k3_clks 357 0>; >> + assigned-clock-parents = <&k3_clks 357 4>; >> + }; >> + >> + watchdog18: watchdog@2320000 { >> + status = "disabled"; >> + compatible = "ti,j7-rti-wdt"; >> + reg = <0x00 0x2320000 0x00 0x100>; >> + clocks = <&k3_clks 358 1>; >> + power-domains = <&k3_pds 358 TI_SCI_PD_EXCLUSIVE>; >> + assigned-clocks = <&k3_clks 358 0>; >> + assigned-clock-parents = <&k3_clks 358 4>; >> + }; >> + >> + watchdog19: watchdog@2330000 { >> + status = "disabled"; >> + compatible = "ti,j7-rti-wdt"; >> + reg = <0x00 0x2330000 0x00 0x100>; >> + clocks = <&k3_clks 359 1>; >> + power-domains = <&k3_pds 359 TI_SCI_PD_EXCLUSIVE>; >> + assigned-clocks = <&k3_clks 359 0>; >> + assigned-clock-parents = <&k3_clks 359 4>; >> + }; >> + >> + watchdog15: watchdog@22f0000 { >> + status = "disabled"; >> + compatible = "ti,j7-rti-wdt"; >> + reg = <0x00 0x22f0000 0x00 0x100>; >> + clocks = <&k3_clks 360 1>; >> + power-domains = <&k3_pds 360 TI_SCI_PD_EXCLUSIVE>; >> + assigned-clocks = <&k3_clks 360 0>; >> + assigned-clock-parents = <&k3_clks 360 4>; >> + }; >> + >> + watchdog28: watchdog@23c0000 { >> + status = "disabled"; >> + compatible = "ti,j7-rti-wdt"; >> + reg = <0x00 0x23c0000 0x00 0x100>; >> + clocks = <&k3_clks 361 1>; >> + power-domains = <&k3_pds 361 TI_SCI_PD_EXCLUSIVE>; >> + assigned-clocks = <&k3_clks 361 0>; >> + assigned-clock-parents = <&k3_clks 361 4>; >> + }; >> + >> + watchdog29: watchdog@23d0000 { >> + status = "disabled"; >> + compatible = "ti,j7-rti-wdt"; >> + reg = <0x00 0x23d0000 0x00 0x100>; >> + clocks = <&k3_clks 362 1>; >> + power-domains = <&k3_pds 362 TI_SCI_PD_EXCLUSIVE>; >> + assigned-clocks = <&k3_clks 362 0>; >> + assigned-clock-parents = <&k3_clks 362 4>; >> + }; >> + >> + watchdog30: watchdog@23e0000 { >> + status = "disabled"; >> + compatible = "ti,j7-rti-wdt"; >> + reg = <0x00 0x23e0000 0x00 0x100>; >> + clocks = <&k3_clks 363 1>; >> + power-domains = <&k3_pds 363 TI_SCI_PD_EXCLUSIVE>; >> + assigned-clocks = <&k3_clks 363 0>; >> + assigned-clock-parents = <&k3_clks 363 4>; >> + }; >> + >> + watchdog31: watchdog@23f0000 { >> + status = "disabled"; >> + compatible = "ti,j7-rti-wdt"; >> + reg = <0x00 0x23f0000 0x00 0x100>; >> + clocks = <&k3_clks 364 1>; >> + power-domains = <&k3_pds 364 TI_SCI_PD_EXCLUSIVE>; >> + assigned-clocks = <&k3_clks 364 0>; >> + assigned-clock-parents = <&k3_clks 364 4>; >> + }; >> + >> + watchdog32: watchdog@2540000 { >> + status = "disabled"; >> + compatible = "ti,j7-rti-wdt"; >> + reg = <0x00 0x2540000 0x00 0x100>; >> + clocks = <&k3_clks 365 1>; >> + power-domains = <&k3_pds 365 TI_SCI_PD_EXCLUSIVE>; >> + assigned-clocks = <&k3_clks 365 0>; >> + assigned-clock-parents = <&k3_clks 366 4>; >> + }; >> + >> + watchdog33: watchdog@2550000 { >> + status = "disabled"; >> + compatible = "ti,j7-rti-wdt"; >> + reg = <0x00 0x2550000 0x00 0x100>; >> + clocks = <&k3_clks 366 1>; >> + power-domains = <&k3_pds 366 TI_SCI_PD_EXCLUSIVE>; >> + assigned-clocks = <&k3_clks 366 0>; >> + assigned-clock-parents = <&k3_clks 366 4>; >> + }; >> }; >> -- >> 2.17.1 >> > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel