From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E920CCFA457 for ; Thu, 24 Oct 2024 10:45:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:References:Cc:To:From:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=a3jFmzKhH5rnqOvx3UcKFh6vf+GougiqmhA7V3zUwdQ=; b=PIdXcg8b5T3IZ7/PXWZGqkrH8I LOH+gENdaRY7L/4tPH8O+doLRwf+zESGLg1jN+6E5xft2x64g7TJny0YbgvLofw9xLnhDL4WXixaU Ir1CcrdPVt3T2rPuxY5d7/Fv4jzb7y74FHVjzjvMn80uBPKKTszgQSkeo7jbn8sy8t9YHzbj2YKWF FX9+W/CTQpt5aaNKfZYnFGgwMgnHnRXGIdE4i9EXhd2myOOOKqVEMD3TLBGWp8uKvuJqOBzrlAsNq T6d7uzt/PucJx1ew9TQlRpelMTdNAGpdN2e+eeJfXMurnObOUPwCDKKGeOlz+9rhq8N1SGELd8sB1 MgX4zteA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t3vLK-000000006ys-3Rxj; Thu, 24 Oct 2024 10:45:26 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t3vCw-000000005dh-0IOi for linux-arm-kernel@lists.infradead.org; Thu, 24 Oct 2024 10:36:47 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4142B339; Thu, 24 Oct 2024 03:37:15 -0700 (PDT) Received: from [10.1.197.1] (ewhatever.cambridge.arm.com [10.1.197.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DCABD3F71E; Thu, 24 Oct 2024 03:36:43 -0700 (PDT) Message-ID: <30301f0b-5b04-4150-8159-5b8721486d6c@arm.com> Date: Thu, 24 Oct 2024 11:36:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/4] dt-bindings: arm: qcom,coresight-static-replicator: Add property for source filtering From: Suzuki K Poulose To: Tao Zhang , Mike Leach , James Clark , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mathieu Poirier , Leo Yan , Alexander Shishkin Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20241024065306.14647-1-quic_taozha@quicinc.com> <20241024065306.14647-2-quic_taozha@quicinc.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241024_033646_232072_6F3B6720 X-CRM114-Status: GOOD ( 17.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 24/10/2024 10:14, Suzuki K Poulose wrote: > On 24/10/2024 07:53, Tao Zhang wrote: >> The is some "magic" hard coded filtering in the replicators, >> which only passes through trace from a particular "source". Add >> a new property "filter-src" to label a phandle to the coresight >> trace source device matching the hard coded filtering for the port. > > As mentioned in here in v3 review : > > https://lkml.org/lkml/2024/8/21/597 > > Please do not use "src", expand it to "source" Just to confirm, this is only for the "bindings" string, not for the variables used in the patches. Suzuki > > Rest looks fine. > > Suzuki > >> >> Signed-off-by: Tao Zhang >> --- >>   .../arm/arm,coresight-static-replicator.yaml  | 19 ++++++++++++++++++- >>   1 file changed, 18 insertions(+), 1 deletion(-) >> >> diff --git >> a/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml >> index 1892a091ac35..0d258c79eb94 100644 >> --- >> a/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml >> +++ >> b/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml >> @@ -45,7 +45,22 @@ properties: >>       patternProperties: >>         '^port@[01]$': >>           description: Output connections to CoreSight Trace bus >> -        $ref: /schemas/graph.yaml#/properties/port >> +        $ref: /schemas/graph.yaml#/$defs/port-base >> +        unevaluatedProperties: false >> + >> +        properties: >> +          endpoint: >> +            $ref: /schemas/graph.yaml#/$defs/endpoint-base >> +            unevaluatedProperties: false >> + >> +            properties: >> +              filter-src: >> +                $ref: /schemas/types.yaml#/definitions/phandle >> +                description: >> +                  phandle to the coresight trace source device >> matching the >> +                  hard coded filtering for this port >> + >> +              remote-endpoint: true >>   required: >>     - compatible >> @@ -72,6 +87,7 @@ examples: >>                   reg = <0>; >>                   replicator_out_port0: endpoint { >>                       remote-endpoint = <&etb_in_port>; >> +                    filter-src = <&tpdm_video>; >>                   }; >>               }; >> @@ -79,6 +95,7 @@ examples: >>                   reg = <1>; >>                   replicator_out_port1: endpoint { >>                       remote-endpoint = <&tpiu_in_port>; >> +                    filter-src = <&tpdm_mdss>; >>                   }; >>               }; >>           }; >