From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3DD45C433F5 for ; Sat, 2 Apr 2022 11:55:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XAHh/2NWBtzvUKDFkj54EqWmZywZEErhS8ntdzLVWsg=; b=z45F+UL+/j1o0S UU7yg9u27jKr5PS0ZgU3g7tJQTJSl/r5MiFakzO+IOVuMUwBEQdLtVVqMzP4I8un1JM8lP1PUPcFF DGFuei3r+Rwluwce/PVVIBcPAgLrs3AmSZILYQ8qeeUn18Z+7HcET+tZcQrCMUCVYhBx5el/wvo5p t+dHwMG0N8hVvzW8bLXs7UGjE86wXYTu9G6uXL41x1QYQjF6086qYqNshAfKa51ZjqfxgZu0kKewR VN6EDfRL8E0dMYxbbxzowQQ7H0hYWEbIhTEML5XHYNEcfbh//lJvBdYiHYMDIeorZG+mUMbjk0kSY 01qnhNcpStCOJFgmyoQw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nacKV-008eY3-FK; Sat, 02 Apr 2022 11:54:07 +0000 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nacKQ-008eWd-FN for linux-arm-kernel@lists.infradead.org; Sat, 02 Apr 2022 11:54:04 +0000 Received: by mail-wm1-x335.google.com with SMTP id i132-20020a1c3b8a000000b0038ce25c870dso4983925wma.1 for ; Sat, 02 Apr 2022 04:54:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=V52rlSjUBjX18q5ePyn3LpZBqOKHJkgta+5HwLHOMW0=; b=XnK5bAIIi3zv7T/ehR45S4jlZjPkJ3/qNvHnmVWibopnvsRSX4bQ+IXKBkxvYpvObo zkFccOHMwJZam2O2w9NUGl5eXq5f2qkDQGKJjNZiCRfZLKiPSCcb0t1e+x1wg5fQCOfZ 5PjVSFI2HvTAgFYVgr+E5DuGbFmD2e09RTJfrLSRnmSbwnXLmSkfSjBzcmTOwPQNAzH1 VsGUp/c8zQMvbc8wbfyQ5I9g9gxjDEGL1mbELrDq7DKFBitRQnHsbwbx/LD9KBugb5jx MAoi5cljy4BS0owsuIF2L8AR8t+jdmr/9d0AnFAnzbIDklNdTDaPiHA2jJGfefJj/q5k ek+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=V52rlSjUBjX18q5ePyn3LpZBqOKHJkgta+5HwLHOMW0=; b=WPl9lKfrv4sBlLVEKIUeyEJR/XriuJU9ml8Y+STFImhGy3fRm0D3EkAH/DYfi1rGdR WJ5EsosuEe12yKDm93NfPl5+mAh6valWp9nulGXnjyPpBYVpsYUCYxBn93xxHuwBwggm i3AnBgEFLNl84V5vFlUKYmW0Z2Qqow9Xv8VtccOzzIdXGlwHEr5eFRmkEYuDd1Ni1Dtv yxVE3d1UMFltJGDrRe9ZdDZm5odYMiwLI5fBl9kaCE+7JttyPj7odhqNSdHUSmiZAVRz 2XvEfNSNLw7wXbmK0Ll+Sj+hzL8CUXnwxXsZBbVYVJswl+0Nl+LawVpORQgSQfPHo8ob JObw== X-Gm-Message-State: AOAM530bp/q2fHWhvPeeHNYswZoNjP8Ej/Q7ZAL8n1P0Gqz7FUAUafQ+ 7xAAg4ubWRQnzTfd7NNjzRoswSD2uz4VOzAO X-Google-Smtp-Source: ABdhPJzUxBryntMkO+ZJ8h+ZNSftDQhD4nc+rc5NkfcA9DVOV7UTv+TTeh6AFJbQTccTWOey+XICoA== X-Received: by 2002:a7b:cb84:0:b0:382:a9b9:2339 with SMTP id m4-20020a7bcb84000000b00382a9b92339mr12503684wmi.91.1648900440042; Sat, 02 Apr 2022 04:54:00 -0700 (PDT) Received: from [192.168.0.171] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.gmail.com with ESMTPSA id h11-20020a05600c414b00b0038e4b2f0478sm6504812wmm.1.2022.04.02.04.53.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 02 Apr 2022 04:53:59 -0700 (PDT) Message-ID: <30305936-4b69-e1ce-44c2-0d1d113b460e@linaro.org> Date: Sat, 2 Apr 2022 13:53:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v4 28/33] dt-bindings: crypto: rockchip: convert to new driver bindings Content-Language: en-US To: Corentin Labbe , heiko@sntech.de, herbert@gondor.apana.org.au, krzk+dt@kernel.org, robh+dt@kernel.org Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org References: <20220401201804.2867154-1-clabbe@baylibre.com> <20220401201804.2867154-29-clabbe@baylibre.com> From: Krzysztof Kozlowski In-Reply-To: <20220401201804.2867154-29-clabbe@baylibre.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220402_045402_541239_BF4F3531 X-CRM114-Status: GOOD ( 18.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 01/04/2022 22:17, Corentin Labbe wrote: > The latest addition to the rockchip crypto driver need to update the > driver bindings. > > Signed-off-by: Corentin Labbe > --- > .../crypto/rockchip,rk3288-crypto.yaml | 68 +++++++++++++++++-- > 1 file changed, 63 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/crypto/rockchip,rk3288-crypto.yaml b/Documentation/devicetree/bindings/crypto/rockchip,rk3288-crypto.yaml > index 66db671118c3..e6c00bc8bebf 100644 > --- a/Documentation/devicetree/bindings/crypto/rockchip,rk3288-crypto.yaml > +++ b/Documentation/devicetree/bindings/crypto/rockchip,rk3288-crypto.yaml > @@ -11,8 +11,18 @@ maintainers: > > properties: > compatible: > - enum: > - - rockchip,rk3288-crypto > + oneOf: > + - description: crypto IP present on RK3288 SoCs > + items: > + - const: rockchip,rk3288-crypto > + - description: crypto IP present on RK3328 SoCs These two comments are not helping, so this should be just enum. > + items: > + - const: rockchip,rk3328-crypto > + - description: crypto IPs present on RK3399. crypto0 is the first IP with > + RSA support, crypto1 is the second IP without RSA. The second part of this comment is helpful, first not. You have chosen enum in your first patch, so just extend it with comments. Additionally indexing does not scale. What if next generation reverses it and crypto0 does not have RSA and crypto1 has? Something like: properties: compatible: enum: - rockchip,rk3288-crypto - rockchip,rk3328-crypto # With RSA - rockchip,rk3399-crypto-rsa # Without RSA - rockchip,rk3399-crypto-norsa > + enum: > + - rockchip,rk3399-crypto0 > + - rockchip,rk3399-crypto1 > > reg: > maxItems: 1 > @@ -21,16 +31,65 @@ properties: > maxItems: 1 > > clocks: > + minItems: 3 > maxItems: 4 > > clock-names: > + minItems: 3 > maxItems: 4 > > resets: > - maxItems: 1 > + minItems: 1 > + maxItems: 3 > > reset-names: > - maxItems: 1 > + deprecated: true Why reset-names are being deprecated? Did we talk about this? > + > +allOf: > + - if: > + properties: > + compatible: > + contains: > + const: rockchip,rk3288-crypto > + then: > + properties: > + clock-names: > + items: > + - const: "aclk" > + - const: "hclk" > + - const: "sclk" > + - const: "apb_pclk" > + minItems: 4 minItems for clocks max for resets and reset-names > + - if: > + properties: > + compatible: > + contains: > + const: rockchip,rk3328-crypto > + then: > + properties: > + clock-names: > + items: > + - const: "hclk_master" > + - const: "hclk_slave" > + - const: "sclk" > + maxItems: 3 min/max for clocks max for resets and reset-names > + - if: > + properties: > + compatible: > + contains: > + enum: > + - rockchip,rk3399-crypto0 > + - rockchip,rk3399-crypto1 > + then: > + properties: > + clock-names: > + items: > + - const: "hclk_master" > + - const: "hclk_slave" > + - const: "sclk" > + maxItems: 3 > + resets: > + minItems: 3 Similarly. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel