From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CB367C52D7B for ; Thu, 8 Aug 2024 16:47:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/ckQAeiVICSPnXQHcD+dYye1R1eiYtHwPH+7sOrC45E=; b=v/PecMuIWZCiJCecQyhyW0HwOA 5fhrNjO+NkPflR46/OqBR1eU8I0JMFxSk3KjuApKb3k0ayVxuiMcUBjYAg6qoZDqPfyiLNDeE8fc6 uaFsFST1VA42YmQdExEolg2vcYFkgmczQWVXGVPeNiww3DKgBW534BXyaEOQlJDN1VoqNMTeYUkrw 78Gw8hPefqx3DtZGtL0c922tBsR9R/BD2pgLGvMN5pXYXJdnBT0Uutq4sUFHEIWep14LNfk9mwqw1 NyA2IrEoFxUAw2qhbnLG03rNPtFvom7qRIPwQoOQEHatcS3ayUnkBtYU4VfmXT6IDj9+/T/x4Hg6W caqyWwXg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sc6Hw-00000008zYo-4AN2; Thu, 08 Aug 2024 16:46:56 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sc6HN-00000008zTs-1ixX; Thu, 08 Aug 2024 16:46:22 +0000 Received: from i53875a9f.versanet.de ([83.135.90.159] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sc6HF-0004jv-7w; Thu, 08 Aug 2024 18:46:13 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Dragan Simic Cc: linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Detlev Casanova , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Ulf Hansson , Geert Uytterhoeven , "Rafael J . Wysocki" , Finley Xiao , Jagan Teki , Elaine Zhang , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 2/3] dt-bindings: Add power-domain header for RK3576 SoCs Date: Thu, 08 Aug 2024 18:46:12 +0200 Message-ID: <3030655.BQQF58Tnoo@diego> In-Reply-To: <0c66dbf97fc5a5adc3831b1ed01e1188@manjaro.org> References: <20240802151647.294307-1-detlev.casanova@collabora.com> <10908017.3WhfQktd6Z@diego> <0c66dbf97fc5a5adc3831b1ed01e1188@manjaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240808_094621_470332_F44000A9 X-CRM114-Status: GOOD ( 23.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Donnerstag, 8. August 2024, 18:43:42 CEST schrieb Dragan Simic: > Hello Heiko, >=20 > On 2024-08-08 09:54, Heiko St=FCbner wrote: > > Am Dienstag, 6. August 2024, 18:34:41 CEST schrieb Detlev Casanova: > >> On Sunday, 4 August 2024 05:56:39 EDT Krzysztof Kozlowski wrote: > >> > On 02/08/2024 17:14, Detlev Casanova wrote: > >> > > From: Finley Xiao > >> > > > >> > > Define power domain IDs as described in the TRM. > >> > > >> > Please use subject prefixes matching the subsystem. You can get them= for > >> > example with `git log --oneline -- DIRECTORY_OR_FILE` on the directo= ry > >> > your patch is touching. For bindings, the preferred subjects are > >> > explained here: > >> > https://www.kernel.org/doc/html/latest/devicetree/bindings/submittin= g-patche > >> > s.html#i-for-patch-submitters > >> > > Signed-off-by: Finley Xiao > >> > > [reword] > >> > > Signed-off-by: Detlev Casanova > >> > > --- > >> > > > >> > > include/dt-bindings/power/rk3576-power.h | 30 +++++++++++++++++++= +++++ > >> > > 1 file changed, 30 insertions(+) > >> > > create mode 100644 include/dt-bindings/power/rk3576-power.h > >> > > >> > This is part of bindings. > >> > > >> > > diff --git a/include/dt-bindings/power/rk3576-power.h > >> > > b/include/dt-bindings/power/rk3576-power.h > >> > Missing vendor prefix. This should be named after compatible. > >>=20 > >> Looks like all other rockchip power bindings use the=20 > >> include/dt-bindings/ > >> power/rkXXXX.h format. Should I keep that way ? > >=20 > > there is also rockchip,rv1126-power.h , so please follow Krzysztof's > > suggestion. Older header namings need to stay the same of course > > but that shouldn't keep us from updating naming schemes to better > > work in new additions. >=20 > Actually, why don't we rename the old headers to follow the new naming=20 > rules? > Is there something preventing us from doing that, which I'm missing? yes, the headers are _part_ of the actual devicetree-binding. So you have out of tree users in the BSDs or whereever else.