From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] iio: ak8975: fix AK09911 dependencies
Date: Mon, 09 Mar 2015 21:05:02 +0100 [thread overview]
Message-ID: <3043946.mVD7WvMa1C@wuerfel> (raw)
In-Reply-To: <54FD7AF2.8020605@kernel.org>
On Monday 09 March 2015 10:50:26 Jonathan Cameron wrote:
> >> diff --git a/drivers/iio/magnetometer/Kconfig b/drivers/iio/magnetometer/Kconfig
> >> index 4c7a4c52dd06..a5d6de72c523 100644
> >> --- a/drivers/iio/magnetometer/Kconfig
> >> +++ b/drivers/iio/magnetometer/Kconfig
> >> @@ -18,6 +18,8 @@ config AK8975
> >>
> >> config AK09911
> >> tristate "Asahi Kasei AK09911 3-axis Compass"
> >> + depends on I2C
> >> + depends on GPIOLIB
> >> select AK8975
> >> help
> >> Deprecated: AK09911 is now supported by AK8975 driver.
> >
> > I just saw the AK8975/AK09911 config options disappear for a v4.0-rc3 m68k
> > allmodconfig kernel. Apparently it built fine with !GPIOLIB before, as many
> > gpiolib (consumer) functions have dummies for the !GPIOLIB case.
> >
> > So I think the GPIOLIB dependency can be relaxed to "GPIOLIB || COMPILE_TEST".
> > The same may be true for many other GPIOLIB consumer drivers.
> > Will look into it and send patches...
The reason for this dependency is the 'select AK8975', which causes a Kconfig
warning if GPIOLIB is disabled. I do not see an actual dependency on gpiolib
in the ak8975 driver, but relaxing this means we have to remove the dependency
for both of them together, not just for AK09911.
Arnd
prev parent reply other threads:[~2015-03-09 20:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-28 13:58 [PATCH] iio: ak8975: fix AK09911 dependencies Arnd Bergmann
2015-02-04 17:32 ` Jonathan Cameron
2015-02-28 11:34 ` Jonathan Cameron
2015-03-09 10:27 ` Geert Uytterhoeven
2015-03-09 10:50 ` Jonathan Cameron
2015-03-09 20:05 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3043946.mVD7WvMa1C@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).